From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Marvin Häuser" <Marvin.Haeuser@outlook.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains.
Date: Tue, 14 Mar 2017 08:04:42 +0000 [thread overview]
Message-ID: <CAKv+Gu_mAkcpRbwQQny6ycdNXhwG257vPfgUX6oKhZQspGWp0w@mail.gmail.com> (raw)
In-Reply-To: <DB6PR0601MB2584873FF018DE567634F4DF80230@DB6PR0601MB2584.eurprd06.prod.outlook.com>
On 11 March 2017 at 23:05, Marvin Häuser <Marvin.Haeuser@outlook.com> wrote:
> modsi3.S references the symbol '__divsi3' by '___divsi3' which assumes
> the prefix is always required and supported. Use ASM_PFX() instead
> to support all compilers.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed, thanks.
> ---
> ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
> index 29e2df92b02f..d5624b90f9d5 100644
> --- a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
> +++ b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
> @@ -19,7 +19,7 @@ ASM_FUNC(__modsi3)
> add r7, sp, #8
> mov r5, r0
> mov r4, r1
> - bl ___divsi3
> + bl ASM_PFX(__divsi3)
> mul r0, r4, r0
> rsb r0, r0, r5
> ldmfd sp!, {r4, r5, r7, pc}
> --
> 2.12.0.windows.1
>
prev parent reply other threads:[~2017-03-14 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 22:05 [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains Marvin Häuser
2017-03-14 8:04 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_mAkcpRbwQQny6ycdNXhwG257vPfgUX6oKhZQspGWp0w@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox