* [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains.
@ 2017-03-11 22:05 Marvin Häuser
2017-03-14 8:04 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Marvin Häuser @ 2017-03-11 22:05 UTC (permalink / raw)
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org
modsi3.S references the symbol '__divsi3' by '___divsi3' which assumes
the prefix is always required and supported. Use ASM_PFX() instead
to support all compilers.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
index 29e2df92b02f..d5624b90f9d5 100644
--- a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
+++ b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
@@ -19,7 +19,7 @@ ASM_FUNC(__modsi3)
add r7, sp, #8
mov r5, r0
mov r4, r1
- bl ___divsi3
+ bl ASM_PFX(__divsi3)
mul r0, r4, r0
rsb r0, r0, r5
ldmfd sp!, {r4, r5, r7, pc}
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains.
2017-03-11 22:05 [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains Marvin Häuser
@ 2017-03-14 8:04 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2017-03-14 8:04 UTC (permalink / raw)
To: Marvin Häuser; +Cc: edk2-devel@lists.01.org, leif.lindholm@linaro.org
On 11 March 2017 at 23:05, Marvin Häuser <Marvin.Haeuser@outlook.com> wrote:
> modsi3.S references the symbol '__divsi3' by '___divsi3' which assumes
> the prefix is always required and supported. Use ASM_PFX() instead
> to support all compilers.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed, thanks.
> ---
> ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
> index 29e2df92b02f..d5624b90f9d5 100644
> --- a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
> +++ b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S
> @@ -19,7 +19,7 @@ ASM_FUNC(__modsi3)
> add r7, sp, #8
> mov r5, r0
> mov r4, r1
> - bl ___divsi3
> + bl ASM_PFX(__divsi3)
> mul r0, r4, r0
> rsb r0, r0, r5
> ldmfd sp!, {r4, r5, r7, pc}
> --
> 2.12.0.windows.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-14 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-11 22:05 [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains Marvin Häuser
2017-03-14 8:04 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox