From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F8EA8033C for ; Tue, 14 Mar 2017 01:04:43 -0700 (PDT) Received: by mail-it0-x232.google.com with SMTP id m27so42734569iti.0 for ; Tue, 14 Mar 2017 01:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mhegUOEpkFmoOKqxOp1djExAyo5V19n8ZRJL14eBUgI=; b=LhViIJwaUOWTxzeQHBg2oqChRHlEW4QzEYyk2kTWC9EqNJ/Woz0upjlnLrCzJ6l+yt fL+64BFMIXd0/LR2yIume7hHDB9oSBSQ9fWe8fYFZGxztf9B3wnQTb5819lkTcjiArwu 6XsXUBzB//iX/5+OVRqd9+/WetaL0pnsZWzlA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mhegUOEpkFmoOKqxOp1djExAyo5V19n8ZRJL14eBUgI=; b=JKHr4W0FQWVqp6Mox8od60XrrezhAm38b3D+FowKGLIZIVOcns/ueYyvECjtj34Lw6 eIC+cbvAh9J9DwfqwEnmRpWcEulXkY6rZr5DwWvAWtt6YSOan7/Tp1BM0dj7gLF1XEyt 5y86/qkPgjI7kN2joo4A9DDvc/mwLleHkMBPhBytgA/GN3KoaN6IHUGnbiLPkrVSKLuR R28up6utM1QHZ7x3O97s+r7NGTbKhSz/9qWoO4JIxe0vPzxX3w6UNid2s0BnGNJEP6xB OYBDdzVrkFtwHzHa9uDcOhatbw/Ba2viERD7p04s87gFydUJO6zmbDIdrYPjWp5vMR5e UY3A== X-Gm-Message-State: AFeK/H1MK8vOsq5Kg0o357qbdG19km7H5Rg9bPbR5i40qbZ/AivSbsVv3zJuEpyja7Xgkhv5Wi+wGahs/YhbJ3u6 X-Received: by 10.36.118.68 with SMTP id z65mr14131740itb.59.1489478682763; Tue, 14 Mar 2017 01:04:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Tue, 14 Mar 2017 01:04:42 -0700 (PDT) In-Reply-To: References: From: Ard Biesheuvel Date: Tue, 14 Mar 2017 08:04:42 +0000 Message-ID: To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" Subject: Re: [PATCH] ArmPkg: Fix modsi3.S compilation across toolchains. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 08:04:43 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11 March 2017 at 23:05, Marvin H=C3=A4user = wrote: > modsi3.S references the symbol '__divsi3' by '___divsi3' which assumes > the prefix is always required and supported. Use ASM_PFX() instead > to support all compilers. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Marvin Haeuser Reviewed-by: Ard Biesheuvel Pushed, thanks. > --- > ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S b/ArmPkg/L= ibrary/CompilerIntrinsicsLib/Arm/modsi3.S > index 29e2df92b02f..d5624b90f9d5 100644 > --- a/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S > +++ b/ArmPkg/Library/CompilerIntrinsicsLib/Arm/modsi3.S > @@ -19,7 +19,7 @@ ASM_FUNC(__modsi3) > add r7, sp, #8 > mov r5, r0 > mov r4, r1 > - bl ___divsi3 > + bl ASM_PFX(__divsi3) > mul r0, r4, r0 > rsb r0, r0, r5 > ldmfd sp!, {r4, r5, r7, pc} > -- > 2.12.0.windows.1 >