From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5535D21942352 for ; Thu, 6 Apr 2017 04:33:00 -0700 (PDT) Received: by mail-it0-x22e.google.com with SMTP id y18so24191308itc.1 for ; Thu, 06 Apr 2017 04:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XFUO4uLymyS4IpLjWd0My03FRA+Wc17nkgBrEJ7IoRM=; b=Y2Y3Zf0ZOUSNIQuWc6Msu7UJW5hnnHne4brFjqzqRmalxrzT+Yb0coQwWNI6xKVTwL qocG2z4ja8NMhHYZbga4PWS+QG/IOcGhJFeOET4UWTmk4STOH4hHKgpoU0HAwMcw3yFO HAp4XT0nXNLmjHMZLC39YDfqZHIxB7hmVz4JE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XFUO4uLymyS4IpLjWd0My03FRA+Wc17nkgBrEJ7IoRM=; b=knWX0CWrD8HVTo8TANoxjIU7si/OE+egEF4C4CFAtvzGgusainGFEcbhpp1SpLBbe0 6MVYfJeKp+5RbrspcA/Yk/95XFMyOmU3y7610QgDGyuPsFCPfnIXG6OQgabRJzO7NfJQ mIESaO6LR4+2X+cnQWz+tUdYStLJHfwDJAWkFSXVMDqVqTcjKZaDqXa4Roxypjag/EaJ 3KDLbAIOuUjm7i3yZHf/l9uiW0KvkBoUcbkqa0Ba3HF1e9539ElgebM4mYZsnqF88zhE +aEMD2xi9Z+ky3pKb/XdtZ0gRckjOw6tciK/YhC4A404/xQGO4tZc/zDP1IMcCi4mZaL vwLw== X-Gm-Message-State: AFeK/H0rH7S+60agBOdrjUuGJVLnyFLvtX9wVyNB2LTuMcZQrSOuh8tG 9cr4evbGwStw6jwdrOISFXUM9fKkFmLJ X-Received: by 10.36.65.148 with SMTP id b20mr3039462itd.59.1491478379421; Thu, 06 Apr 2017 04:32:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Thu, 6 Apr 2017 04:32:59 -0700 (PDT) In-Reply-To: References: <1491424713-5203-1-git-send-email-ard.biesheuvel@linaro.org> <1491424713-5203-2-git-send-email-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Thu, 6 Apr 2017 12:32:59 +0100 Message-ID: To: Ryan Harkin Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Jeremy Linton Subject: Re: [PATCH 2/2] ArmPlatformPkg/PL111LcdArmVExpressLib: use write-combine mapping for VRAM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 11:33:00 -0000 Content-Type: text/plain; charset=UTF-8 On 6 April 2017 at 12:14, Ryan Harkin wrote: > On 5 April 2017 at 21:38, Ard Biesheuvel wrote: >> Replace the uncached memory mapping of the framebuffer with a write- >> combining one. This improves performance, and avoids issues with >> unaligned accesses and DC ZVA instructions performed by the accelerated >> memcpy/memset routines. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel > > Well, ... PL111 isn't usually enabled for me. And if I enable it, > neither Foundation nor AEMv8 models boot with or without this patch. > > So it's no worse than before.... > Not even foundation model? That is strange ... > >> --- >> ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c >> index 2000c9bdf436..d18d6b3e1665 100644 >> --- a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c >> +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c >> @@ -192,7 +192,7 @@ LcdPlatformGetVram ( >> ASSERT_EFI_ERROR(Status); >> >> // Mark the VRAM as un-cachable. The VRAM is inside the DRAM, which is cachable. >> - Status = Cpu->SetMemoryAttributes(Cpu, *VramBaseAddress, *VramSize, EFI_MEMORY_UC); >> + Status = Cpu->SetMemoryAttributes(Cpu, *VramBaseAddress, *VramSize, EFI_MEMORY_WC); >> ASSERT_EFI_ERROR(Status); >> if (EFI_ERROR(Status)) { >> gBS->FreePool(VramBaseAddress); >> -- >> 2.7.4 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel