From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C170A21ED1C77 for ; Wed, 7 Mar 2018 07:49:02 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id k135so3825397ite.2 for ; Wed, 07 Mar 2018 07:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=L2JD/sTHGA+z+n3LmuJWmf2ebso0mJ4cMxptbrXPheQ=; b=S1c6ewI1vAF6CDyFzp1p/ri5t3pG93sZe9kMg9u8ZbEO5VnIbBwIr6CRu49LYqYM2f WS/QnyOsoiND6qB+N+nBeQYyWGtgMpi4vLuOEXic4ZBn9zW7FEIQ7lUGx5dy4MKZfHDp X5hDVi5jRFNtGQCbu/aJRziA0Nc02hbTnLqjw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=L2JD/sTHGA+z+n3LmuJWmf2ebso0mJ4cMxptbrXPheQ=; b=SRYemkEf/61rDSQU81wJUsHcnnos7sKobmaNfhWg/7EVgIS6/ECO+ruUdOEwG9W8hR RkNJrssP0pLQ2fGqxpVpMZslqXY76/zWMA+546jA+B+GsMM3UxovI5iqb/WrGdII6/zN Cc/2Rh27tvqb7e23Kax6wW+BnVZBaKjpG0tapFLN7I0SVAs9CUGh74VUiS2kPWe9wetN tpc7uIsnfBonNZ4BVM1fMo5zMbzoWCKLStqVUVIJ2oMRMuXeGlWgozPsX/hfPcApQZNp 32C6rafuIhSEQVY/RJRouZ1XbbeCPTfPUWWMva39ezamOTopr2ruvGtjOMz3P21VPhTA lSPg== X-Gm-Message-State: AElRT7G57ROtyhUoADXjn+lkxFW3IpUz4eVkDRioBJheOEdjb4nSN4X2 OGBbowKJ2cwbS2N4OMO3t2q7VNjGb3nf9oaz7t6UZQ== X-Google-Smtp-Source: AG47ELthVMxyK+GTM7+uEvLHHSIFBrhi8h2SvXPfv0DpcJR2uw+4BSAKr3RYJ6Xk+iC8YCrozPB824AsR2TJG69P9LA= X-Received: by 10.36.91.138 with SMTP id g132mr23508604itb.50.1520438116772; Wed, 07 Mar 2018 07:55:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Wed, 7 Mar 2018 07:55:16 -0800 (PST) In-Reply-To: <20180306141506.17316-1-sami.mujawar@arm.com> References: <20180306141506.17316-1-sami.mujawar@arm.com> From: Ard Biesheuvel Date: Wed, 7 Mar 2018 15:55:16 +0000 Message-ID: To: Sami Mujawar Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , Leif Lindholm , "Kinney, Michael D" , Evan Lloyd , Matteo Carlini , Stephanie.Hughes-Fitt@arm.com, nd Subject: Re: [PATCH v1] Platform/ARM/VExpressPkg: Fix RSDT pointer in RSDP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 15:49:03 -0000 Content-Type: text/plain; charset="UTF-8" On 6 March 2018 at 14:15, Sami Mujawar wrote: > According to the SBBR Specification (ARM DEN 0044B), Section 4.2.1.1 > "Within the RSDP, the RsdtAddress field must be null (zero) > and the XsdtAddresss MUST be a valid, non-null, 64-bit value." > > The PcdAcpiExposedTableVersions is used to indicate the ACPI versions > that are supported. The default value for PcdAcpiExposedTableVersions > is 0x3E which indicates that the ACPI versions 1.0B and above are > supported. > > For ACPI 1.0B the RSDT pointer is set in the RSDP table. However for > ACPI versions greater than ACPI 1.0B the AcpiTableDxe populates > the RSDP with the RSDT address set to NULL. > > Therefore set the PcdAcpiExposedTableVersions to 0x20 indicating > support for ACPI 5.0 and above. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Signed-off-by: Evan Lloyd I am changing the subject into Platform/ARM/VExpressPkg: Provide only 64-bit ACPI entrypoint but the patch looks fine to me. Reviewed-by: Ard Biesheuvel Pushed as 9422cb8c75b3 Thanks > --- > > The changes can be seen at > https://github.com/samimujawar/edk2-platforms/tree/212_fvp_rsdt_fix_v1 > > Notes: > v1: > - Setup PcdAcpiExposedTableVersions correctly so that the > AcpiTableDxe populates the RSDP with the RSDT address set > to NULL. [SAMI] > > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index 295e9a126b0ebaa4653d7e25e2f7d8c396403764..cdf9e2d49784d542701dc84eb511f592e77ec106 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2011-2017, ARM Limited. All rights reserved. > +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -162,6 +162,11 @@ [PcdsFixedAtBuild.common] > # the entire FVP address space can be covered by 36 bit VAs > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|36 > > + # > + # ACPI Table Version > + # > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >