public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Alexei Fedorov <Alexei.Fedorov@arm.com>
Cc: "ard.biesheuvel@linaro.org@arm.com"
	<"ard.biesheuvel@linaro.org"@arm.com>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Evan Lloyd <Evan.Lloyd@arm.com>,
	Mitch Ishihara <Mitch.Ishihara@arm.com>,
	Matteo Carlini <Matteo.Carlini@arm.com>,
	 Sami Mujawar <Sami.Mujawar@arm.com>,
	Girish Pathak <Girish.Pathak@arm.com>,
	 "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	Jeremy Linton <Jeremy.Linton@arm.com>,
	 "ryan.harkin@linaro.org" <ryan.harkin@linaro.org>
Subject: Re: Mapping frame buffer memory as uncached
Date: Wed, 20 Dec 2017 15:22:08 +0000	[thread overview]
Message-ID: <CAKv+Gu_ndJQwwH8MQzTg68xGV8OoTcAsD10NT3jvnwyDu0tqZw@mail.gmail.com> (raw)
In-Reply-To: <DB5PR08MB101444B8D12B3330A1EC010D9A0C0@DB5PR08MB1014.eurprd08.prod.outlook.com>

On 20 December 2017 at 15:17, Alexei Fedorov <Alexei.Fedorov@arm.com> wrote:
> Hi Ard,
>
>
> The side effect of the following commit on 6 April:
>
>
> ArmPlatformPkg/FVP: map motherboard VRAM as uncached memory
>
> The VRAM of the PL111 on the FVP Base/Foundation models is described as
> device memory rather than uncached memory, which is not an accurate
> description of the nature of the region (i.e., a framebuffer), and may
> result in problems when using accelerated string routines to access the
> region, since this may legally involve unaligned accesses or DC ZVA
> instructions, which are not allowed on device mappings.
>
> So split of the 8 MB VRAM region into a separate region, and map it using
> memory attributes.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> is that now frame buffer memory region has Executable attribute set, which
> can be checked in DS-5 debugger Memory Map tab.
>
> Was this expected?
>

Not for one second. Thanks for the report, I will propose a fix.


      reply	other threads:[~2017-12-20 15:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 15:17 Mapping frame buffer memory as uncached Alexei Fedorov
2017-12-20 15:22 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_ndJQwwH8MQzTg68xGV8OoTcAsD10NT3jvnwyDu0tqZw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox