From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::235; helo=mail-io0-x235.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 868162219BC98 for ; Wed, 20 Dec 2017 07:17:22 -0800 (PST) Received: by mail-io0-x235.google.com with SMTP id o2so17675424ioe.8 for ; Wed, 20 Dec 2017 07:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9GGS/Z6zSY08vQjzWchzZZI58DU8Q3V0k3IuB0SUzaw=; b=J5ma/cYRbphIUeU7DAwd5zliMDIYcnLsVRegDQ8ETlLoU7zPO/RN/E8osETXZHSTQx qCUT40MK11HQxcn2G2WtfFIMxSGl5kAVgjcmMyI2MkJWpRb+Qj+zIqULvFIq4/SDRdA9 jCTczvGQA7MLEa6SA76dUs79C/7BkQOB4MZtI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9GGS/Z6zSY08vQjzWchzZZI58DU8Q3V0k3IuB0SUzaw=; b=VDhfryBT60P0+/iNPdAqY1eNV1mwIfFiYaLVVLaJrY0lb9q2NqfwAN+lQ3f94SyZdL j+ROLN23OUY39WHCHzeKNqjJWNNKFRaoLZ9S+vQC2JpHaNgzLvcPnnwxWjvPTJtFx4Md C3cYLFs/xj+JIbE9csG+5zYQU7cqsUrXCb4IXosr6otxzRO1btqH+syoxy/4aDTk5qn5 dvlA7KyebTx6uoSQ7juqsTBeDBLAfk681TMr4Md/1SkHJh4KdW8O8zK+iEYPPYzhbTt/ hbsztrNhy5cLVsltzm0CLetjbeJuRJwLZS7XjVq4wSzsJ0e4lEHZMwj4U6V44W+IrsQq zvBQ== X-Gm-Message-State: AKGB3mIRyprqLYkir2cBr19g2yGOmSVy/9+/2guBuDHoHAzGcgFONcKz 2WtgQtezeCzEfNXRyglnYiQvW8n67y9pGYRi0WdZLg== X-Google-Smtp-Source: ACJfBovWw1qf0DuuSXs+3prSesZu24OIG9hCS/IZt7Lfb9QM81ePlEgwPzxywS+UbBgG1O2Wzg8J0udd+EVbvNRWiP0= X-Received: by 10.107.27.84 with SMTP id b81mr8662989iob.43.1513783329256; Wed, 20 Dec 2017 07:22:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Wed, 20 Dec 2017 07:22:08 -0800 (PST) In-Reply-To: References: From: Ard Biesheuvel Date: Wed, 20 Dec 2017 15:22:08 +0000 Message-ID: To: Alexei Fedorov Cc: "ard.biesheuvel@linaro.org@arm.com" <"ard.biesheuvel@linaro.org"@arm.com>, "edk2-devel@lists.01.org" , Evan Lloyd , Mitch Ishihara , Matteo Carlini , Sami Mujawar , Girish Pathak , "leif.lindholm@linaro.org" , Jeremy Linton , "ryan.harkin@linaro.org" Subject: Re: Mapping frame buffer memory as uncached X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 15:17:23 -0000 Content-Type: text/plain; charset="UTF-8" On 20 December 2017 at 15:17, Alexei Fedorov wrote: > Hi Ard, > > > The side effect of the following commit on 6 April: > > > ArmPlatformPkg/FVP: map motherboard VRAM as uncached memory > > The VRAM of the PL111 on the FVP Base/Foundation models is described as > device memory rather than uncached memory, which is not an accurate > description of the nature of the region (i.e., a framebuffer), and may > result in problems when using accelerated string routines to access the > region, since this may legally involve unaligned accesses or DC ZVA > instructions, which are not allowed on device mappings. > > So split of the 8 MB VRAM region into a separate region, and map it using > memory attributes. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > Reviewed-by: Jeremy Linton > Tested-by: Ryan Harkin > Reviewed-by: Leif Lindholm > > is that now frame buffer memory region has Executable attribute set, which > can be checked in DS-5 debugger Memory Map tab. > > Was this expected? > Not for one second. Thanks for the report, I will propose a fix.