From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A61AA21DFA8F1 for ; Wed, 5 Apr 2017 03:01:06 -0700 (PDT) Received: by mail-it0-x234.google.com with SMTP id y18so5578256itc.1 for ; Wed, 05 Apr 2017 03:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VVNY+hFqHV/JgMQk3daPcE1BPKl88hJhuXPe7kyw3Bs=; b=fGhxemSO9dYYCfnaY5aA+PtezYwavDa8haySIrlY9rP15uBFjkEcTvY1FvAob7dmNP xa0iJBARQzwqZk/lOqUHMV10Xg0o47NHIcvOfDt9GMcmoa9Ydo5dSAVTPcair5B1JNYx h79dHmEuDFK4rIzbeWuf+suSPi8Sii6+F0lwU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VVNY+hFqHV/JgMQk3daPcE1BPKl88hJhuXPe7kyw3Bs=; b=Fvd0bwK7LqxLBXaGuRL2qM3D03wmGd8x7qu/4xRfGyUGNwgTYYjSVCFJrRXHN5X7Ub Yd8gYHldxAwzCpfdmGVMnlzK6ZHvjou2TICx3F66kA+2NzlWF+es9VXSQufdEzUS4iZp cI4w9bqfbaYjZvazhJCEsHbK6wexMCg57yZAXFiMLtEZbZotyCtkZhgPpYzbXOLX+iya APvjmnOFm2469aqaP4jOQBdgO1mWV3T+HIsfj60H/e6EuWL//WJRs8AyNTel4KJ2fUaV SUKU5Zlg0aQ+iKSZB46oJ9VGXwGUSmztbZUdaUHuAjP4a14cUDw+8ErMG47gZJKXs/Hv 498A== X-Gm-Message-State: AFeK/H2oDYrfIWu9Kd9QbQC9uwvtG1ppXWDu9M2V7HGJNkFeha824IeY zel+/nELjLi5TQc2k0GvsNZMImCV5wB0 X-Received: by 10.36.217.83 with SMTP id p80mr10576814itg.59.1491386465738; Wed, 05 Apr 2017 03:01:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 5 Apr 2017 03:01:05 -0700 (PDT) In-Reply-To: References: <20170405093806.6779-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Wed, 5 Apr 2017 11:01:05 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm , "Zeng, Star" Subject: Re: [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 10:01:06 -0000 Content-Type: text/plain; charset=UTF-8 On 5 April 2017 at 10:49, Laszlo Ersek wrote: > On 04/05/17 11:38, Ard Biesheuvel wrote: >> Given the agreement on the edk2-devel regarding the fact that the >> notion whether or not a 'platform has ACPI' is a universal one, move >> the PlatformHasAcpi GUID to MdeModulePkg. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> Reviewed-by: "Zeng, Star" >> --- >> ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 1 + >> ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf | 1 + >> EmbeddedPkg/EmbeddedPkg.dec | 3 --- >> EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf | 1 + >> {EmbeddedPkg => MdeModulePkg}/Include/Guid/PlatformHasAcpi.h | 0 >> MdeModulePkg/MdeModulePkg.dec | 3 +++ >> 6 files changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf >> index 08025f0c3722..5351e741aa41 100644 >> --- a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf >> +++ b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf >> @@ -27,6 +27,7 @@ [Sources] >> [Packages] >> ArmVirtPkg/ArmVirtPkg.dec >> EmbeddedPkg/EmbeddedPkg.dec >> + MdeModulePkg/MdeModulePkg.dec >> MdePkg/MdePkg.dec >> OvmfPkg/OvmfPkg.dec >> >> diff --git a/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf b/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf >> index 2833075f65c9..26965c50c12b 100644 >> --- a/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf >> +++ b/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf >> @@ -26,6 +26,7 @@ [Sources] >> >> [Packages] >> EmbeddedPkg/EmbeddedPkg.dec >> + MdeModulePkg/MdeModulePkg.dec >> MdePkg/MdePkg.dec >> >> [LibraryClasses] >> diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec >> index 0bed2736c8c3..a7e127085236 100644 >> --- a/EmbeddedPkg/EmbeddedPkg.dec >> +++ b/EmbeddedPkg/EmbeddedPkg.dec >> @@ -57,9 +57,6 @@ [Guids.common] >> gFdtHobGuid = { 0x16958446, 0x19B7, 0x480B, { 0xB0, 0x47, 0x74, 0x85, 0xAD, 0x3F, 0x71, 0x6D } } >> gFdtVariableGuid = { 0x25a4fd4a, 0x9703, 0x4ba9, { 0xa1, 0x90, 0xb7, 0xc8, 0x4e, 0xfb, 0x3e, 0x57 } } >> >> - ## Include/Guid/PlatformHasAcpi.h >> - gEdkiiPlatformHasAcpiGuid = { 0xf0966b41, 0xc23f, 0x41b9, { 0x96, 0x04, 0x0f, 0xf7, 0xe1, 0x11, 0x96, 0x5a } } >> - >> ## Include/Guid/PlatformHasDeviceTree.h >> gEdkiiPlatformHasDeviceTreeGuid = { 0x7ebb920d, 0x1aaf, 0x46d9, { 0xb2, 0xaf, 0x54, 0x1e, 0x1d, 0xce, 0x14, 0x8b } } >> >> diff --git a/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf b/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf >> index 6268293ca97b..be298ba67c40 100644 >> --- a/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf >> +++ b/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf >> @@ -34,6 +34,7 @@ [Sources] >> >> [Packages] >> EmbeddedPkg/EmbeddedPkg.dec > > I think you can remove "EmbeddedPkg/EmbeddedPkg.dec" here. > Ah yes. It didn't occur to me to remove the 'home' package here, but I suppose this library doesn't depend on anything it provides. > ( > > I checked all the other INF files being modified as well; it seems that > "EmbeddedPkg/EmbeddedPkg.dec" remains necessary in all other places. > > I also grepped all INF files for the GUID -- DtPlatformDxe.inf is > another user, but it needs no modification. > > ) > > With that update (if it indeed works), > > Reviewed-by: Laszlo Ersek > Thanks,