From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web11.2810.1585248016105000609 for ; Thu, 26 Mar 2020 11:40:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=LienzBaI; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id j17so9112852wru.13 for ; Thu, 26 Mar 2020 11:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XcY/RCNszUt3/cyf80HahWjin2M+VfhGVvv7lGdj2rA=; b=LienzBaIIzlTBd+505Wo8rUDSqLo/6qBDUibLTCLpS7gp5a2Vk0AzIwbCg8fXZ0W8t LFegKbyzwAFtfRGu4EIjQhmw+LPONPMM6Z32hz6R3TLpxFEht6QFCJzWmddHIItpr/CA 9HliTQFtwEuKi9ZqPHq0dE2LCG/A+dHo4B6bI/aZ2CDKjr/6ekkeNlPEnMmXiFQdpqYR Ziu/pqo2MHZrjaR31A9sPuS5rv/lmSC3ie21TzpHbTfA1k+ROf32GHGsUascp0hyLOAc 69hytL17SnIjKy1nNx6S9XSdBscLT91GKsYaKtlx63UGFuPve25l8dbY2z5DAivIjaGX pLuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XcY/RCNszUt3/cyf80HahWjin2M+VfhGVvv7lGdj2rA=; b=B27Wf2q1X5iIPXCc39lpc5IpX8yoXsuRKETKjTIAUFRg/T8U7XmHRXpWXqsdI2ySPr 3+PsPmKE99WImSilkYrj0Y+cveh4xST5vc2fKothu14O4TtMNDf0Iui4HfJIQ4WcaS8d WXzTnv0o8beeCp7UTrOw0AOQj69yeiDBKxG+nDaP8zP/9RUoaK4X5zCvBoO72u5whdqd L3V+0VlPa7l/LlKuJ5fSUvY3MFxFg16rNN3SMzEV9SqO9t7rLWCWm16xcmB+KZgEEguO fRVPFeNhjC420q4JtolZlEJ0fikVo5IpoiNj/p616f/MBAHrGsjsvdj6tBVdbXuPxtj1 PVpQ== X-Gm-Message-State: ANhLgQ0FKC39rsXimkBqoZuxIbC+2HSMLGbGTJcv4GidTi9SPiaX5L2q q5ouHHQ+vy1pXVnnd0rxClHQGA6OR8Jsq9vLnfwSrA== X-Google-Smtp-Source: ADFU+vtGpOiZb/Clm07inTwZ+srF7XQJpwWvoNW2+OW9mG/6U7LArDjUUvEVyPRUig7JS+RrbdehiBWmqYtEdLXQbRQ= X-Received: by 2002:adf:afdb:: with SMTP id y27mr10915060wrd.208.1585248014633; Thu, 26 Mar 2020 11:40:14 -0700 (PDT) MIME-Version: 1.0 References: <20200318102419.20007-1-gaurav.jain@nxp.com> In-Reply-To: <20200318102419.20007-1-gaurav.jain@nxp.com> From: "Ard Biesheuvel" Date: Thu, 26 Mar 2020 19:40:03 +0100 Message-ID: Subject: Re: [PATCH v3 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test. To: Gaurav Jain Cc: edk2-devel-groups-io , Leif Lindholm , Pankaj Bansal Content-Type: text/plain; charset="UTF-8" On Tue, 17 Mar 2020 at 11:25, Gaurav Jain wrote: > > ASSERT in SetTime_Conf Consistency Test. > SCT Test expect return as Invalid Parameter. > So removed ASSERT(). > > Signed-off-by: Gaurav Jain Thanks Gaurav Reviewed-by: Ard Biesheuvel I will add a note to the commit log describing the other change you are making in this patch. In the future, please describe the patch fully - please don't waste people's time by making them guess at the rationale of your patch. Pushed as 32bcdfa512bda825d968c69cdeb7d5da89ced62e > --- > > Notes: > v3 > Removed Time Validity Checks in function SetWakeupTime. > > v2 > reverted changes related to valid range of years. > > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c > index 08fb9b0100b6..20f1fa640ecc 100644 > --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c > +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c > @@ -85,10 +85,6 @@ IsDayValid ( > IN EFI_TIME *Time > ) > { > - ASSERT (Time->Day >= 1); > - ASSERT (Time->Day <= mDayOfMonth[Time->Month - 1]); > - ASSERT (Time->Month != 2 || IsLeapYear (Time) || Time->Day <= 28); > - > if (Time->Day < 1 || > Time->Day > mDayOfMonth[Time->Month - 1] || > (Time->Month == 2 && !IsLeapYear (Time) && Time->Day > 28)) { > @@ -113,6 +109,7 @@ IsTimeValid( > Time->Hour > 23 || > Time->Minute > 59 || > Time->Second > 59 || > + Time->Nanosecond > 999999999 || > !IsValidTimeZone (Time->TimeZone) || > !IsValidDaylight (Time->Daylight)) { > return FALSE; > -- > 2.17.1 >