From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1AAFE21962301 for ; Thu, 17 Jan 2019 03:10:12 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id k7so7479021iob.6 for ; Thu, 17 Jan 2019 03:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NxquspxHEBN9Z/c1m4yDQh/K88jXfCvId8YpDNUJbf8=; b=kksDZ/IV2yjRlYjKg1KXaeX9cDGQyXfddCvBodjrqkybuUVblqAP9j1FCxVYKXjY7h 0SxrJTD2tASG2K9GP9ZJidNC6CTNyMjUBMPet3chZi9K2Ntu6M1kSb1/4BYJsFzWjegd g3+6yLh3iU919J5Ve4i5IfWylIvP8ynwNPS9g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NxquspxHEBN9Z/c1m4yDQh/K88jXfCvId8YpDNUJbf8=; b=uiMypHgI9P01yQOvJrh2qVftJVU5prCPAvYI0tzBnG9P8QKDJg1iHmWBCUGvaYgOFP /yjZ2fUQRkNMZeI9+IZC7vt78k/l4xrMyUJprbZ1z7qZBMWGSoW/jo+CJTN94e9dBvg/ hwoDJ2vtPy6ljiiPKhXNBERAEND38FWKUSZUKik/2yQr1yLzTDl7xQn1z+iCfqUy7LRR H6YSJAQAcnUl5uOZXj8uDuKPb1s6gxVWpWSt44Km0v7l11NS0wbog2O/jzbauIyRXBZF KwxsctXh+8NNlAgf/M6J4iJSO/2G9IWBhH+4EMl0og/X6QrqhqitxWc0hjbNG1xJX9ox DbHw== X-Gm-Message-State: AJcUukezf9Tpez42fasZ8J4SPnnBZpRETlq1wig3I/6pg7mhG9X8ern9 e9uuacDOU8eCvTtBr1JoSCqmxVD2XURXN0nggJYpUw== X-Google-Smtp-Source: ALg8bN6jir0QJD47TmwqMUsE2ZS3jFvw3BldlFyDXrHDMWZJoXzcYndhGEsvXg4FUc10C18f70owSGrbBvYR3cq8jfQ= X-Received: by 2002:a5e:c206:: with SMTP id v6mr7760802iop.60.1547723412248; Thu, 17 Jan 2019 03:10:12 -0800 (PST) MIME-Version: 1.0 References: <20190104144336.8941-1-ard.biesheuvel@linaro.org> <20190104144336.8941-7-ard.biesheuvel@linaro.org> <20190117110456.z22z2udhnbza3liy@bivouac.eciton.net> In-Reply-To: <20190117110456.z22z2udhnbza3liy@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 17 Jan 2019 12:10:01 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Masahisa Kojima Subject: Re: [PATCH edk2-platforms 6/7] Platform/DeveloperBox: add .DSC/.FDF description of MM components X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 11:10:13 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 17 Jan 2019 at 12:04, Leif Lindholm wrote: > > On Fri, Jan 04, 2019 at 03:43:35PM +0100, Ard Biesheuvel wrote: > > Create a pair of .DSC/.FDF files that describe the components and > > the firmware volumes and flash device that will be dispatched into > > a secure partition in the secure world to control the UEFI secure > > variable store. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 5 +- > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 7 +- > > Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc | 103 +++++++++++++ > > Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 161 ++++++++++++++++++++ > > 4 files changed, 270 insertions(+), 6 deletions(-) > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > index 56787a744157..666bd2716336 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > @@ -250,10 +250,7 @@ [Components.common] > > # > > # Variable services > > # > > - Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf { > > - > > - NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf > > - } > > + Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf > > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > index 56adc21d5caf..87b2094cb356 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > @@ -125,6 +125,7 @@ [LibraryClasses.common] > > PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > > > NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > + NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf > > > > ################################################################################ > > # > > @@ -294,8 +295,10 @@ [PcdsFixedAtBuild.common] > > !endif > > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision|$(BUILD_NUMBER) > > > > - gArmTokenSpaceGuid.PcdMmBufferBase|0xFFC00000 > > - gArmTokenSpaceGuid.PcdMmBufferSize|0x00200000 > > + gEfiSecurityPkgTokenSpaceGuid.PcdUserPhysicalPresence|TRUE > > So, I can see why you add this hard-wired for the purpose of testing. > But please, add a *very* conspicuous, and strongly worded, comment > statement preceding it. > Well, I was talking to Peter about this the other day: according to the spec, this setting should only matter before exit boot services, and since this platform only supports serial and GOP consoles, one could argue that only a physically present user could interact with it before that time. The obvious way of implementing this non-trivially on this platform is to use a DIP switch, but that requires you to open the case to enroll/delete the platform key. Perhaps that does not matter, and it would in fact produce a less dangerous reference implementation.