Re: [Patch V2] BaseTool: Fixed incremental rebuild issue.

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Sat, 23 Feb 2019 at 11:14, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Hi Laszlo,
>
> pt., 22 lut 2019 o 21:08 Laszlo Ersek <lersek@redhat.com> napisał(a):
> >
> > On 02/22/19 20:21, Ard Biesheuvel wrote:
> > > On Fri, 22 Feb 2019 at 08:26, Gao, Liming <liming.gao@intel.com> wrote:
> > >>
> > >> Reviewed-by: Liming Gao <liming.gao@intel.com>
> > >>
> > >
> > > Incremental builds are still broken for me, even with this patch. Is
> > > anyone else seeing the same?
> >
> > I am not; but I've been using Python3.4 for a while now (it is needed by
> > another package on my system, and then the build tools find it too).
> >
> > The regression is attributed to commit d943b0c339fe ("BaseTools: Handle
> > the bytes and str difference", 2019-02-01), which I believe is related
> > to the python2/3 conversion. So I assume python3.4 masks the problem.
> >
>
> In my setup with the latest BaseTools update this problem is gone. I'm
> using Python 3.5.2.
>

Thanks for confirming.

I did a full clean of my workspace, and now things are working for me
again as well.

Thanks,