From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6CAA22063D751 for ; Mon, 21 May 2018 02:09:30 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id q4-v6so20312436ite.3 for ; Mon, 21 May 2018 02:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5LRFQCOChkQo9RXEfEzGIwqlFqFV/LXRA8p/kOIl+Uo=; b=BNm4vLoODrvQGXW1ZYLWcYaxwAjFgJ+6NRXahoOddtVjToB9bqsgk/Lyvacyl21xPs KAvVKacsTR0hWvbNyxcf8zbaUzsnGLmd4Z4Fjt4ehW6GvB2ZaDWf+he3GiPD67lPNleb WcbRgcyZYqFz+QBjeH4g3bS6wtuckZwTVH0iY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5LRFQCOChkQo9RXEfEzGIwqlFqFV/LXRA8p/kOIl+Uo=; b=DFW8IKjM/DwGK63CKR5/DnPx1aO1a0hNw4SLt0STCvStIojmCeI71U+/B8dT6IWT5L Ga1r7vQOh0pdzAkKzJ4QFKUvu9NO77CsfyBQ/0xHYX54mAiMbCFGBNbyhJXV9K52Fs9s DBzKomBJm8kkubEA4kmg3ey2QfXz6RIqUMP+WrFz2KAQ4waHik3g/mdQKtANRcpbnmPy QE0npr5Y4k4W3AYnSF0LB0hBrm3Dc6E+AVQLYf5v/RrGywQcm2x6sOtJse3A5fEbXOHy nVPRcCeMR67U9fwa2GOfFyp5LxQnqMBIu/lxIMIycG0OZt+1Cee+QDruJ4ZL46zFZk9z kkVw== X-Gm-Message-State: ALKqPweEobPMAMAoWKXQfeX0G+fUJWqJCHdHH8o2RkkIwcQt5trQc2gy TzjhpuHlgpkVtbrqBqU9yz5OwzYZ8F798BvpPE9vow== X-Google-Smtp-Source: AB8JxZrHi0zU1GR+MNcdMfvTO2t+ZtdJbxIaZ84eGqZNYFJM296iuQBqFqLxMbTqubCMGBDOwkNMDElm8CzwvN9z2/k= X-Received: by 2002:a24:e103:: with SMTP id n3-v6mr16904697ith.68.1526893769658; Mon, 21 May 2018 02:09:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.134 with HTTP; Mon, 21 May 2018 02:09:29 -0700 (PDT) In-Reply-To: <1526891152-18739-8-git-send-email-thomas.abraham@arm.com> References: <1526891152-18739-1-git-send-email-thomas.abraham@arm.com> <1526891152-18739-8-git-send-email-thomas.abraham@arm.com> From: Ard Biesheuvel Date: Mon, 21 May 2018 11:09:29 +0200 Message-ID: To: Thomas Abraham Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Daniil Egranov Subject: Re: [PATCH edk2-platforms v4 7/9] Platform/ARM/Sgi: add support for smsc91x ethernet controller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 09:09:30 -0000 Content-Type: text/plain; charset="UTF-8" On 21 May 2018 at 10:25, Thomas Abraham wrote: > From: Daniil Egranov > > SGI platforms include a SMSC9118 ethernet controller. Enable support > for this controller. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Daniil Egranov > Signed-off-by: Thomas Abraham > --- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 4 ++++ > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 8 +++++++- > Platform/ARM/SgiPkg/SgiPlatform.dsc | 6 ++++++ > Platform/ARM/SgiPkg/SgiPlatform.fdf | 16 ++++++++++++++++ > 4 files changed, 33 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index 441a467..00ca7e9 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -27,6 +27,10 @@ > #define SGI_EXP_SMC_CS1_BASE 0x0C000000 > #define SGI_EXP_SMC_CS1_SZ SIZE_64MB > > +// Expansion AXI - SMSC 91C111 (Ethernet) > +#define SGI_EXP_SMSC91X_BASE 0x18000000 > +#define SGI_EXP_SMSC91X_SZ SIZE_64MB > + > // Expansion AXI - System peripherals > #define SGI_EXP_SYS_PERIPH_BASE 0x1C000000 > #define SGI_EXP_SYS_PERIPH_SZ SIZE_2MB > diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > index 9be71fb..f038559 100644 > --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > @@ -22,7 +22,7 @@ > #include > > // Total number of descriptors, including the final "end-of-table" descriptor. > -#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 8 > +#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 9 > > /** > Returns the Virtual Memory Map of the platform. > @@ -63,6 +63,12 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Length = SIZE_64MB; > VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > > + // Expansion AXI - SMSC 91X (Ethernet) > + VirtualMemoryTable[++Index].PhysicalBase = SGI_EXP_SMSC91X_BASE; > + VirtualMemoryTable[Index].VirtualBase = SGI_EXP_SMSC91X_BASE; > + VirtualMemoryTable[Index].Length = SGI_EXP_SMSC91X_SZ; > + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > + > // Expansion AXI - System Peripherals > VirtualMemoryTable[++Index].PhysicalBase = SGI_EXP_SYS_PERIPH_BASE; > VirtualMemoryTable[Index].VirtualBase = SGI_EXP_SYS_PERIPH_BASE; > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc > index c5f220e..f11c1f3 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc > @@ -150,6 +150,9 @@ > gArmPlatformTokenSpaceGuid.PcdCoreCount|4 > gArmPlatformTokenSpaceGuid.PcdClusterCount|2 > > + # Ethernet > + gEmbeddedTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x18000000 > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -249,3 +252,6 @@ > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > } > + > + # SMSC LAN 91C111 > + EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf > index d4fae50..6f6e6aa 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf > @@ -155,6 +155,22 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > + # > + # Networking stack > + # > + INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > + INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > + INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > + INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > + INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > + INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > + INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > + INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > + INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > + INF MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > + INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > + INF EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > + Don't you need to add these to the .DSC as well? > [FV.FVMAIN_COMPACT] > FvAlignment = 16 > BlockSize = 0x1000 > -- > 2.7.4 >