From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Shi, Steven" <steven.shi@intel.com>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"mischief@offblast.org" <mischief@offblast.org>
Subject: Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references
Date: Thu, 4 Aug 2016 10:54:55 +0200 [thread overview]
Message-ID: <CAKv+Gu_pvmE1Bs_=eENdqN18sVZQ1v4Qmt4wr2HvVFt0LXdwqw@mail.gmail.com> (raw)
In-Reply-To: <06C8AB66E78EE34A949939824ABE2B31033853AB@shsmsx102.ccr.corp.intel.com>
On 4 August 2016 at 10:54, Shi, Steven <steven.shi@intel.com> wrote:
> Hi Ard,
> I don't see you add below code for case R_X86_64_PLT32. Is it right?
>
> *(UINT32 *)Targ = (UINT32) (*(UINT32 *)Targ
> + (mCoffSectionsOffset[Sym->st_shndx] - SymShdr->sh_addr)
> - (SecOffset - SecShdr->sh_addr));
>
Isn't it identical to the code for R_X86_64_PC32?
next prev parent reply other threads:[~2016-08-04 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 8:45 [PATCH] BaseTools X64: fold PLT relocations into simple relative references Ard Biesheuvel
2016-08-04 8:54 ` Shi, Steven
2016-08-04 8:54 ` Ard Biesheuvel [this message]
2016-08-04 8:58 ` Shi, Steven
2016-08-04 9:01 ` Ard Biesheuvel
2016-08-04 19:03 ` Nicolas Owens
2016-08-04 19:11 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_pvmE1Bs_=eENdqN18sVZQ1v4Qmt4wr2HvVFt0LXdwqw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox