From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com
 [IPv6:2607:f8b0:4001:c06::22b])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 3D21B1A1DF2
 for <edk2-devel@lists.01.org>; Thu,  4 Aug 2016 01:54:56 -0700 (PDT)
Received: by mail-io0-x22b.google.com with SMTP id 38so266000047iol.0
 for <edk2-devel@lists.01.org>; Thu, 04 Aug 2016 01:54:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=pVNmD2A9X/j8/SUAx+H9hvNQvg6/9Vu4fFy56HVWP5k=;
 b=Baw6Jy1FqvR5Z3zk/ZBryW6qwWSh5pIw3RA5H6kgHt2G5O6MIOEMu40JBi9+0rooGM
 bhT64wHR6243j/PcJuLyn0EavE5itFw9QgKmMh+eP53jfW0jeCvOBw4LBChIi8Yl0nrq
 mAMrmedUvWEYH4lP/wlyjIVFWslx3O43BBi8c=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=pVNmD2A9X/j8/SUAx+H9hvNQvg6/9Vu4fFy56HVWP5k=;
 b=NBaMiSYQYoPn+Z4v7GJsTOIh6JR/lDtSA+4sw4qOt9y5izUQfMfBm93Kir6Jkou4nF
 EmQI+aQ75tKPQJL1v8xbFzs8CMFg81fK+NjwI4dlSs9UIaFYHltjH4yCTANwkeboYVfR
 rd2BeEhq3qhzYX6WUpNiWcgYi0/4ESqIJ41Hwo+gvOWNMyxKuxcvhYHlg3V3QzevrTYD
 oPqrc49HdmM6uRp94E+oCmbpTwLbKuOgtgeBb+P1isPJGhXyeP7NBWWyJkFLXcHXZc1b
 1GBu0j+Ovliqipr7wMnEtBO0NElqqkUa0U3HcRLHong/ZsKInJx2t615bnCIAatvBeWx
 xJRQ==
X-Gm-Message-State: AEkoousS4m+AkEGTHsuhLfo9hoatFsfAp1xrDbrqF9Bu3gap985iiIhfNsmVKwXCaP/h9CCk1Ke6qtsxbhciH+wQ
X-Received: by 10.107.41.67 with SMTP id p64mr68942388iop.130.1470300895680;
 Thu, 04 Aug 2016 01:54:55 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.36.204.195 with HTTP; Thu, 4 Aug 2016 01:54:55 -0700 (PDT)
In-Reply-To: <06C8AB66E78EE34A949939824ABE2B31033853AB@shsmsx102.ccr.corp.intel.com>
References: <1470300343-17287-1-git-send-email-ard.biesheuvel@linaro.org>
 <06C8AB66E78EE34A949939824ABE2B31033853AB@shsmsx102.ccr.corp.intel.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Thu, 4 Aug 2016 10:54:55 +0200
Message-ID: <CAKv+Gu_pvmE1Bs_=eENdqN18sVZQ1v4Qmt4wr2HvVFt0LXdwqw@mail.gmail.com>
To: "Shi, Steven" <steven.shi@intel.com>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>, "Gao,
 Liming" <liming.gao@intel.com>, 
 "Justen, Jordan L" <jordan.l.justen@intel.com>, 
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 "mischief@offblast.org" <mischief@offblast.org>
Subject: Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Aug 2016 08:54:56 -0000
Content-Type: text/plain; charset=UTF-8

On 4 August 2016 at 10:54, Shi, Steven <steven.shi@intel.com> wrote:
> Hi Ard,
> I don't see you add below code for case R_X86_64_PLT32. Is it right?
>
>             *(UINT32 *)Targ = (UINT32) (*(UINT32 *)Targ
>               + (mCoffSectionsOffset[Sym->st_shndx] - SymShdr->sh_addr)
>               - (SecOffset - SecShdr->sh_addr));
>

Isn't it identical to the code for R_X86_64_PC32?