From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::233; helo=mail-io0-x233.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9FAA821F3C198 for ; Tue, 10 Oct 2017 13:35:36 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id f20so153698ioj.9 for ; Tue, 10 Oct 2017 13:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Bq5Mtzn8BaQ2JQCxpuNL8SomUT79iI5at/kbAIonXcE=; b=ihYPEX22/a3mMwBDR0wxpNMxgzhcV3rSMf3q5YgtwYfpr5jbX0BIznHkiU7cbxV2qa hdGpPGKdH/Cv45W+F0DQsON3rAkS6TwfHUYMQ4G9WsTXpVP7r1CDSNwFOYiNex0cNmrf BBv0zg3w6BUcYUDSSa2J33srOlC95hk/2kU8A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Bq5Mtzn8BaQ2JQCxpuNL8SomUT79iI5at/kbAIonXcE=; b=i8ncCqhxKBBRo2Ky6Ttxh6pY5tfCOVtKurFLluJgNaJhkH/mJoinhL/DN9pNb/QRml hSdscc9N8CZxc6HawIngzlKG6l9dKrLg8YfKMygBMm2OdQUAOgRjPRRoPLtqhet80H2K bRVjHOIf2ne7BubmqD97yes1IK/drhUgxoUTynIOyI6EoVR6wRSYe9rDNhkB5ddTR1Hz RyDRPJ2yeM/LQm/M/HlimMcvEOYMJxDkQHc6BtU49N27EMY3JwdjNytZaguGA7QDVHte lCi9m6H85GD53KoZ7TLyVcDlQ3rIJeflQnLspjyyU8BYRYsWdKbds98z1ozC32P2ijDO KMdg== X-Gm-Message-State: AMCzsaXlpaY1MTt78vDHqaWeHU5QmKraBsy+x80tA0tFj+A8rLhQV2Dt j8DVmXJny+scmsvvwjH4zf+NW6JDh6E+KNWTykUjSA== X-Google-Smtp-Source: AOwi7QCb0DXieY6xYLpET9t7R5SJLG/jnn4FZxkUvphZqOpnhuJ4Nb7RpzsxW5Jf2fgS+raOZ1WRLtAvrHe4w7pbZgM= X-Received: by 10.107.11.27 with SMTP id v27mr11662345ioi.179.1507667944421; Tue, 10 Oct 2017 13:39:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Tue, 10 Oct 2017 13:39:03 -0700 (PDT) In-Reply-To: <20171010152956.7guboigtuofxygsz@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-5-git-send-email-mw@semihalf.com> <20171010144359.z57jipw6hdlkyjxj@bivouac.eciton.net> <20171010152956.7guboigtuofxygsz@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 10 Oct 2017 21:39:03 +0100 Message-ID: To: Leif Lindholm Cc: Marcin Wojtas , edk2-devel-01 , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 04/13] Marvell/Armada: Armada70x0Lib: Clean FV in the D-cache before boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 20:35:36 -0000 Content-Type: text/plain; charset="UTF-8" On 10 October 2017 at 16:29, Leif Lindholm wrote: > On Tue, Oct 10, 2017 at 04:50:04PM +0200, Marcin Wojtas wrote: >> 2017-10-10 16:43 GMT+02:00 Leif Lindholm : >> > On Mon, Oct 09, 2017 at 07:00:53PM +0200, Marcin Wojtas wrote: >> >> From: Ard Biesheuvel >> >> >> >> To prevent cache coherency issues when chainloading via U-Boot, clean >> >> and invalidate the FV image in the caches before re-enabling the MMU. >> > >> > Is this only relevant for chainloading (which is not the expected >> > normal usage) or is it also important for warm-reset - for example for >> > capsule update (at least from within OS)? >> >> Initially it was done for chainloading purpose - I don't use it >> anymore, but just thought the patch itself is worth keeping. About >> capsule update - I haven't tried it, it's been not the top priority >> for me recently. >> >> > If the former, I would prefer for this to be conditionalised, and not >> > included by default. >> >> How can we detect, that uefi is being chain-loaded? > > Oh, I meant compile time. Hence "not included by default". > > It has been a useful debug feature, but I don't think anyone is > expecting to be routinely run either EDK2 on top of U-Boot or U-Boot > on top of EDK2 on this platform. > >> > If the latter, please update the commit message. >> >> I'm considering keeping this patch aside, until it may become >> necessary for capsule update, as I cannot guarantee now it's needed at >> all. What's your recommendation? > > I'll wait to see what Ard has to say. > So yes, it may make sense to move it out of the series for now. > We don't need this patch, I think. I don't remember the details, but the FV should simply be cleaned to the PoC before entering UEFI.