From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ming Huang <ming.huang@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
linaro-uefi <linaro-uefi@lists.linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Graeme Gregory <graeme.gregory@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
wanghuiqiang <wanghuiqiang@huawei.com>,
huangming <huangming23@huawei.com>,
Jason Zhang <zhangjinsong2@huawei.com>,
huangdaode@hisilicon.com, John Garry <john.garry@huawei.com>,
Xinliang Liu <xinliang.liu@linaro.org>,
zhangfeng56@huawei.com
Subject: Re: [PATCH edk2/ArmPkg v1 1/1] ArmPkg: Fix Gic interrupt routing modes bug
Date: Wed, 7 Nov 2018 15:48:31 +0100 [thread overview]
Message-ID: <CAKv+Gu_qKuMM0TS50VXkHwy8YsDUpY4HA-d9-5DeOJ7Uz830AA@mail.gmail.com> (raw)
In-Reply-To: <20181029045708.6292-2-ming.huang@linaro.org>
(+ Marc)
On 29 October 2018 at 05:57, Ming Huang <ming.huang@linaro.org> wrote:
> As GicV3 Spec, Interrupt Routing Modes should be 0 for
> routing the SPIs to the primary CPU.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> ---
> ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c b/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c
> index 01154848f443..1558db31713a 100644
> --- a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c
> +++ b/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c
> @@ -469,7 +469,7 @@ GicV3DxeInitialize (
> for (Index = 0; Index < (mGicNumInterrupts - 32); Index++) {
> MmioWrite32 (
> mGicDistributorBase + ARM_GICD_IROUTER + (Index * 8),
> - CpuTarget | ARM_GICD_IROUTER_IRM
> + CpuTarget
> );
> }
> }
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-11-07 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 4:57 [PATCH edk2/ArmPkg v1 0/1] Fix Gic interrupt routing modes bug Ming Huang
2018-10-29 4:57 ` [PATCH edk2/ArmPkg v1 1/1] ArmPkg: " Ming Huang
2018-11-07 14:48 ` Ard Biesheuvel [this message]
[not found] ` <9c5536f3-29c1-9cd5-3078-1596e2ce25ba@arm.com>
2018-11-07 15:23 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_qKuMM0TS50VXkHwy8YsDUpY4HA-d9-5DeOJ7Uz830AA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox