From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DBF3D1A1E06 for ; Mon, 26 Sep 2016 05:56:51 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id e66so91109825iod.1 for ; Mon, 26 Sep 2016 05:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=T5aAcUjXYwv/eUsb79VBea9oRZeChxZ3Rz0526U9cOs=; b=ZekA2jj0usIE7YAIGn/X7dO72jips6j49c7hG2wKcHY8wBe234PA4uo/WuTtFXPDCb a08yhuqAurmYN3IZNn3Cyj6rbvoe/airOaWe//wV4TjUt/dX7DDUXI6l4TJn/RHQ4lLw 6iD9A2NTt0218goFwEoMBINz6cbzWKRsl7Jg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=T5aAcUjXYwv/eUsb79VBea9oRZeChxZ3Rz0526U9cOs=; b=IFEcBEBrBPVNFb+yHDiLnNVLjQEpgKNkzCMy/YMmfFOeEcGGTPKBm6anYzPT/Yr/En ci7o7IWKSEcPn0+au0Cog6sxGIjzjcTs/cX6GToSVJ+eIBIl+O1klLqQkTltn4QeKwvK cqN8a2b4NA3hn/VBL9QF4EUkPVp4a8A/TLb7QptCmmzgdyKnFMvpeiYhCKi5oXZz8FMu FyBPbgq22ulBK+7mLuwdPYDIdcJSgY21eh2dIG9gHS+NLllhIal+ggh0Yax0/Ac6iqA4 Lv7BOu5kML+riGSnfHx5iP8sl9+seA9JDplTj/Y4N5xrd280/Pk7v7gvAxHBzowJdTd4 oO1Q== X-Gm-Message-State: AE9vXwMPsiPJ3FNtVXrlVBEKLNezXhAiEVCAD+F0Y21K9tFOQdg6EbWo1ip248ne5qHq9nGgtkq0W/yoG1WMUFjI X-Received: by 10.107.190.68 with SMTP id o65mr23595634iof.95.1474894611230; Mon, 26 Sep 2016 05:56:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Mon, 26 Sep 2016 05:56:50 -0700 (PDT) In-Reply-To: <5fc7f7a5-d000-c8c1-fb84-485bbea289fb@redhat.com> References: <20160926093035.350612-1-ruiyu.ni@intel.com> <20160926093035.350612-19-ruiyu.ni@intel.com> <5fc7f7a5-d000-c8c1-fb84-485bbea289fb@redhat.com> From: Ard Biesheuvel Date: Mon, 26 Sep 2016 05:56:50 -0700 Message-ID: To: Laszlo Ersek Cc: Ruiyu Ni , "edk2-devel@lists.01.org" Subject: Re: [PATCH v2 18/19] ArmVirtPkg: Use the new LogoDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 12:56:52 -0000 Content-Type: text/plain; charset=UTF-8 On 26 September 2016 at 03:06, Laszlo Ersek wrote: > On 09/26/16 11:30, Ruiyu Ni wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Signed-off-by: Ruiyu Ni >> --- >> ArmVirtPkg/ArmVirtQemu.dsc | 7 ++----- >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 4 +--- >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 ++----- >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +------- >> 4 files changed, 6 insertions(+), 20 deletions(-) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index a3beb46..d4d9c0f 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -62,7 +62,6 @@ [LibraryClasses.common] >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> - ImageDecoderLib|MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.inf >> PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf >> QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf >> @@ -331,10 +330,8 @@ [Components.common] >> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >> MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf >> - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { >> - >> - NULL|MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.inf >> - } >> + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >> + MdeModulePkg/Logo/LogoDxe.inf >> MdeModulePkg/Application/UiApp/UiApp.inf { >> >> NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf >> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> index 2571884..a2e82b3 100644 >> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> @@ -181,9 +181,7 @@ [FV.FvMain] >> # >> # TianoCore logo (splash screen) >> # >> - FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { >> - SECTION RAW = MdeModulePkg/Logo/Logo.bmp >> - } >> + INF MdeModulePkg/Logo/LogoDxe.inf >> >> # >> # Ramdisk support >> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> index e0dcf43..e483a27 100644 >> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> @@ -61,7 +61,6 @@ [LibraryClasses.common] >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> - ImageDecoderLib|MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.inf >> PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf >> QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf >> @@ -320,10 +319,8 @@ [Components.common] >> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >> MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf >> - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { >> - >> - NULL|MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.inf >> - } >> + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >> + MdeModulePkg/Logo/LogoDxe.inf >> MdeModulePkg/Application/UiApp/UiApp.inf { >> >> NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf >> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c >> index 5d7c2a4..aecad57 100644 >> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -657,13 +657,7 @@ PlatformBootManagerAfterConsole ( >> // >> // Show the splash screen. >> // >> - // BootLogoEnableLogo ( >> - // ImageFormatBmp, // ImageFormat >> - // PcdGetPtr (PcdLogoFile), // Logo >> - // EdkiiPlatformLogoDisplayAttributeCenter, // Attribute >> - // 0, // OffsetX >> - // 0 // OffsetY >> - // ); >> + BootLogoEnableLogo (); >> >> // >> // Connect the rest of the devices. >> > > Reviewed-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel