From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::236; helo=mail-it0-x236.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 311AC2214E329 for ; Mon, 11 Dec 2017 10:00:38 -0800 (PST) Received: by mail-it0-x236.google.com with SMTP id f190so17842750ita.5 for ; Mon, 11 Dec 2017 10:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MSuANOfCaBdBc+9/XSqAPvIkTv9sWi5agWGjY7oRkAI=; b=Al+d6DiQuYLkgAnsAtEYc80WMO8uXmouJoEadQTuaO8s4lNNRNBkavIAh3L+JkbiDx YhL11jz2oWnvAz88jTdLLbIj/DkiYttYjjHu+CGrAgzilGx7vRX//k9x0dUWQgin8lTj 5AQgI+qrwhbScj1wCUMTJdAt7XykDstbsMK2c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MSuANOfCaBdBc+9/XSqAPvIkTv9sWi5agWGjY7oRkAI=; b=b9VkZyWhpt/PmypoyRniJ7MT/wfgSZRWce8yRSJopdqdaIOy7YmEo0E3qcw/eSeqQE OHXIYarckxPwRcq8nOr+5FbxYe1h7JtdgczzDQYgIZW+FY9MVCiIgSzCAwKoxzSW9Isn phwc8Vz0mnf2fFICoNPKpLyu8y9qtkDbtWMKtEzLqWk+eeIQkNwdOICJTiuHvY9sowdf E89kK8B547DiBopaKlzqwZbhkohs7Drq7M5skexYLV99T7rYsVQcnTPRsgXqVodotdjY YJjwOpQne4Vvf2DOIElMPlzdiuiNBGd8Y2gbULQOaTIaRi6p1NlvNYmIldxNTQLnrGF2 usWQ== X-Gm-Message-State: AKGB3mLpwwsi2DuyLT85FZvY9UQdN6WblGjJ22xnBTzbYwidwKJwnwKb ZPzmanslIyWS26NdpS29oMGkhi0iO/+uUKoyteDe5JddIf0= X-Google-Smtp-Source: ACJfBosthMzR2X3hxmhbh3GSZSiRJp1rhuz9qqQTW4xE2dxAvqJ2txcweHW9Mm4D2YkmYHHVgaKrmiKUhz7wuFBfWXc= X-Received: by 10.36.78.212 with SMTP id r203mr2155395ita.58.1513015515787; Mon, 11 Dec 2017 10:05:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Mon, 11 Dec 2017 10:05:15 -0800 (PST) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18E219@SHSMSX104.ccr.corp.intel.com> References: <20171208155514.18926-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E18E219@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 11 Dec 2017 18:05:15 +0000 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "leif.lindholm@linaro.org" Subject: Re: [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 18:00:39 -0000 Content-Type: text/plain; charset="UTF-8" On 10 December 2017 at 13:30, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks. Pushed as 3b3c009a25543bf709267982b2583dd486d4d24d >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel >> Sent: Friday, December 8, 2017 11:55 PM >> To: edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Gao, Liming ; leif.lindholm@linaro.org; Ard Biesheuvel >> >> Subject: [edk2] [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images >> >> The ARM calling convention is fundamentally incompatible with EBC, >> and having a cross compatible machine type identical to the native >> type does not make a lot of sense either. So restrict the compatible >> machine type for ARM to EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, and remove >> the cross compatible. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> MdePkg/Include/Uefi/UefiBaseType.h | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiBaseType.h >> index 728a0472602a..d9556cd2ec4e 100644 >> --- a/MdePkg/Include/Uefi/UefiBaseType.h >> +++ b/MdePkg/Include/Uefi/UefiBaseType.h >> @@ -270,10 +270,9 @@ typedef union { >> >> #elif defined (MDE_CPU_ARM) >> >> -#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \ >> - (((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) || ((Machine) == EFI_IMAGE_MACHINE_EBC)) >> +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) >> >> -#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) >> +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE) >> >> #elif defined (MDE_CPU_AARCH64) >> >> -- >> 2.11.0 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel