From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 22A181A1E4F for ; Fri, 9 Sep 2016 01:27:45 -0700 (PDT) Received: by mail-oi0-x22e.google.com with SMTP id m11so126119928oif.1 for ; Fri, 09 Sep 2016 01:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oS8S/mugDaHOKNO+E5kasAx5ioPM6oLPsh9SZQqk/Vg=; b=Q15f6T2PKxsCBY185s3QgkFV/8kXo9W7O7wlY6vAKpdGgY89TlUlL1z6Tg5j585EWU s1wm1zPWwkr7Cpvouw5NOYxMasYICMXY5u+ODugFsXinWsjZ4CEh8bsmgVkj0oYK9bgH Z16JrADJK+2FC41yxl2iIgLwh2wQJ2m90cOS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oS8S/mugDaHOKNO+E5kasAx5ioPM6oLPsh9SZQqk/Vg=; b=aOxugaWLxrMgloSmJJ9/gLGuDPdsJ6cE6mqrv/17gtqncARjuuomvjB7iigIhxjIFQ POV7DP1lkQdn/HY4cCpHRTluvJeboJVjy4bAfJEPmkMU5rfYjDGTSVRk984Ujq2BJMkj YFNOJWan+DkvAac5UcMBU+89usIU7mYV/z1u9rERTFsYsvudqqGx/yXpxr/Mstu8ikx/ 9j/CnHNFRST6DJ8X3+cVLomQEtgLukREJmQowElIa+tNr7oDmsu/npfDtFHwnJvLsHnB fr7J4bVJbI1J3OPptarbxGWQbLfGCsB79B35gMnr/idL6m8vVozA36PIcQBNpNBaAvx8 Mq1w== X-Gm-Message-State: AE9vXwN/bKm5bxWvSDw5nHXE39oxaNSO1MJo9NEnFfEFYmJQxcXKyuc3XeEseyEzVCpl10T3nQAuxm+QeT2YdbA3 X-Received: by 10.157.14.59 with SMTP id c56mr3204787otc.18.1473409664229; Fri, 09 Sep 2016 01:27:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Fri, 9 Sep 2016 01:27:43 -0700 (PDT) In-Reply-To: <55929520-7be5-fbec-342b-fc61c70c128a@redhat.com> References: <20160909072356.4746-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E63EF@shsmsx102.ccr.corp.intel.com> <55929520-7be5-fbec-342b-fc61c70c128a@redhat.com> From: Ard Biesheuvel Date: Fri, 9 Sep 2016 09:27:43 +0100 Message-ID: To: Laszlo Ersek Cc: "Gao, Liming" , edk2-devel-01 , "Zhu, Yonghong" Subject: Re: [PATCH v2] BaseTools/EfiRom: supply missing machine type lookup strings X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 08:27:45 -0000 Content-Type: text/plain; charset=UTF-8 On 9 September 2016 at 09:26, Laszlo Ersek wrote: > On 09/09/16 09:25, Gao, Liming wrote: >> Reviewed-by: Liming Gao > > Thanks. > > Ard, are you OK with this patch? (You were OK with "ARM" in advance, but > the AARCH64 string also changed in this version.) > Yes, perfectly acceptable to me. Reviewed-by: Ard Biesheuvel >>> -----Original Message----- >>> From: Laszlo Ersek [mailto:lersek@redhat.com] >>> Sent: Friday, September 09, 2016 3:24 PM >>> To: edk2-devel-01 >>> Cc: Ard Biesheuvel ; Gao, Liming >>> ; Zhu, Yonghong >>> Subject: [PATCH v2] BaseTools/EfiRom: supply missing machine type lookup >>> strings >>> >>> "EfiRom --dump" does not recognize the 0x8664 machine type: >>> >>>> EFI ROM header contents >>>> EFI Signature 0x0EF1 >>>> Compression Type 0x0001 (compressed) >>>> Machine type 0x8664 (unknown) >>>> Subsystem 0x000B (EFI boot service driver) >>>> EFI image offset 0x0050 (@0xF650) >>> >>> Add lookup strings for the remaining EFI_IMAGE_MACHINE_* numeric >>> macros >>> that can be found in >>> "BaseTools/Source/C/Include/IndustryStandard/PeImage.h". The strings >>> follow Table 12. "UEFI Image Types" from the UEFI v2.6 spec. >>> >>> Cc: Ard Biesheuvel >>> Cc: Liming Gao >>> Cc: Yonghong Zhu >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Laszlo Ersek >>> --- >>> >>> Notes: >>> v2: >>> - use ARM for ARM [Ard, Liming] >>> - use AA64 for AARCH64 [Liming] >>> - reference Table 12 in the commit message [Liming] >>> >>> BaseTools/Source/C/EfiRom/EfiRom.h | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/BaseTools/Source/C/EfiRom/EfiRom.h >>> b/BaseTools/Source/C/EfiRom/EfiRom.h >>> index 1214700826de..6763d6b1ec28 100644 >>> --- a/BaseTools/Source/C/EfiRom/EfiRom.h >>> +++ b/BaseTools/Source/C/EfiRom/EfiRom.h >>> @@ -117,6 +117,9 @@ static STRING_LOOKUP mMachineTypes[] = { >>> { EFI_IMAGE_MACHINE_IA32, "IA32" }, >>> { EFI_IMAGE_MACHINE_IA64, "IA64" }, >>> { EFI_IMAGE_MACHINE_EBC, "EBC" }, >>> + { EFI_IMAGE_MACHINE_X64, "X64" }, >>> + { EFI_IMAGE_MACHINE_ARMT, "ARM" }, >>> + { EFI_IMAGE_MACHINE_AARCH64, "AA64" }, >>> { 0, NULL } >>> }; >>> >>> -- >>> 2.9.2 >> >