* [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg
@ 2018-03-28 11:38 Laszlo Ersek
2018-03-28 12:57 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2018-03-28 11:38 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Dr. David Alan Gilbert, Ard Biesheuvel, Jordan Justen
QEMU calculates the UINT64 value in "etc/reserved-memory-end" in a quite
complex way, in the pc_memory_init() function. Log the value as a
DEBUG_VERBOSE message to support debugging.
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1353591
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/PlatformPei/MemDetect.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
index 2b2f3e4bec55..2f9e83551364 100644
--- a/OvmfPkg/PlatformPei/MemDetect.c
+++ b/OvmfPkg/PlatformPei/MemDetect.c
@@ -358,6 +358,8 @@ GetFirstNonAddress (
if (!EFI_ERROR (Status) && FwCfgSize == sizeof HotPlugMemoryEnd) {
QemuFwCfgSelectItem (FwCfgItem);
QemuFwCfgReadBytes (FwCfgSize, &HotPlugMemoryEnd);
+ DEBUG ((DEBUG_VERBOSE, "%a: HotPlugMemoryEnd=0x%Lx\n", __FUNCTION__,
+ HotPlugMemoryEnd));
ASSERT (HotPlugMemoryEnd >= FirstNonAddress);
FirstNonAddress = HotPlugMemoryEnd;
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg
2018-03-28 11:38 [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg Laszlo Ersek
@ 2018-03-28 12:57 ` Ard Biesheuvel
2018-03-28 13:09 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-03-28 12:57 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-01, Dr. David Alan Gilbert, Jordan Justen
On 28 March 2018 at 13:38, Laszlo Ersek <lersek@redhat.com> wrote:
> QEMU calculates the UINT64 value in "etc/reserved-memory-end" in a quite
> complex way, in the pc_memory_init() function. Log the value as a
> DEBUG_VERBOSE message to support debugging.
>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1353591
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> OvmfPkg/PlatformPei/MemDetect.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
> index 2b2f3e4bec55..2f9e83551364 100644
> --- a/OvmfPkg/PlatformPei/MemDetect.c
> +++ b/OvmfPkg/PlatformPei/MemDetect.c
> @@ -358,6 +358,8 @@ GetFirstNonAddress (
> if (!EFI_ERROR (Status) && FwCfgSize == sizeof HotPlugMemoryEnd) {
> QemuFwCfgSelectItem (FwCfgItem);
> QemuFwCfgReadBytes (FwCfgSize, &HotPlugMemoryEnd);
> + DEBUG ((DEBUG_VERBOSE, "%a: HotPlugMemoryEnd=0x%Lx\n", __FUNCTION__,
> + HotPlugMemoryEnd));
>
> ASSERT (HotPlugMemoryEnd >= FirstNonAddress);
> FirstNonAddress = HotPlugMemoryEnd;
> --
> 2.14.1.3.gb7cf6e02401b
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg
2018-03-28 12:57 ` Ard Biesheuvel
@ 2018-03-28 13:09 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2018-03-28 13:09 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel-01, Dr. David Alan Gilbert, Jordan Justen
On 03/28/18 14:57, Ard Biesheuvel wrote:
> On 28 March 2018 at 13:38, Laszlo Ersek <lersek@redhat.com> wrote:
>> QEMU calculates the UINT64 value in "etc/reserved-memory-end" in a quite
>> complex way, in the pc_memory_init() function. Log the value as a
>> DEBUG_VERBOSE message to support debugging.
>>
>> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1353591
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks Ard! Commit c27c0003c10f.
Laszlo
>> ---
>> OvmfPkg/PlatformPei/MemDetect.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
>> index 2b2f3e4bec55..2f9e83551364 100644
>> --- a/OvmfPkg/PlatformPei/MemDetect.c
>> +++ b/OvmfPkg/PlatformPei/MemDetect.c
>> @@ -358,6 +358,8 @@ GetFirstNonAddress (
>> if (!EFI_ERROR (Status) && FwCfgSize == sizeof HotPlugMemoryEnd) {
>> QemuFwCfgSelectItem (FwCfgItem);
>> QemuFwCfgReadBytes (FwCfgSize, &HotPlugMemoryEnd);
>> + DEBUG ((DEBUG_VERBOSE, "%a: HotPlugMemoryEnd=0x%Lx\n", __FUNCTION__,
>> + HotPlugMemoryEnd));
>>
>> ASSERT (HotPlugMemoryEnd >= FirstNonAddress);
>> FirstNonAddress = HotPlugMemoryEnd;
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-28 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-28 11:38 [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg Laszlo Ersek
2018-03-28 12:57 ` Ard Biesheuvel
2018-03-28 13:09 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox