From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4A97D211A2086 for ; Sat, 15 Dec 2018 10:16:49 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id l3so6995907ioc.10 for ; Sat, 15 Dec 2018 10:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4aengg5+BgkLC6rmpJJP1YEm2N3xqYj460xI0SOPsEA=; b=T7qT8J7nLnv3GUy25zMMViovltPf4QBSUNyNNmTJm/pp+4D3IL0nlf02unJFA06iQs tXuAOqIfVemqs4l29Udem67sVRQSsOdwX3KMEJPfU8taZ+F55/XjgB0BoyNmCNjYTNlB N4bUI6NQbIuCBGIHwcZgKXL0T55S0tw2rNFQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4aengg5+BgkLC6rmpJJP1YEm2N3xqYj460xI0SOPsEA=; b=uV5tPp9HhObfZSO9A8stbv6VAx5kQZkzSYU+oaAxoz/VMDliCrjeOrjdCIHEj0X/bN 9J3XaH2kGm2XSgrAn0keRISRYORXn0ISY8IX58eocg/UHKfGyTmKachedkx3cw5YGY/X yMS3W4iR1ecan655RNraEWxCxtIRzj8dB30Uqrxms+1NCBD2w6EGR7HRzgSULrySfwys Hd8AREBcBGep4mCUH1NrO2Ar3x6fqDFYUddLzEeR80WCvgiLMGaXwEU0aPVLfVQ4HXEu PlXCVjhJQe5LlUfNdHWKgxQ/2ckC9x6riMDhq/YsdJCOQln49Sbr+dDk10K1NMpP1HkY CsJQ== X-Gm-Message-State: AA+aEWYt05b9vJfDP8vHwhfSDmfVxkhQ9kQ4kLSvyOGc2zzHAiXHneDU Bfb0ZJpgBSpyXoeogmTs6Fb46eM7ysTE4mQLVWFZSw== X-Google-Smtp-Source: AFSGD/V5ZCsN5P98ni+uD5fxNV57vL8gbfNeoeHj3ZCpfzutYMY688T59QHgiY9tIXLv0Jz2Jyy+XNIlMoXbZTawmsg= X-Received: by 2002:a5d:8415:: with SMTP id i21mr6365610ion.173.1544897808287; Sat, 15 Dec 2018 10:16:48 -0800 (PST) MIME-Version: 1.0 References: <20181215083308.15038-1-ard.biesheuvel@linaro.org> <20181215110317.z6badq2nzzas5wjy@bivouac.eciton.net> In-Reply-To: <20181215110317.z6badq2nzzas5wjy@bivouac.eciton.net> From: Ard Biesheuvel Date: Sat, 15 Dec 2018 19:16:41 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg: remove redundant _ARM_PLATFORM_FLAGS overrides X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2018 18:16:49 -0000 Content-Type: text/plain; charset="UTF-8" On Sat, 15 Dec 2018 at 12:03, Leif Lindholm wrote: > > On Sat, Dec 15, 2018 at 09:33:08AM +0100, Ard Biesheuvel wrote: > > Our default is already armv7-a, so no need to rewrite the PLATFORM_FLAGS > > for that. Also, setting -mfpu=neon is not entirely inappropriate, since > > NEON is not mandatory under v7. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks Pushed as 48e890457b06..0a538ddab43f > > --- > > ArmPkg/ArmPkg.dsc | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > > index 495f13d2bbec..5d83c18b143e 100644 > > --- a/ArmPkg/ArmPkg.dsc > > +++ b/ArmPkg/ArmPkg.dsc > > @@ -31,9 +31,6 @@ > > SKUID_IDENTIFIER = DEFAULT > > > > [BuildOptions] > > - XCODE:*_*_ARM_PLATFORM_FLAGS == -arch armv7 > > - GCC:*_*_ARM_PLATFORM_FLAGS == -march=armv7-a -mfpu=neon > > - > > RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > > *_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES > > > > -- > > 2.17.1 > >