From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-x22b.google.com (mail-yw0-x22b.google.com [IPv6:2607:f8b0:4002:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D8D641A1E57 for ; Tue, 25 Oct 2016 01:28:45 -0700 (PDT) Received: by mail-yw0-x22b.google.com with SMTP id t192so31693927ywf.0 for ; Tue, 25 Oct 2016 01:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zgsowzEIjE7M5kOF6FfYmWur8mASGQ9EruIzjicHPTY=; b=VcaUy1N0Ju1MFFRsg13FGzxumBaWIc81Uiw9+V/75meOqvGcij/hr+4xX5v7ipAG22 o+NbWf9ziMZiHCrbUylKAu4tH2iB4akx8I7bmEMCcD4ZndPndk4WVlSWET2Ph83P4Rnr zkt6EeYJV/QuiKPiB6E0PYBZajv2Ia1xxg5LI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zgsowzEIjE7M5kOF6FfYmWur8mASGQ9EruIzjicHPTY=; b=JPR/zbcwtss2xeJFjjTH1bzy4sjLn095AOkruOCitTPA39PWyzfTExNYYOCtsT/Bb0 J+XiLPiloBqGOB3vOXezq1sVKM3gYxcNwlH12lvqhw1GWoy9l77MIUhLmakNTKuxhJ+S KiDHkrBvwSpemc3YSESCUAuZohYLN6qrUsuAg2d0+MV2/IxqZr1854ugB7DMzm4vwuDO w8aa7bOW5rmZd5SdZPMbwo+mVQaopWsPCsFe3lADmbPM+gxPpg2hM4StqbRq771H6PSI ZPJUywDeQ6a6b1hgaw2txmoej24zxfcbH+dJhevr+J9xQpO9F88CF9DV/Qy764VXb/Nl SP0g== X-Gm-Message-State: ABUngvfcF99ipEWSDgSCQRvS+RhuLe1WR7dLPw/XGl6pIJ8j27UHXkSJRD2xtH4mjsMzH34jPkPjHsVaZzfPTrIo X-Received: by 10.107.28.148 with SMTP id c142mr14748014ioc.45.1477384124817; Tue, 25 Oct 2016 01:28:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.5.139 with HTTP; Tue, 25 Oct 2016 01:28:44 -0700 (PDT) In-Reply-To: <6e3e7956-be37-3a83-53ea-6abfb3111704@redhat.com> References: <20161021212737.15974-1-lersek@redhat.com> <20161021212737.15974-20-lersek@redhat.com> <6e3e7956-be37-3a83-53ea-6abfb3111704@redhat.com> From: Ard Biesheuvel Date: Tue, 25 Oct 2016 09:28:44 +0100 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 Subject: Re: [PATCH 19/19] ArmVirtPkg: disable deprecated interfaces X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 08:28:46 -0000 Content-Type: text/plain; charset=UTF-8 On 25 October 2016 at 09:25, Laszlo Ersek wrote: > Ard, > > On 10/21/16 23:27, Laszlo Ersek wrote: >> At this point no code in ArmVirtPkg (and apparently no code outside of >> ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs, >> so we can disable them in the common platform DSC include file: >> >> BaseLib: >> - StrCpy >> - StrnCpy >> - StrCat >> - StrnCat >> - UnicodeStrToAsciiStr >> - AsciiStrCpy >> - AsciiStrnCpy >> - AsciiStrCat >> - AsciiStrnCat >> - AsciiStrToUnicodeStr >> >> PcdLib: >> - PcdSet8 >> - PcdSet16 >> - PcdSet32 >> - PcdSet64 >> - PcdSetPtr >> - PcdSetBool >> - PcdSetEx8 >> - PcdSetEx16 >> - PcdSetEx32 >> - PcdSetEx64 >> - PcdSetExPtr >> - PcdSetExBool >> >> UefiLib: >> - GetVariable >> - GetEfiGlobalVariable >> >> Cc: Ard Biesheuvel >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> not build-tested with RVCT >> >> ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc >> index c071988ad8f5..dbd6678accde 100644 >> --- a/ArmVirtPkg/ArmVirt.dsc.inc >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc >> @@ -246,6 +246,12 @@ [BuildOptions] >> >> GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG >> >> + # >> + # Disable deprecated APIs. >> + # >> + RVCT:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES >> + GCC:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES >> + >> ################################################################################ >> # >> # Pcd Section - list of all EDK II PCD Entries defined by this Platform >> > > Can you please give an R-b for this too? > Reviewed-by: Ard Biesheuvel However, I am still a bit uneasy regarding the lack of explicit confirmation that it is the responsibility of the person who moves functions under a '#ifndef DISABLE_NEW_DEPRECATED_INTERFACES' to ensure that all references have been removed from the *entire* codebase, not just the intel bits.