From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9D14F203564A6 for ; Wed, 29 Nov 2017 00:36:20 -0800 (PST) Received: by mail-io0-x244.google.com with SMTP id t196so2926072iof.0 for ; Wed, 29 Nov 2017 00:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jAtszrWdKh4GefO+yjXAla8FiyIEKyrysu6g80Z84PM=; b=iHUm74rwtdys5wYROdT7ukuq3+4MnJAGs5ydeRVDWYUyw7sJc94rA/Fa26LO0d8FUJ KtrECSNzHNQSu9fEIs6OJwtHh7pVf/UK6Ds1O0lteATODGbe03VzZzMJhKa3x5cU2Qi5 OrY30J2oBZhW+oKi5PPtYzt8CpBexhKfttZUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jAtszrWdKh4GefO+yjXAla8FiyIEKyrysu6g80Z84PM=; b=c+ut5/H7mFDcDEHxAxkELuOHgELfJ5MzzwL+f5CxX1lyAU2609nydGw5yUAy+w12GI vFd6QquDJFy7nNnPkDEVXgU4/8zRuH1hYW5G0juo3VuLsGAIJ6ei1LPvK1XPFXTG27ie g6RtRJq6Y9slj4qJskuhC3BAB0os8VZ3Ca1K7Njzf0OxQF5QFcXJuD/Xd5BYKiomW4lj Rfz5auZuMccWb4e4L6A5KqomF7eJvrtNC6t3r4yTy/BaNhfwlopOw7MgmXlWNepKTpOG ZOsVisqLmdDgEX9FAGH7791YMlcYElIUBeCFG3dwCKHrq0gF1j9o3PohV5fvDuRf5NbG 7C6g== X-Gm-Message-State: AJaThX6XLjr5Mj0gw1IMj6hZ8N7L0XbNoM1VSCuMGQxZfTCtbLTqaGaQ Of9qaC5vsmJa9gJyTucBnC7I9lMAxBk94OJIoxRvRA== X-Google-Smtp-Source: AGs4zMbfkxPgWLbjgM/lhxQZON9gB9bkIwcxRDQglNtc4X59HQchmsXjcTtU2xLEcMteUu1Ub+zokrPN+bd4JFpPVqo= X-Received: by 10.107.2.137 with SMTP id 131mr2549466ioc.186.1511944843824; Wed, 29 Nov 2017 00:40:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Wed, 29 Nov 2017 00:40:43 -0800 (PST) In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BAD6865@SHSMSX104.ccr.corp.intel.com> References: <20171129005952.208940-1-ruiyu.ni@intel.com> <20171129005952.208940-5-ruiyu.ni@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BAD6865@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 29 Nov 2017 08:40:43 +0000 Message-ID: To: "Ni, Ruiyu" Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp library removal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 08:36:20 -0000 Content-Type: text/plain; charset="UTF-8" On 29 November 2017 at 08:28, Ni, Ruiyu wrote: > Ard, > PcdShellLibAutoInitialize is specially set to FALSE in old code for Shell.efi build. > But in old code line 507, it is set FALSE for Shell.efi build. > So the global setting of this PCD can be removed. > OK, fair enough. Reviewed-by: Ard Biesheuvel > Thanks/Ray > >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Wednesday, November 29, 2017 3:57 PM >> To: Ni, Ruiyu >> Cc: edk2-devel@lists.01.org; Leif Lindholm >> Subject: Re: [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp >> library removal >> >> On 29 November 2017 at 00:59, Ruiyu Ni wrote: >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Ruiyu Ni >> > Cc: Leif Lindholm >> > Cc: Ard Biesheuvel >> > --- >> > BeagleBoardPkg/BeagleBoardPkg.dsc | 16 +++++++++------- >> > BeagleBoardPkg/BeagleBoardPkg.fdf | 3 ++- >> > 2 files changed, 11 insertions(+), 8 deletions(-) >> > >> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc >> b/BeagleBoardPkg/BeagleBoardPkg.dsc >> > index 4f7c0bd645..d67ccf377e 100644 >> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc >> > @@ -2,7 +2,7 @@ >> > # Beagle board package. >> > # >> > # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
>> > -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>> > +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
>> > # Copyright (c) 2016, Linaro Ltd. All rights reserved.
>> > # >> > # This program and the accompanying materials >> > @@ -355,11 +355,6 @@ [PcdsFixedAtBuild.common] >> > # OMAP Interrupt Controller >> > gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x48200000 >> > >> > - # We want to use the Shell Libraries but don't want it to initialise >> > - # automatically. We initialise the libraries when the command is called by >> the >> > - # Shell. >> > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >> > - >> >> Why are you moving this? The TFTP shell library is not the only user >> of this PCD. >> >> > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10 >> > >> > # GUID of the UEFI Shell >> > @@ -487,6 +482,14 @@ [Components.common] >> > >> NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf >> > >> NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMainte >> nanceManagerUiLib.inf >> > } >> > + >> > + # >> > + # Shell >> > + # >> > + >> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. >> inf { >> > + >> > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >> > + } >> > ShellPkg/Application/Shell/Shell.inf { >> > >> > >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma >> ndLib.inf >> > @@ -497,7 +500,6 @@ [Components.common] >> > >> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com >> mandsLib.inf >> > >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com >> mandsLib.inf >> > >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 >> CommandsLib.inf >> > - >> NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib >> .inf >> > >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> > >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg >> CommandLib.inf >> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf >> b/BeagleBoardPkg/BeagleBoardPkg.fdf >> > index c9c6afd714..71249c7eb3 100644 >> > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf >> > @@ -1,7 +1,7 @@ >> > # FLASH layout file for Beagle board. >> > # >> > # Copyright (c) 2009, Apple Inc. All rights reserved.
>> > -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>> > +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
>> > # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
>> > # >> > # This program and the accompanying materials >> > @@ -178,6 +178,7 @@ [FV.FvMain] >> > # UEFI application (Shell Embedded Boot Loader) >> > # >> > INF ShellPkg/Application/Shell/Shell.inf >> > + INF >> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. >> inf >> > >> > # >> > # Bds >> > -- >> > 2.15.0.gvfs.1.preview.4 >> >