Re: [PATCH 0/6] ArmPkg EmbeddedPkg: clean up DmaLib implementations

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 30 August 2017 at 14:06, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Wed, Aug 30, 2017 at 09:21:02AM +0100, Ard Biesheuvel wrote:
>> Currently, we have two DmaLib implementations: a cache coherent one called
>> 'NullDmaLib' residing in EmbeddedPkg, and a non-cache coherent one called
>> 'ArmDmaLib', residinh in ArmPkg.
>>
>> In both cases, this is slightly awkward: NullDmaLib suggests no functionality
>> whatsoever, which is slightly misleading because 'nothing' is the correct
>> action in case of cache coherent DMA, rather than a lack of action. As for
>> ArmDmalib, this was never specific to ARM, and no longer depends on anything
>> that ArmPkg provides, so it does not really belong in ArmPkg anymore.
>>
>> So let's rename them to CoherentDmaLib and NonCoherentDmaLib, respectively,
>> and move that latter into EmbeddedPkg where it arguably belongs. To align
>> the two further, add support for non-1:1 DMA mappings to CoherentDmaLib as
>> well.
>>
>> Note that the final patch can only be merged after out-of-tree platforms
>> have switched from ArmDmaLib to NonCoherentDmaLib.
>
> For 4-6/6:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks,

#1 - #5 merged as

7385d2543e2a EmbeddedPkg: rename NullDmaLib to CoherentDmaLib
0bcb80106762 EmbeddedPkg/CoherentDmaLib: add support for non-1:1 DMA translation
723102c72fb0 EmbeddedPkg: implement NonCoherentDmaLib based on ArmDmaLib
c878cd95e132 Omap35xxPkg: switch to EmbeddedPkg's NonCoherentDmaLib
877f4460b3e3 BeagleBoardPkg: switch to generic non-coherent DmaLib

#6 needs to wait until the edk2-platforms changes are in.