From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A14621E95E04 for ; Wed, 30 Aug 2017 06:14:43 -0700 (PDT) Received: by mail-io0-x22c.google.com with SMTP id 81so4871255ioj.5 for ; Wed, 30 Aug 2017 06:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=u8jFCxbyj26Gz4peHyg5n2K9+Wnpn9XGbOVvs6ASgAs=; b=gT5th411BtpUEeI4YXINLT/FQ3QeJgkmYnt//dUwgfxeZNF29A9ycama3I/PmD2Zsd /FA3RCzuAOAWJAHhiS/E9D9/ruFmzv20ehgTACIpgUXbnMsvng/iouCbtkgQcUpG9Mex 9MwZyIqYTYpewkUkDjBmfhqPVDe7RHpnAZjfQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=u8jFCxbyj26Gz4peHyg5n2K9+Wnpn9XGbOVvs6ASgAs=; b=ZsYlzwqdO7naOuci+/dB0qzWcRGVyOBmUpXEm1smFYdCWKJrSHPRXrngZSLhtIXJ1p BngeV42nsNsp/eRhNzZpofJOlwyloyIFB+hL41zQXOWmfbTRvotE6zSAoMF19zu562+s ugWBPGLl7/wOSmmpqaH5ygFldiUWUoRyNg/fmFeYt8emTeuUza+Z1Qk+eMKeTTN+qgvo aAZtz80lw6qVUWTnz5822xIHy7LUd9fGOOWAG6/JeWnkGjsUSRCcjzxua4/ld+AhXnOJ Z36wbSj8Y0fncsltZ3grXXALbc83H1WEqMw4+1I2lPzDazEh7jYvieVo9hCZ9FM6vCkZ Awow== X-Gm-Message-State: AHPjjUihLWXQhTRBBJERdNeW+lQ2Rt8l20hryY4O7P0mcp44Dy/bY9tR eHmgf4Wh9LOt1KwHTLagrDLUPdoNXy4pKnH5aw== X-Received: by 10.107.157.78 with SMTP id g75mr1309914ioe.190.1504099044008; Wed, 30 Aug 2017 06:17:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Wed, 30 Aug 2017 06:17:23 -0700 (PDT) In-Reply-To: <20170830130639.dutwmsa5fzx3khsp@bivouac.eciton.net> References: <20170830082108.7470-1-ard.biesheuvel@linaro.org> <20170830130639.dutwmsa5fzx3khsp@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 30 Aug 2017 14:17:23 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 0/6] ArmPkg EmbeddedPkg: clean up DmaLib implementations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 13:14:43 -0000 Content-Type: text/plain; charset="UTF-8" On 30 August 2017 at 14:06, Leif Lindholm wrote: > On Wed, Aug 30, 2017 at 09:21:02AM +0100, Ard Biesheuvel wrote: >> Currently, we have two DmaLib implementations: a cache coherent one called >> 'NullDmaLib' residing in EmbeddedPkg, and a non-cache coherent one called >> 'ArmDmaLib', residinh in ArmPkg. >> >> In both cases, this is slightly awkward: NullDmaLib suggests no functionality >> whatsoever, which is slightly misleading because 'nothing' is the correct >> action in case of cache coherent DMA, rather than a lack of action. As for >> ArmDmalib, this was never specific to ARM, and no longer depends on anything >> that ArmPkg provides, so it does not really belong in ArmPkg anymore. >> >> So let's rename them to CoherentDmaLib and NonCoherentDmaLib, respectively, >> and move that latter into EmbeddedPkg where it arguably belongs. To align >> the two further, add support for non-1:1 DMA mappings to CoherentDmaLib as >> well. >> >> Note that the final patch can only be merged after out-of-tree platforms >> have switched from ArmDmaLib to NonCoherentDmaLib. > > For 4-6/6: > Reviewed-by: Leif Lindholm > Thanks, #1 - #5 merged as 7385d2543e2a EmbeddedPkg: rename NullDmaLib to CoherentDmaLib 0bcb80106762 EmbeddedPkg/CoherentDmaLib: add support for non-1:1 DMA translation 723102c72fb0 EmbeddedPkg: implement NonCoherentDmaLib based on ArmDmaLib c878cd95e132 Omap35xxPkg: switch to EmbeddedPkg's NonCoherentDmaLib 877f4460b3e3 BeagleBoardPkg: switch to generic non-coherent DmaLib #6 needs to wait until the edk2-platforms changes are in.