From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1BC3121B02822 for ; Fri, 18 Jan 2019 10:40:04 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id f4so11569691ion.2 for ; Fri, 18 Jan 2019 10:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M7jaqKdE3H+EmCf0nrdsmM+F6qQgq5D8bSnQIVMyzBs=; b=IEQg0yilSOGX/8DD887x2X6GykFyjibQ08z7ks3re5fPP4/wsOHXEzvw8VHJkoBGCb Rk5v02JBUz2xj+ts44kvcQH5E6zKqn4eBCSora3+NiEJf+PzPdN/HccGVodCPyDsgGpx Gjsj1kDzMRAkzgpD8517vKTxJEdcArjDBoFn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7jaqKdE3H+EmCf0nrdsmM+F6qQgq5D8bSnQIVMyzBs=; b=kq0zA7DQQ34cmJypQn0UtQL3WUdsqFtaKwET/JZXSizTmFqcvoqRCx7rvkYcb5m0Xa wLNFmV8BIPB1u6vnPAOe3I9DEvBZSEIuyTzmT8l190SVFdQ5cvVkWTZngbhlUU8+LWnx lzrHUYRAVutzMt1VtR4dW522LSuLyunCMnWbnxhV0zieaipnQnZ0EYyBSoWa3mIYG8td 5YZ+xpwHCd0ebZlDfjWcDDON3WiYfB0kbsG38RwK3mMhAMVReY7amBgGN9cPd1O5l+T8 YyfabSW37V1FJ4wsKY3yP/5v362rhN8m04xJRAdNoP00aBs1f80kF2J1hSM3z+92QdGz vcRg== X-Gm-Message-State: AJcUukepfUx5W+nhTbd6vk2o0gW6eef81VLQNQsgh+lZvXWfm9k8e3Ka s1i/WxcxaG4JbU9mM6gvVOaoN0l09QkZvSxBr54ruw== X-Google-Smtp-Source: ALg8bN5Op5EC/gWseI9wvTWuqK9GJ5dReR9sfj7WQbaYsFpzSP4u+ULQ73vyaQRnHJiuG+xoQokxuMeA2gUaQ2mPFf4= X-Received: by 2002:a5e:c206:: with SMTP id v6mr11676126iop.60.1547836804252; Fri, 18 Jan 2019 10:40:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Fri, 18 Jan 2019 19:39:52 +0100 Message-ID: To: Julien Grall Cc: edk2-devel-01 , Dandan Bi , "Gao, Liming" , Leif Lindholm , Laszlo Ersek , "Kinney, Michael D" , xen-devel Subject: Re: Unable to boot Linux with master EDK2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 18:40:05 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 18 Jan 2019 at 19:30, Julien Grall wrote: > > Hi all, > > I am trying to boot a Xen guest using the latest EDK2 master (cce9d76358 > "BaseTools: Allow empty value for HiiPcd in Dsc"), GRUB and Linux 5.0-rc2. > > The last code executed by Linux is when installing the virtual address > map in the EFI stub and then it seems to get stuck. I don't have much > information from the console: > > InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 7E041040 > Loading driver at 0x00068C70000 EntryPoint=0x00069D65664 > Loading driver at 0x00068C70000 EntryPoint=0x00069D65664 > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 7DF6AB18 > ProtectUefiImageCommon - 0x7E041040 > - 0x0000000068C70000 - 0x0000000002006000 > SetUefiImageMemoryAttributes - 0x0000000068C70000 - 0x0000000000001000 (0x0000000000004008) > SetUefiImageMemoryAttributes - 0x0000000068C71000 - 0x00000000011CD000 (0x0000000000020008) > SetUefiImageMemoryAttributes - 0x0000000069E3E000 - 0x0000000000E38000 (0x0000000000004008) > EFI stub: Booting Linux Kernel... > EFI stub: Using DTB from configuration table > EFI stub: Exiting boot services and installing virtual address map... > XenBus: Set state to 5 > XenBus: Set state to 5, done > XenPvBlk: waiting backend state 5, current: 4 > XenStore: Watch event 7E957398 > XenBus: Set state to 6 > XenBus: Set state to 6, done > XenPvBlk: waiting backend state 6, current: 5 > XenStore: Watch event 7E957398 > XenBus: Set state to 1 > XenBus: Set state to 1, done > Xen GrantTable, removing 38003 > Xen GrantTable, removing 38002 > Xen GrantTable, removing 38001 > Xen GrantTable, removing 38000 > SetUefiImageMemoryAttributes - 0x000000007F360000 - 0x0000000000040000 (0x0000000000000008) > SetUefiImageMemoryAttributes - 0x000000007BFF0000 - 0x0000000000040000 (0x0000000000000008) > SetUefiImageMemoryAttributes - 0x000000007BFA0000 - 0x0000000000040000 (0x0000000000000008) > SetUefiImageMemoryAttributes - 0x000000007BF00000 - 0x0000000000040000 (0x0000000000000008) > SetUefiImageMemoryAttributes - 0x000000007BE60000 - 0x0000000000040000 (0x0000000000000008) > SetUefiImageMemoryAttributes - 0x000000007BDC0000 - 0x0000000000040000 (0x0000000000000008) > > The bisector pointed to the following commit: > > commit 2f4a5a9f4c17ed88aaa3114d1e161e42cb80a9bf > Author: Dandan Bi > Date: Thu Jan 3 15:31:23 2019 +0800 > > MdePkg/BasePeCoffLib: Add more check for relocation data > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1426 > > V2: > (1) Add NULL pointer check for the input parameters > (2) Add check for the "Adjust" value before applying fix ups. > > In function PeCoffLoaderRelocateImageForRuntime, it doesn't > do much check when do relocation. For API level consideration, > it's not safe enough. > So this patch is to replace the same code logic with function > PeCoffLoaderImageAddress which will cover more validation. > > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > Reviewed-by: Liming Gao > > Any ideas what could have gone wrong? > > Best regards, > > -- > Julien Grall