From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC4072194EB7A for ; Mon, 11 Mar 2019 06:38:51 -0700 (PDT) Received: by mail-it1-x143.google.com with SMTP id x189so230157itd.3 for ; Mon, 11 Mar 2019 06:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F8m8KTQY6/7AEWT1z6CCUBcpFTqsYDa6b5cS5JL9w30=; b=xc/VxdngqxuYGVwpjaQqspCVZA4jK/uJYOgpKQzykFHk8lJy7JTQplUfsELJt5LM6A qPiWSBeZoG6wyGdzPQoj/zM7WYiZhsj2M/u9lQrwrubRWtIxEgjMcaQmwEVneMHy3/3f vEVnNSqMwgbDAbCtcSsdWNbPEtfKdlsghv2UkrGbMT0QJ5e+wOsvXfSfFPhGJaNPvS4B y/yY+MEGFR8UFhIkgAEuHtk9J2a4ZEe9QLiwSH19GyKnSLjqEIjwCcyn73XvhOmVCrFo wsPl9txnMkd0K5vNy1lJ+4kQKR8Kx4fUyOpoVX2zusDGVUUQUJTGnLghOYNbXP6tsRtY 9cQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F8m8KTQY6/7AEWT1z6CCUBcpFTqsYDa6b5cS5JL9w30=; b=UGBvutjqCiBlVypLd4tAGpgrPACCGkom6iB/zpQJqCjtfgdwNLyFYvj0UoMOQUHF9I 2j8I2mrpC/LcA9WBSs8kN/sUz4hAcWZT8YHl0x5sfLKeW0osMUHP80KQNqcJn93qZtSq wW46DD8as/ZCY8yZLVarO/3kA/bVa9BArtwp17HOuvXNKYxCSwVD95j7M45jhFYlkKhl 7hdH04oYBPNNOK+t3o4dGKbwLk9VA73cPF6e2ueC1P3NEISNWFbmAWASUcDbngpMW+lr YsBNrRrRS9N0LLtNNUwXCaWvrNU8qCr6CtVvRSrsMGMG4RBENgOf5JZ8gLqSp/3ZSQXk Cruw== X-Gm-Message-State: APjAAAUsC0FQhULhZo6eh7v9ZT2AFsX9y80ZHGt17NL8JUfEJ8vhbYXA mYfVZjGEwKTnDpe6/PRJuoKV18LI6/sQhyMMMUujkw== X-Google-Smtp-Source: APXvYqxMc1BS6wVSh8r2wZvkbL3O33QcuZ669nyEaU3mgeVVb52ZiJ4q/7GPLtkW02vZmdF+5PmG9C1BprZUOUcIyLk= X-Received: by 2002:a24:32d0:: with SMTP id j199mr16329520ita.71.1552311530853; Mon, 11 Mar 2019 06:38:50 -0700 (PDT) MIME-Version: 1.0 References: <20190308153010.18486-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Mon, 11 Mar 2019 14:38:39 +0100 Message-ID: To: Thomas Abraham Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 13:38:52 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 11 Mar 2019 at 14:31, Thomas Abraham wrote: > > On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel wrote: > > > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > > - add a resolution for ExtractGuidedSectionLib > > - remove reference to gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > > - update the resolution of StandaloneMmDriverEntryPoint > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > index 65dd6ac82c4a..ef16bfa9a20e 100644 > > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > @@ -43,6 +43,7 @@ > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > + ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf > > The build fails with the following error > > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:37: > undefined reference to `memcpy' > /tmp/ccOj5Ie6.ltrans0.ltrans.o: In function > `ExtractGuidedSectionLibConstructor': > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:233: > undefined reference to `memcpy' > collect2: error: ld returned 1 exit status > > I will check further why the build fails here. > We need to add this in the .dsc # # It is not possible to prevent the ARM compiler for generic intrinsic functions. # This library provides the instrinsic functions generate by a given compiler. # And NULL mean link this library into all ARM images. # NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf