From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D1E6621102D97 for ; Thu, 23 Aug 2018 08:42:52 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id e14-v6so8164852itf.1 for ; Thu, 23 Aug 2018 08:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sOfuxlnsvaTe01dwHkh2H5lK/3nE38nfhny1BNxmhpM=; b=YvRur8friWg3hjXfsrkjr/1UUufXJ5bhYeWJM3y06rMBtdb6IIGRuC/LZtfwz6jM+U Ir4fOB/g+aeihoIoHdbpaQz+Cd/wuFLmfMoNPXD/GhT0LzwbFYCFxP7LIf7o0cUHzBRP onaSJY3R19Wtl/0cpTlf7Y2rADbrNe2jSMqsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sOfuxlnsvaTe01dwHkh2H5lK/3nE38nfhny1BNxmhpM=; b=Hy4zwRgLFQS3L8xAB2OPJ0YCybmMnCxtP3DFtvqKXA60AqDN5R4jGIjyUqeFHgc2U6 7ZpJlmzyXrm6k3P794PCLC0nFgqHbQRAQGsRYRPNbqTitbo73AzogPcQ6IQ/7uZAtepR sqlgX/8CSlF3CBgvi2nxxYtvzRaIq4FDI9IDkyaQrnYdXAIU+TKsVo6S7BPfWO3x7Ugx BtGKyWa2gBg65TIfazFoIy60wHRwGBmcv9T8kyBYWjB4O0/M/1LHT0qW8YLlb3F3O1Yt 1jFKOaLgaGxMW109J6dBtJgPHIty6Ta6uRQ8dcL+55wt+owJYss1Q9Zq+Oik8ZQgZ4i8 phIQ== X-Gm-Message-State: APzg51Bk9LKghUxSb9ID9xt8TnrnSuYlnM1n+7ZMTKHlr9yE9RlkxY7N oK7S7lUQQG6fIl3r8/im6n/pEh6CupR64XbVFjndpQ== X-Google-Smtp-Source: ANB0VdbhzCCMU04cO9lxblGKXDfBgj9JCl71EdfggudHUQiA8RSpiU8U7BgM58iV3y69+6Q4dnt9iD8YCda03T/EQN8= X-Received: by 2002:a24:8309:: with SMTP id d9-v6mr6588865ite.123.1535038971789; Thu, 23 Aug 2018 08:42:51 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Thu, 23 Aug 2018 08:42:51 -0700 (PDT) In-Reply-To: <22c2f2a7-fd26-9d06-829b-c0c4bad8c23f@redhat.com> References: <1535003502-15734-1-git-send-email-haojian.zhuang@linaro.org> <22c2f2a7-fd26-9d06-829b-c0c4bad8c23f@redhat.com> From: Ard Biesheuvel Date: Thu, 23 Aug 2018 16:42:51 +0100 Message-ID: To: Laszlo Ersek Cc: Haojian Zhuang , "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 15:42:53 -0000 Content-Type: text/plain; charset="UTF-8" On 23 August 2018 at 12:29, Laszlo Ersek wrote: > On 08/23/18 07:51, Haojian Zhuang wrote: >> Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise, >> the hotkey of boot option won't be registered correctly. >> >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Haojian Zhuang >> --- >> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> index f9c71d430c99..81d36f218700 100644 >> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -479,7 +479,7 @@ GetPlatformOptions ( >> NULL, >> BootOptionNumber, >> 0, >> - BootKeys[Index], >> + &BootKeys[Index], >> NULL >> ); >> if (EFI_ERROR (Status)) { >> > > I'm sorry I didn't notice this while reviewing the patch that would end > up as commit 1b6e7633cad8 ("ArmPkg/PlatformBootManagerLib: load platform > boot options", 2018-06-05). Also, ellipses are tricky; the compiler > couldn't help. > > Please add the following to the commit message, just above the > Contributed-under line: > > Fixes: 1b6e7633cad8135547f337eeef47f446f57a2505 > > With that: > > Reviewed-by: Laszlo Ersek > Pushed as 2b2959dd347388d9a056d8116e02268cb563ef09 Thanks