From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Ni, Ray" <ray.ni@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
Date: Tue, 4 Jun 2019 15:41:52 +0200 [thread overview]
Message-ID: <CAKv+Gu_xdOxZm5V_mzbdQ2UGH22dMPV4JXPu3Vi1NoiFG1QEBQ@mail.gmail.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46B8D2@SHSMSX104.ccr.corp.intel.com>
On Tue, 4 Jun 2019 at 15:40, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> > Sent: Tuesday, June 4, 2019 7:53 PM
> > To: edk2-devel-groups-io <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
> > <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> >
> > On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni@intel.com> wrote:
> > >
> > > Zhiguang,
> > > I made a mistake here.
> > > I thought you changed the EmulatorPkg to not display the CPU speed
> > > but actually what you changed impacts all platforms.
> > > With this change, OVMF cannot show the CPU speed either.
> > >
> > > Can you please roll back this changes (if it was pushed in)?
> > >
> >
> > OK, this patch mentions EmulatorPkg in the commit log but actually
> > modifies MdeModulePkg, and it was pushed during the hard freeze.
> >
> > Seriously, how did this happen? I would expect everyone with commit
> > rights to the repository to be aware of the stable tag rules and
> > release cadence.
>
> This patch is like a bug fix.
How so? Why does it qualify as a bug fix that can be applied during
the hard freeze period?
> But, this patch changes the code in MdeModulePkg.
> It requires MdeModulePkg package maintainer and reviewer to review it.
> And, it impacts the different platforms. So, I also prefer to roll back this change.
>
Agreed.
> >
> >
>
next prev parent reply other threads:[~2019-06-04 13:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 6:45 [Patch V2] EmulatorPkg: don't diaplay the cpu current speed Zhiguang Liu
2019-06-03 6:51 ` [edk2-devel] " Ni, Ray
[not found] ` <15A49DA9FFA456B0.4546@groups.io>
2019-06-04 8:50 ` Ni, Ray
2019-06-04 11:53 ` Ard Biesheuvel
2019-06-04 13:40 ` Liming Gao
2019-06-04 13:41 ` Ard Biesheuvel [this message]
2019-06-04 14:19 ` Liming Gao
2019-06-05 1:10 ` Ni, Ray
2019-06-05 8:03 ` Laszlo Ersek
2019-06-05 14:31 ` Zeng, Star
2019-06-10 6:01 ` Wu, Hao A
2019-06-10 6:13 ` Yao, Jiewen
2019-06-10 6:20 ` Wu, Hao A
2019-06-10 7:16 ` Ni, Ray
2019-06-10 7:32 ` Wu, Hao A
2019-06-10 7:33 ` Ni, Ray
2019-06-10 7:37 ` Ard Biesheuvel
2019-06-10 8:07 ` Wu, Hao A
2019-06-10 10:50 ` Ard Biesheuvel
2019-06-11 15:19 ` Laszlo Ersek
2019-06-10 7:39 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_xdOxZm5V_mzbdQ2UGH22dMPV4JXPu3Vi1NoiFG1QEBQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox