From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=i6feay21;
 spf=pass (domain: linaro.org, ip: 209.85.166.179, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f179.google.com (mail-it1-f179.google.com [209.85.166.179])
 by groups.io with SMTP; Tue, 04 Jun 2019 06:42:06 -0700
Received: by mail-it1-f179.google.com with SMTP id n189so178592itd.0
        for <devel@edk2.groups.io>; Tue, 04 Jun 2019 06:42:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=TWIFcd2BvUHQ8USDA4QwzqMZEJyzPaCHEh9DkBqf/x4=;
        b=i6feay21TVC7XJ2yZ0fB72tQ+KfcQvs815PabvPM5BOY0GJuWFgBK2qzh/tTSuKf/q
         iSv/yNcQjCAe3evyZp1EgURKacey8iAJ4xG/iIZ6Qpu0qeiwT1ri0pKKrmGUoLMjWOH3
         dSGarb5vlsP06coBq7eojbl+/9GznPoZ2pIBR560NRIWRLWVd0yzZsVI4mQhbkbyMpor
         i7EXBRDg5bVb90k7aiqdH3/Gr+/LgAY/tAo96RTkL4vyRbHfZq+MQdmYD3kcGjt1CJ7S
         OZHadFUSjef4Q+SOGqi34BZ/0NifRdECKVI/HiYRpg+G70W2aypbmvpWz7bQS2H6iRw8
         zKyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=TWIFcd2BvUHQ8USDA4QwzqMZEJyzPaCHEh9DkBqf/x4=;
        b=RIJDF6BUtSxI1BEH/3OtSWZZG8GK+1dT1pOu/ELEINsV9RAM1x+xDstbQOeFyp+l/+
         aRlOQ8LHCURFEIOCJ+MLGSJekH5eKNIHNqwsHpw/48fybfLG8vdtHrIQ4DpKbmZsrEfE
         BFPFthrhAvEdKsd8BLeGC0jdBdFFo7up8uTmDBPKuMzKlypjjFjsXBJk9FsBfHLJr34I
         kImurr5PTNAsO9DgPc6XKq5pJjyqv6czgsO5ZZzzP9FtJ4VOquHXYm+Pn++033GpKpUU
         5pl1+SzwVU3sx5ySXlXfbFfEj4fTQuvV1Br8VdMALd88fz7sZcJrzkb88zLJmyRZ4Bqp
         9FOw==
X-Gm-Message-State: APjAAAXfg9GqxWosyMfKfsRJpvPYs2VUHhUzrOglEh2Qftg3JmfLrB0n
	W7VO/UmozSn9znvrLyeFPXrAimwGD0fpnKJUAjd0BQ==
X-Google-Smtp-Source: APXvYqxz6ZO9CBM1S94Jdwu4is1WgXHlE0f8ErtlZM8ah55gJW7ZgK2lyFS36HcAOWb84mT4QamocJE6mR9S9I+J0X8=
X-Received: by 2002:a24:740f:: with SMTP id o15mr5747405itc.76.1559655725803;
 Tue, 04 Jun 2019 06:42:05 -0700 (PDT)
MIME-Version: 1.0
References: <20190603064503.20460-1-zhiguang.liu@intel.com>
 <15A49DA9FFA456B0.4546@groups.io> <734D49CCEBEEF84792F5B80ED585239D5C18F543@SHSMSX104.ccr.corp.intel.com>
 <CAKv+Gu90P0GwbjQNDUTQAp1+s3Fpi6h-GbHHnbXzjbPdYuwycQ@mail.gmail.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E46B8D2@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46B8D2@SHSMSX104.ccr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 4 Jun 2019 15:41:52 +0200
Message-ID: <CAKv+Gu_xdOxZm5V_mzbdQ2UGH22dMPV4JXPu3Vi1NoiFG1QEBQ@mail.gmail.com>
Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Ni, Ray" <ray.ni@intel.com>, 
	Leif Lindholm <leif.lindholm@linaro.org>, Laszlo Ersek <lersek@redhat.com>, 
	"Kinney, Michael D" <michael.d.kinney@intel.com>, "Liu, Zhiguang" <zhiguang.liu@intel.com>, 
	"Justen, Jordan L" <jordan.l.justen@intel.com>, Andrew Fish <afish@apple.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 4 Jun 2019 at 15:40, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> > Sent: Tuesday, June 4, 2019 7:53 PM
> > To: edk2-devel-groups-io <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
> > <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> >
> > On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni@intel.com> wrote:
> > >
> > > Zhiguang,
> > > I made a mistake here.
> > > I thought you changed the EmulatorPkg to not display the CPU speed
> > > but actually what you changed impacts all platforms.
> > > With this change, OVMF cannot show the CPU speed either.
> > >
> > > Can you please roll back this changes (if it was pushed in)?
> > >
> >
> > OK, this patch mentions EmulatorPkg in the commit log but actually
> > modifies MdeModulePkg, and it was pushed during the hard freeze.
> >
> > Seriously, how did this happen? I would expect everyone with commit
> > rights to the repository to be aware of the stable tag rules and
> > release cadence.
>
> This patch is like a bug fix.

How so? Why does it qualify as a bug fix that can be applied during
the hard freeze period?

> But, this patch changes the code in MdeModulePkg.
> It requires MdeModulePkg package maintainer and reviewer to review it.
> And, it impacts the different platforms. So, I also prefer to roll back this change.
>

Agreed.


> >
> > 
>