From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 07399211F887C for ; Tue, 26 Jun 2018 22:07:44 -0700 (PDT) Received: by mail-it0-x243.google.com with SMTP id l16-v6so4819961ita.0 for ; Tue, 26 Jun 2018 22:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XN52nxwArrJvM7nMqbgSksHudNvvPpB5fAlT+QPPkJ8=; b=bAjsIvLX4HeC0r90x99KCEN3sFJj7U1YLHyUTapfuikRW0vt1lGF2AsWvN17kuI74g BuH8vJSz98eVA/ub2qPRdRxG5FZM4Suwr2hmB6Q3Mha9USYDsJyOOa05LjkxPeqKSpRN jHS01zelQvUcmebXbUvPm8t4wsUwZwJ8XtavE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XN52nxwArrJvM7nMqbgSksHudNvvPpB5fAlT+QPPkJ8=; b=O8EUPP7yMAXrXKnhRT2QtuCzpCpUbRMPb5WtzLaTWh/hFRoTSbYxmKROT82hzFlTNv cVTl05Q4w5O+EtJcXyE/Xc3W3lSu9u3OSlsi3t8OqusU+Gx6rymG9f4EWnYRH0xUsa07 XfdEP6YAckACixUTq1RWM+JEBvG0mEHqfNuPQcvuoqlJgSVa4W1fJVTaA06+6EAQQbEC ZUXo8M6EzAz+acoVjj6v87ZcN8tsYECpilatfKWdoTwTOlRewn57b4R3F/yYmAxUuAj9 WCqf1DCBHHipieswkcOvvhUJt48EdINnceaIH8J4fdWHgw6XHnR7/SkpTHu/hH+yOHLh eaFQ== X-Gm-Message-State: APt69E2I02EyWTL1OSQQVJbl4pxz/VtNUyFBmXh62qyOI1ORgRzm1LVp BBZaclgEKRaDTqJYosAsr5YAp1w3PE2O1Jqrzr/iZw== X-Google-Smtp-Source: AAOMgpdGmOe+dH5s6PVz6b4Jk5nhB+bkUY0UxsH1KV7tBQ19DnY/LqmUUeQd2JNHty6uusofiAUYI+TQ2dI3xSMJ72c= X-Received: by 2002:a02:2422:: with SMTP id f34-v6mr3753201jaa.2.1530076063911; Tue, 26 Jun 2018 22:07:43 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Tue, 26 Jun 2018 22:07:43 -0700 (PDT) In-Reply-To: References: <20180623005740.43200-1-christopher.co@microsoft.com> <20180623005740.43200-2-christopher.co@microsoft.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29D4B5@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29D7EF@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29DED3@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 27 Jun 2018 07:07:43 +0200 Message-ID: To: Chris Co Cc: "Gao, Liming" , Leif Lindholm , "edk2-devel@lists.01.org" , Charles Garcia-Tobin Subject: Re: [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL Toolchain support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 05:07:45 -0000 Content-Type: text/plain; charset="UTF-8" On 27 June 2018 at 06:14, Chris Co wrote: >> -----Original Message----- >> From: Ard Biesheuvel >> Sent: Tuesday, June 26, 2018 11:52 AM >> To: Chris Co >> Cc: Gao, Liming ; Leif Lindholm >> ; edk2-devel@lists.01.org; Charles Garcia-Tobin >> >> Subject: Re: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL >> Toolchain support >> >> On 26 June 2018 at 20:42, Chris Co wrote: >> > >> > >> >> -----Original Message----- >> >> From: Ard Biesheuvel >> >> Sent: Tuesday, June 26, 2018 1:22 AM >> >> To: Gao, Liming >> >> Cc: Chris Co ; edk2-devel@lists.01.org; >> >> Leif Lindholm ; Charles Garcia-Tobin >> >> >> >> Subject: Re: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL >> >> Toolchain support >> >> >> >> On 26 June 2018 at 06:40, Gao, Liming wrote: >> >> > Chris: >> >> > Here is the example usage. You can add below [BuildOptions] in >> >> > your >> >> platform DSC. Then, it will use override ASL path and flag. >> >> > >> >> > [BuildOptions] >> >> > *_*_*_ASL_PATH == C:\Asl\asl.exe >> >> > *_*_*_ASL_FLAGS == /MsftInternal >> >> > *_*_*_ASL_OUTFLAGS == /Fo= >> >> > >> >> >> >> I strongly prefer this over adding a new MS specific toolchain definition. >> >> >> > >> > Thanks Liming! I added these overrides and they works great. Since we >> can do platform dsc overrides, I also used it to override the objcopy_path >> and symrename_path which was the other change we needed for building >> on Windows. >> > GCC:*_*_*_OBJCOPY_PATH = noop >> > GCC:*_*_*_SYMRENAME_PATH = noop >> > >> > Ard, I agree this is the better method. We can drop this patch in favor of >> the platform dsc overrides. >> > >> > Leif, I tested GCC7.3 arm-eabi and ran into build errors. Found out >> > this was an issue encountered before: >> > >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs. >> > >> linaro.org%2Fshow_bug.cgi%3Fid%3D2909&data=02%7C01%7CChristop >> her.C >> > >> o%40microsoft.com%7C0960f252b3dd4f2e79ed08d5db95e411%7C72f988bf86 >> f141a >> > >> f91ab2d7cd011db47%7C1%7C0%7C636656359185404698&sdata=ZEt9sY >> %2F94us >> > UaTDkvHQrzkkIiaXTPPfWqMlPh2NK%2BgM%3D&reserved=0 >> > I made a couple modifications to Trim.py to fix the errors and was able to >> successfully build and test. Will submit the fix for review and update our >> toolchain to use GCC7.3 with GCC5 profile. >> > >> >> That is good news. >> >> So I guess we're all set to start incorporating this platform. >> >> Any clue whether there is also a device tree available for this platform? I >> would prefer it if we could make the firmware OS agnostic, rather than have >> Windows-only and Linux-only platforms in the edk2-platforms tree. > > We did not include a device tree since Windows does not comprehend device trees, however all of our ARM platforms have a u-boot config which generates a device tree and boots linux. > OK, good to know. I think Leif already asked the same question, but if he or I could get our hands on such a platform, we could work together to ensure that both Windows and Linux can boot from the same firmware image.