From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::135; helo=mail-it1-x135.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x135.google.com (mail-it1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 92387211982D9 for ; Mon, 3 Dec 2018 06:04:54 -0800 (PST) Received: by mail-it1-x135.google.com with SMTP id h193so8613574ita.5 for ; Mon, 03 Dec 2018 06:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ODHkjBddIIcQbCBY3+LnKN/0fBSVx1ycoIb8CgHkdyE=; b=NEhztiitmZ4vZ3bH1Gma6Fm7Be8eIToEl/gz8ox/o2U81N/IFNdIidStRtu3GzI/7T Cn0tazway/DSWFwIS1FaVwoKPb3C6Zi2JdIi99F0pH2Kep4+t0inpMjhZUtbZ0nF0wIn iZJKollqINzi5keoTRplf8yaS0MlNp3EqDsc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ODHkjBddIIcQbCBY3+LnKN/0fBSVx1ycoIb8CgHkdyE=; b=ig0ZV28WmeMb7jslTxSCfdBvjr905KgiAKI0RbRziGO/KMRCN6lHdH4Dg04KwFUzZq ZVE5fq7cYRvZ1a084utckYCyB9zuKHPY21dD5lGp6LzBQZYVeCzOimSQcbe6/XAjiCaW iJKaOttwyG8zQgrPrx0ICTvYEdJYIGqLbNyNzOgNIAG4TM0SOV5f8nhSj7vu/Pz2eBPN N3w6Zl+OiFNVJkbqlqN6SWquwFS6k3U/fC8tqwlNhV6lsoRpCV3zVyOe/4C1ov7uFMXD tRnSaPee8MEFCArRNQ+WNDwTKsGR/4RJcP3O/GUzIOklYsshKGWWg3i06iahpBOY0ETn mS3Q== X-Gm-Message-State: AA+aEWZxtRQmkT9pnOrTURUi9Bv+fm6selvBXtOEvdehSii66aVfxeEs FiMqYDyR2vUQZ3obAqEZMsSxG6kFWzo1uSC1egOCgg== X-Google-Smtp-Source: AFSGD/XFsZT7jxASN0r91M+K6aV3NlOXZpm7qkQ8aGWzrmKOGnWdbWEzyBpAnniLdRT+gB95bIrHfeXU0rtmQou/0eo= X-Received: by 2002:a24:edc4:: with SMTP id r187mr8674222ith.158.1543845893284; Mon, 03 Dec 2018 06:04:53 -0800 (PST) MIME-Version: 1.0 References: <2EF700E0-AF34-498C-B740-406BE5BA0839@apple.com> <80adb57c-ffa2-d5d6-5d14-eeb9513a1328@redhat.com> <8ea4f231-a264-cd85-1392-9fabe77613f5@redhat.com> <3cf90372-14d4-3726-eab3-ab1e87836694@redhat.com> <7fb58f58-30d6-6710-7488-e35ceba69ae1@redhat.com> In-Reply-To: <7fb58f58-30d6-6710-7488-e35ceba69ae1@redhat.com> From: Ard Biesheuvel Date: Mon, 3 Dec 2018 15:04:40 +0100 Message-ID: To: Laszlo Ersek Cc: Udit Kumar , Andrew Fish , Leif Lindholm , Ruiyu Ni , "edk2-devel@lists.01.org" , "Zeng, Star" Subject: Re: Help on boot manager 'Boot Manager Menu' and direct boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2018 14:04:54 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 3 Dec 2018 at 14:45, Laszlo Ersek wrote: > > On 12/03/18 11:03, Udit Kumar wrote: > > Hi Laszlo > > > >> Are you using the latest edk2? > > Yes, when I hit the bug, first step was to move to latest edk2. But this didn't helped. > > > > I am not sure, why we are keeping PL011 Fifo mode off in default configuration. > > Sorry, I don't know: although the subject logic has gone through several > updates over time, the default that you point out seems to go back to > commit 051e63bb551a ("ArmPlatformPkg/PL011Uart: Allowed to change UART > settings in its initialization function", 2012-02-29). And that commit > doesn't explain the default. > The default setting for gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth is 1 not 0, and so you will end up with a 1 character FIFO setting. I wonder if we could improve PL011UartInitializePort () in PL011UartLib to deal with this better. Note that this also affects platforms that can switch between DT and ACPI boot: the same PL011 is described as a 'dumb' SBSA uart in the latter case, and so it is up to the firmware to configure the UART FIFO correctly, or you will not be able to use the UART under the ACPI OS.