From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Daniil Egranov <daniil.egranov@arm.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle
Date: Fri, 23 Sep 2016 08:58:25 +0100 [thread overview]
Message-ID: <CAKv+Gu_yN91-rA33Qg4hLr0-F=FmFRs18g1jCKaQ779-d5KRwg@mail.gmail.com> (raw)
In-Reply-To: <1474583581-41663-3-git-send-email-daniil.egranov@arm.com>
On 22 September 2016 at 23:33, Daniil Egranov <daniil.egranov@arm.com> wrote:
> The fix handles the PCI Dual Address Cycle Attribute case. It allows
> drivers using PCI DAC run on Juno.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Daniil Egranov <daniil.egranov@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> .../ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c
> index 10a4575..72d0915 100644
> --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c
> +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c
> @@ -518,11 +518,14 @@ PciRbMap (
>
> PCI_TRACE ("PciRbMap()");
>
> - if (Operation == EfiPciOperationBusMasterRead) {
> + if (Operation == EfiPciOperationBusMasterRead ||
> + Operation == EfiPciOperationBusMasterRead64) {
> DmaOperation = MapOperationBusMasterRead;
> - } else if (Operation == EfiPciOperationBusMasterWrite) {
> + } else if (Operation == EfiPciOperationBusMasterWrite ||
> + Operation == EfiPciOperationBusMasterWrite64) {
> DmaOperation = MapOperationBusMasterWrite;
> - } else if (Operation == EfiPciOperationBusMasterCommonBuffer) {
> + } else if (Operation == EfiPciOperationBusMasterCommonBuffer ||
> + Operation == EfiPciOperationBusMasterCommonBuffer64) {
> DmaOperation = MapOperationBusMasterCommonBuffer;
> } else {
> return EFI_INVALID_PARAMETER;
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-09-23 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 22:32 [PATCH 0/2] Juno PCI fixes Daniil Egranov
2016-09-22 22:33 ` [PATCH 1/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Remove calls to ArmDmaLib Daniil Egranov
2016-09-23 7:57 ` Ard Biesheuvel
2016-09-23 16:20 ` Daniil Egranov
2016-09-23 16:21 ` Ard Biesheuvel
2016-09-23 21:47 ` Daniil Egranov
2016-09-24 12:05 ` Ard Biesheuvel
2016-09-22 22:33 ` [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle Daniil Egranov
2016-09-23 7:58 ` Ard Biesheuvel [this message]
2016-10-12 8:37 ` Ryan Harkin
2016-10-12 8:41 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_yN91-rA33Qg4hLr0-F=FmFRs18g1jCKaQ779-d5KRwg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox