From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 57E9F1A20AE for ; Fri, 23 Sep 2016 00:58:26 -0700 (PDT) Received: by mail-io0-x231.google.com with SMTP id m186so110523825ioa.2 for ; Fri, 23 Sep 2016 00:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OmtSEABf31aYQKmnkJ/z+XvJoCTJNu7UxpwDB8LW/xs=; b=Pkl05JUw4MhA+XuYWEqy0EZEHv1pACBKhgRVOJqmEPfP9vnue8T9VdWVWrsmIWtr4h YEvVCsp8sd6kwHxcofv6Qbe6HHoSlXRhJ2XQa0vS6MvofD2kQ/2OhJEh2pxz0foNlb3U t2Yh2AC0yjA5nwMyIrA7oDaEPT1hCtbwfvJo8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OmtSEABf31aYQKmnkJ/z+XvJoCTJNu7UxpwDB8LW/xs=; b=JrnBF/qWU8oYpdAuTpTeFicUOv9//LZNPBZm32c587jzkRa/5LrnNOIAWVh8VaA1Dh 3+ASB6/qzPSMynPJysVXilWiKiCGSMhuFZkkRCr5vtqlnKirZqZXUYJEioge09OcjOFF VxtHgF1Q2/Z6coh5IwP3ap0v7KxrGECLG7d/IIoVD4Vseet1MkqGUgRREWZie1+3rz4f FqfqThzMWwo5jhhGlZSxhqrNllNvPnnwzm4AS6d3dE2Pg/q78lh2nTiiy0XkAZXdjlYe QK9Vv5RwELOIKeU+gqWkkBpcN+uo1STlwirpAbu9rIs+ULPDtrOR1pVeAp7dQxrPkWau rPYg== X-Gm-Message-State: AE9vXwP79UlS8xfaOzBWeUkJXIWFTyryJda6B6Dy2vNW30+jubaGsUH8GtN/c5W9nrOQQEGUTIHbKa0mimB4+yEL X-Received: by 10.107.133.17 with SMTP id h17mr8947643iod.148.1474617505730; Fri, 23 Sep 2016 00:58:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Fri, 23 Sep 2016 00:58:25 -0700 (PDT) In-Reply-To: <1474583581-41663-3-git-send-email-daniil.egranov@arm.com> References: <1474583581-41663-1-git-send-email-daniil.egranov@arm.com> <1474583581-41663-3-git-send-email-daniil.egranov@arm.com> From: Ard Biesheuvel Date: Fri, 23 Sep 2016 08:58:25 +0100 Message-ID: To: Daniil Egranov Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 07:58:26 -0000 Content-Type: text/plain; charset=UTF-8 On 22 September 2016 at 23:33, Daniil Egranov wrote: > The fix handles the PCI Dual Address Cycle Attribute case. It allows > drivers using PCI DAC run on Juno. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Daniil Egranov Reviewed-by: Ard Biesheuvel > --- > .../ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c > index 10a4575..72d0915 100644 > --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c > +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c > @@ -518,11 +518,14 @@ PciRbMap ( > > PCI_TRACE ("PciRbMap()"); > > - if (Operation == EfiPciOperationBusMasterRead) { > + if (Operation == EfiPciOperationBusMasterRead || > + Operation == EfiPciOperationBusMasterRead64) { > DmaOperation = MapOperationBusMasterRead; > - } else if (Operation == EfiPciOperationBusMasterWrite) { > + } else if (Operation == EfiPciOperationBusMasterWrite || > + Operation == EfiPciOperationBusMasterWrite64) { > DmaOperation = MapOperationBusMasterWrite; > - } else if (Operation == EfiPciOperationBusMasterCommonBuffer) { > + } else if (Operation == EfiPciOperationBusMasterCommonBuffer || > + Operation == EfiPciOperationBusMasterCommonBuffer64) { > DmaOperation = MapOperationBusMasterCommonBuffer; > } else { > return EFI_INVALID_PARAMETER; > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel