Re: [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Fri, 27 Mar 2020 at 14:06, Pete Batard <pete@akeo.ie> wrote:
>
> Incidentally, this is not an [edk2-platform] patch, as the subject line
> from previous mail seemed to indicate, but an [edk2] patch.
>

Do we have a user for this?

>
> On 2020.03.27 13:01, Pete Batard wrote:
> > ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing
> > 2 of the 3 reserved bytes that are defined at the end of the
> > GICC structure for 6.0.
> >
> > Add a new macro to initialise the new field.
> >
> > Signed-off-by: Pete Batard <pete@akeo.ie>
> > ---
> >   EmbeddedPkg/Include/Library/AcpiLib.h | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h b/EmbeddedPkg/Include/Library/AcpiLib.h
> > index 5c6e2075de79..57d7bd595584 100644
> > --- a/EmbeddedPkg/Include/Library/AcpiLib.h
> > +++ b/EmbeddedPkg/Include/Library/AcpiLib.h
> > @@ -64,6 +64,14 @@
> >       {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE}         \
> >     }
> >
> > +#define EFI_ACPI_6_3_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags, PmuIrq,    \
> > +    GicBase, GicVBase, GicHBase, GsivId, GicRBase, Efficiency, SpeOvflIrq)           \
> > +  {                                                                                  \
> > +    EFI_ACPI_6_0_GIC, sizeof (EFI_ACPI_6_0_GIC_STRUCTURE), EFI_ACPI_RESERVED_WORD,   \
> > +    GicId, AcpiCpuUid, Flags, 0, PmuIrq, 0, GicBase, GicVBase, GicHBase,             \
> > +    GsivId, GicRBase, Mpidr, Efficiency, EFI_ACPI_RESERVED_BYTE, SpeOvflIrq          \
> > +  }
> > +
> >   #define EFI_ACPI_6_0_GIC_MSI_FRAME_INIT(GicMsiFrameId, PhysicalBaseAddress, Flags, SPICount, SPIBase) \
> >     { \
> >       EFI_ACPI_6_0_GIC_MSI_FRAME, sizeof (EFI_ACPI_6_0_GIC_MSI_FRAME_STRUCTURE), EFI_ACPI_RESERVED_WORD, \
> >
>