From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web11.49228.1585573615657197887 for ; Mon, 30 Mar 2020 06:06:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=y5h8R8ME; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id 31so21519835wrs.3 for ; Mon, 30 Mar 2020 06:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/E+dDoVGfzuX9KRERbdaeRNodTpGZfJA4Hj/iUPiaXc=; b=y5h8R8MEVeKtuPrWuFcgPaskcIbKUZcFkZe65keFqXgmT7BTP1PGbkVpdZa/6m/HNh O+ERRc+ChqCNcT8ljljpMsFMGD7hjPHnlPkypo9BxemLu1SVuqCr3evW3UZq2UwX477s /3Hb2KIWswWcTZ91XPfQORvHmJyi5R9fkG/GWUW/KNsx39rltxobz/xvsMKTulU9gSn9 WveSxlOQ0kttiniJ8pG3+i2wKAhFV4hvsBQ8IUmB3lQZCyS1U+PWZkCG0yvpLLpmc5fW QBLGyimtKkLbCmST/suH5Cufnk26tbOq6lekmlPutcD2re9FLz5uM3wviyAX2EnTabof jwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/E+dDoVGfzuX9KRERbdaeRNodTpGZfJA4Hj/iUPiaXc=; b=LSR9YK55SWwmlabDm4v03MucCfd9FZ2zXD13PAmcmze4yljWW3M9mGU2yYnAfHnTqG KUD7QdTf0claP6fxmgelBroNg2H7o2oQ5T9ZA3uCzlNFtU5MSTXRp7Vv5Lq6uA393GLu A+mg+r4ftS/+py7IlpZPUgqWsNkmrenIyTMcOwKtyDkPu+R752FTVApJwSQ4F2pT7AmL rFYhmUCJPA0ognI0pTCz2dJ5CLE16YEiAUxgZ3sseoXQMhvwXyUZKMbCAxGGrHLefK8k iTDGlmhpmo8/KPZaEjjRq+6ZkZLZW5TN2IgfTDlBsLi9+k5AN32T9HIb+pMK16wu2clO 5qvA== X-Gm-Message-State: ANhLgQ3UOHMsrNHoi3GmuX/ODxSaeoZ6+cdkdx5dLE7gmR7Y0BHrmdKN KOVQSwmWtRVhRrQnBFFgqxA8iThmVguocGj/hGo7Sg== X-Google-Smtp-Source: ADFU+vsU39VlD/7AkAbDf3IRen2yqkll6FBW3l4COofjigGgc+HiUrTAalgRfOCvT5FCsVLeOLzssKlR00YjubRwSp8= X-Received: by 2002:adf:e487:: with SMTP id i7mr14720283wrm.151.1585573614231; Mon, 30 Mar 2020 06:06:54 -0700 (PDT) MIME-Version: 1.0 References: <20200327130117.11304-1-pete@akeo.ie> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 30 Mar 2020 15:06:43 +0200 Message-ID: Subject: Re: [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3 To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Fri, 27 Mar 2020 at 14:06, Pete Batard wrote: > > Incidentally, this is not an [edk2-platform] patch, as the subject line > from previous mail seemed to indicate, but an [edk2] patch. > Do we have a user for this? > > On 2020.03.27 13:01, Pete Batard wrote: > > ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing > > 2 of the 3 reserved bytes that are defined at the end of the > > GICC structure for 6.0. > > > > Add a new macro to initialise the new field. > > > > Signed-off-by: Pete Batard > > --- > > EmbeddedPkg/Include/Library/AcpiLib.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h b/EmbeddedPkg/Include/Library/AcpiLib.h > > index 5c6e2075de79..57d7bd595584 100644 > > --- a/EmbeddedPkg/Include/Library/AcpiLib.h > > +++ b/EmbeddedPkg/Include/Library/AcpiLib.h > > @@ -64,6 +64,14 @@ > > {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE} \ > > } > > > > +#define EFI_ACPI_6_3_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags, PmuIrq, \ > > + GicBase, GicVBase, GicHBase, GsivId, GicRBase, Efficiency, SpeOvflIrq) \ > > + { \ > > + EFI_ACPI_6_0_GIC, sizeof (EFI_ACPI_6_0_GIC_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ > > + GicId, AcpiCpuUid, Flags, 0, PmuIrq, 0, GicBase, GicVBase, GicHBase, \ > > + GsivId, GicRBase, Mpidr, Efficiency, EFI_ACPI_RESERVED_BYTE, SpeOvflIrq \ > > + } > > + > > #define EFI_ACPI_6_0_GIC_MSI_FRAME_INIT(GicMsiFrameId, PhysicalBaseAddress, Flags, SPICount, SPIBase) \ > > { \ > > EFI_ACPI_6_0_GIC_MSI_FRAME, sizeof (EFI_ACPI_6_0_GIC_MSI_FRAME_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ > > >