From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=s0bgEizc;
 spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193])
 by groups.io with SMTP; Fri, 17 May 2019 09:12:05 -0700
Received: by mail-it1-f193.google.com with SMTP id i10so12858594ite.0
        for <devel@edk2.groups.io>; Fri, 17 May 2019 09:12:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=rC3YKaocSW1Cid0CX9edXzI0uAxHeWvop2Oc+9Kx5Pw=;
        b=s0bgEizc1XXStixu8yqU8d39rbTXMcQkfnwhtyrPPhJW/CK0CIp8/4mjDR9rfzU8ZE
         U9n6psG0NWvUUn2JmPxcf+tFX9PkP1jNIagvAj14cxfMNlYkZ/MkJYYAh4jaHxCF3j5Q
         RtBs+I+Xyfe/BzzOvRbT5kH36DSoLVD8J4CJBimaTSUWnsbfkxFWJKAIXtH5drR9wWM6
         dNrcf818naifgatulArZ1RhUO38k902GdDiQJlJ9uG4wnZu4NFTETbGZB1xeaFV1PQyj
         epqelfZnnZrlE08hnS/tuLJ7uFCjgiRE0JgPp2Xzh6gsdqP+BS/FjMseqIUhNKjvfrRf
         q1HQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=rC3YKaocSW1Cid0CX9edXzI0uAxHeWvop2Oc+9Kx5Pw=;
        b=XiRFo7D6Hk6QUZqQg8pwwz/IXWU1gb+gDMZNQxKJwyIjRA/g2Wj5Ljc3c6AdQjYwVt
         Pg8q1OMd2Qgut4o/7Qt9PfQd3IysLS/GUcMVB995nir4J8PWD4p/o6C/iQdyz5rCDP4y
         VJy92kQnxngPjPfqBORO8Ccy2jweyaLWsLpQhyBxE5VApFqyZdBydQFcG5q9eUeurWhR
         w8gh+2MP5vCzgIA4l9LPEYR6oE1WWSg68QwHgzGAjRG3zSNgQYRiJk/gTA5hvKj7c866
         jXh/rDP6nN+wrqFRDz3w9W0C3Ti7j62W71aLCAeOSnXn22SgRQfjux6zbEmiPn7LRouS
         Povg==
X-Gm-Message-State: APjAAAUCgTlDqBi3oxzhHMHakJ65PJUtXRSbh7Ly4Q/kwEGmpS6AgWwY
	ZJWXzrGY2tnWCB1DJOQXyP8PeWR0y3lzU6GO4XFLEw==
X-Google-Smtp-Source: APXvYqyACmgKkwzyhuWqiOY1aQl9zjbKLvBVTYvpK4owq3TzWPiKUmU075QT6cBHRG0k99SMvFY2BS4IKo6zsamGweo=
X-Received: by 2002:a24:910b:: with SMTP id i11mr16228719ite.76.1558109524268;
 Fri, 17 May 2019 09:12:04 -0700 (PDT)
MIME-Version: 1.0
References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-5-hao.a.wu@intel.com>
 <CAKv+Gu9Abk5JOMTEx_h64VPxYv1PjvHOwR+pUsFWUABXxfZrLA@mail.gmail.com>
 <20190517160257.7d4g2nj2gradcel7@bivouac.eciton.net> <CAKv+Gu--ryXmiJbfBqWBP6Hak+1dBk7s8OBDo8B+5iwKCjMFtQ@mail.gmail.com>
In-Reply-To: <CAKv+Gu--ryXmiJbfBqWBP6Hak+1dBk7s8OBDo8B+5iwKCjMFtQ@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 18:11:52 +0200
Message-ID: <CAKv+Gu_yWK51ywbjq=rpQz0=O5-_ShLdoU5FzHHE8vpBw5KsWw@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 02/16] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg
To: Leif Lindholm <leif.lindholm@linaro.org>, Andrew Fish <afish@apple.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, "Wu, Hao A" <hao.a.wu@intel.com>, 
	Michael D Kinney <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

(adding Andrew)

On Fri, 17 May 2019 at 18:05, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 17 May 2019 at 18:03, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > On Fri, May 17, 2019 at 05:24:36PM +0200, Ard Biesheuvel wrote:
> > > On Tue, 14 May 2019 at 04:08, Wu, Hao A <hao.a.wu@intel.com> wrote:
> > > >
> > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
> > > >
> > > > This commit will update the DSC file to consume the ReportStatusCodeLib
> > > > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the
> > > > one in IntelFrameworkModulePkg.
> > > >
> > > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are
> > > > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus,
> > > > there is no functional impact for this commit.
> > > >
> > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> > >
> > > This platform does not have a status code router, so should we not
> > > simply switch to BaseReportStatusCodeLibNull.inf here?
> >
> > Err, yeah, good point. Slight case of tunnel vision.
> >
>
> Actually, I only just figured out that PrePiLib *does* have a status
> code router.
>
> This is slightly dodgy (as is PrePi in general) since it uses a HOB to
> expose function pointers into the SEC module, but from the protocol
> client pov, it is just a status code router as any other.
>
> Note that my comment still applies to other platforms that don't use
> PrePi (the Styx ones)

... it is not entirely clear to me though how the GUID hobs
representing protocol GUIDs get installed into the protocol database.