From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2549721A1099A for ; Tue, 12 Dec 2017 10:15:22 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id f143so556664itb.0 for ; Tue, 12 Dec 2017 10:20:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IRBZAtdN2yLvvfZqLKlY/kF3M+ckOqiqQnzvSAm+DLI=; b=YtQpnNYwZ8I7uoav+pJkL/POkkGtvBawOYQOalyXft7hL6bWSRK6RZ6EzOhHy1v4QX s8BouDe5kJbEOypOPLQFP52Xdm0xw1ctP9ot4KQ5K4fDGbwS6MqVbb0p2mY7+rZYoiTA H1KhasabJ0tuAMVxTBLjJzNW8jDX/0FlMuGQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IRBZAtdN2yLvvfZqLKlY/kF3M+ckOqiqQnzvSAm+DLI=; b=YNr1GyILRBLU8QERaSSy3LjMisN/NIZelX8cLMxVPjM0nGcs1V1cmq/zkSV7cDtPe7 h0R+KVFM9mCHxQn+j7TdhHAqgxoc5+AynRpWD9rwA6n6PTBgYeFWlWTFCrtbaNxECS+/ t7j3LwZXOZYMzrT124eNn/WrIDgTRXV0aEdliDT2XHO8LKdsy9ijzjv2mHn33S6nqoVO hI3VF/3QBo0XEq/INjbyZXEEbMYZAL9RfkZ78Ab68azZI56AQiEG7EeD9/UtokrYfMbQ iIO9xnsvKDkQgKFNQg6+k/o1nWd7mNFWNhPIFAcjKsFIAvEyNvKwPFhQoLr1LdeG5Efc mCuA== X-Gm-Message-State: AKGB3mK3MIigzKb/DT3semFfdWRZrlRRJSTGw1NXn6fB+uWpx32n23Tb wE4Mf4yYEvm1slu7MBeCB3UaGUyhUFyD8IfNywO1RA== X-Google-Smtp-Source: ACJfBoubh+ovWiXLcW14czi7CI/U6lFqyQhXYxQSYuo2uRzKx2LLgq0MJIbJc4ujkliZ5IPW4uhQ/bSDwtaDf4DOFHE= X-Received: by 10.107.174.222 with SMTP id n91mr6213043ioo.43.1513102800488; Tue, 12 Dec 2017 10:20:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Tue, 12 Dec 2017 10:20:00 -0800 (PST) In-Reply-To: <20171212181719.bp4g56wdcnt56vtj@bivouac.eciton.net> References: <20171212103807.18836-1-ard.biesheuvel@linaro.org> <20171212103807.18836-3-ard.biesheuvel@linaro.org> <20171212181719.bp4g56wdcnt56vtj@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 12 Dec 2017 18:20:00 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Masami Hiramatsu Subject: Re: [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 18:15:22 -0000 Content-Type: text/plain; charset="UTF-8" On 12 December 2017 at 18:17, Leif Lindholm wrote: > On Tue, Dec 12, 2017 at 10:38:01AM +0000, Ard Biesheuvel wrote: >> Expose the contents of the .DSC macro BUILD_NUMBER via the >> PCD gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString (if > 1), >> and as the FMP system firmware version (for capsule update). >> >> Also, set the firmware vendor to 'Linaro Enterprise Group', to >> distinguish our builds from builds by other parties. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 8 +++++++- >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 1 + >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 6 ++++-- >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 8 +++++++- >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 1 + >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 6 ++++-- >> 6 files changed, 24 insertions(+), 6 deletions(-) >> >> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >> index 8fbd7b2d908f..5ec26f9cdd34 100644 >> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >> @@ -26,6 +26,7 @@ [Defines] >> BUILD_TARGETS = DEBUG|RELEASE >> SKUID_IDENTIFIER = DEFAULT >> FLASH_DEFINITION = Platform/Socionext/DeveloperBox/DeveloperBox.fdf >> + BUILD_NUMBER = 1 >> >> [BuildOptions] >> RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 >> @@ -222,7 +223,7 @@ [PcdsFeatureFlag] >> gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE >> >> [PcdsFixedAtBuild.common] >> - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Linaro" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"Linaro Enterprise Group" > > Actually, could you just delete this Pcd and let it fall back to the > default value of "EDK II"? > Yes. But perhaps it makes sense to put $(FW_VENDOR) in there if it is defined, so we can set it at build time? I would like to have a way to put something in the FirmwareVendor field in the UEFI system table that can help us identify firmware builds done by Linaro.