From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 853BE210F48FA for ; Mon, 18 Jun 2018 11:05:15 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id 16-v6so13345748itl.5 for ; Mon, 18 Jun 2018 11:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0MrRJBVgq6P8xg3JrFPdC1K7yY19G8rYwW69A0RAjMk=; b=dROzUTZ6Ug5DXLDLExkKV9Ia/B9XZY47jdTzSVlqHNaJdRD+c8X9slNJSWUzG9Bati EX9l/1dtBfMiQBxMtRWfhpLR9ZBYgCYFjbharZcEA3qL8YawMUPGWZRVx64DmbHuo9dv mf/ec1RjPdu7SlC4QkBex++xU7Gs/n0UA5Hm0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0MrRJBVgq6P8xg3JrFPdC1K7yY19G8rYwW69A0RAjMk=; b=pPpRmwLyxdQrXrbXeLtkF9L0cLUhihBbmHSnccC1gmrCXnnUp4x3pTwZwjwZBWAT5h pg2XSbvSX4ZXASJ1pnbDOXIgfEYMY3E0W2umkJFHM0DGiATUf3Q29jPwO141FQZjAFWm Pl04XJUl2cGNvM8PSAVHd2uxbQd/K6VlOrTF5H+xB4zdb6UYsv4rfljnSUzzEifGzX0G uKg4CpHVuwSnctOmiR8FtQyF3XiixmPRIrFvhUwJSln8ypA+c0jcplERdwnX6SnLyMng 9tk9ZbI0K2Otcfowc0TDSPR+5l4ESiPBQnarEJPdgrZ+8596nA+4PbTDS2a2LmGcuBiL nENg== X-Gm-Message-State: APt69E1scGqv0q0+NeNAdjCLzeHkMSkWKdOrsQlgJEZ9nLYr6TekSQ4W BvoSZ+lnSHWbvR/wWRwo0QRxXfE7NESwcVke5iCuqQ== X-Google-Smtp-Source: ADUXVKIJbbsxThX9QjU55XmttMTvUhjxJPJp/iBG/ogBfqFXhm0JuxrHitqelKVM94eTXs63KUMQTxwRgPwILoPNCEk= X-Received: by 2002:a24:e105:: with SMTP id n5-v6mr10500063ith.68.1529345114714; Mon, 18 Jun 2018 11:05:14 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 11:05:14 -0700 (PDT) In-Reply-To: <20180618174405.ntx73wrikd4wv44q@bivouac.eciton.net> References: <20180618173456.18050-1-ard.biesheuvel@linaro.org> <20180618174405.ntx73wrikd4wv44q@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 18 Jun 2018 20:05:14 +0200 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhu, Yonghong" Subject: Re: [PATCH] BaseTools/tools_def CLANG35: add NOOPT build target X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 18:05:15 -0000 Content-Type: text/plain; charset="UTF-8" On 18 June 2018 at 19:44, Leif Lindholm wrote: > On Mon, Jun 18, 2018 at 07:34:56PM +0200, Ard Biesheuvel wrote: >> Create the missing NOOPT target for CLANG35 (which is ARM and AARCH64 >> only), and align it with the other toolchains: NOOPT has optimizations >> disabled entirely (for source level debugging), DEBUG has some -O1 >> enabled just like CLANG38. > > Can I ask for a slight rewording above? > This changes the behaviour of CLANG35 DEBUG from -O0 to -O1. > (This is the correct thing, but the message isn't 100% clear on this.) > > Mention this, and: > Reviewed-by: Leif Lindholm > Given that CLANG35 is an ARM only toolchain definition, and the fact that my CI build is currently broken because of this, I went ahead and pushed this as 6d56ace57b91a48274fa9b9cfbc98065307584ae (with the changes requested by Leif) Thanks all. >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> BaseTools/Conf/tools_def.template | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template >> index ab57f9c706e3..11a79029b890 100755 >> --- a/BaseTools/Conf/tools_def.template >> +++ b/BaseTools/Conf/tools_def.template >> @@ -5675,8 +5675,9 @@ DEFINE CLANG35_AARCH64_CC_FLAGS = DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64 >> *_CLANG35_ARM_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANG35_ARM_TARGET) >> *_CLANG35_ARM_CC_XIPFLAGS = DEF(GCC_ARM_CC_XIPFLAGS) >> >> - DEBUG_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 >> + DEBUG_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O1 >> RELEASE_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz >> + NOOPT_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 >> >> ################## >> # CLANG35 AARCH64 definitions >> @@ -5697,8 +5698,9 @@ RELEASE_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(P >> *_CLANG35_AARCH64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANG35_AARCH64_TARGET) >> *_CLANG35_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS) >> >> - DEBUG_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 >> + DEBUG_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O1 >> RELEASE_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz >> + NOOPT_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 >> >> #################################################################################### >> # >> -- >> 2.17.1 >>