From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BB3842063E318 for ; Thu, 3 May 2018 04:44:42 -0700 (PDT) Received: by mail-io0-x243.google.com with SMTP id z4-v6so21260861iof.5 for ; Thu, 03 May 2018 04:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U9erust6C+TR6XxeLlEdYRJaUcix7GFFXuhH5DfJlRY=; b=XJkNFR0PuVWgDIiq/6UezC9esGewrgbKN7ufnefyxvCeueQ9S3dWGbxTilYrLQ3K73 r1KK5Eb4sZG1YMI5gPDk9dAL1elTEGu/8j0L+EHY3jQtcgn7rn7gAM8QBbz21VizQg5l UyPsSbfKeQETnnSHwYc+nXzNHDr8hXMZUmdig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U9erust6C+TR6XxeLlEdYRJaUcix7GFFXuhH5DfJlRY=; b=Xs/B+bJzz42K1BN0bZ3aXQsNCdBHT5opBjZEXXAXXPGX1h9QXbvnDtlecObniPSMhf atDxpE0yFCcngTqDcB06N3SETeesGNJqzn09B0zIR7rHnC1AlgdNHHB5K8p2vvy2Y6oO IJwXVkwjUHViJaYSGSRWXc5xvJpiT7om2+jtGv4qNxnVOkgniECUuTKIjIIXQt2fdk1G zaSu9hYWQFyrNUjJc0wcWZ9ktChcxcktXfZDGTmyUG8Ty3Fo/ZUzJPgm2V5cIyMP5Kbs bsbT8lmClpnZr2OW6z+Lfva/tANb3iprEdF2L862wp2Suor8rbA+DhSRPezsz51nPRaz Rk4g== X-Gm-Message-State: ALQs6tAOM3+S1ApsMyazAoAoT1a5Z7NTzfKf2UnOwLcxWavrdgxoZE3k t/kmqekw//kBFsem+WI+FWytW95v+/Rfhoe0J+OAWA== X-Google-Smtp-Source: AB8JxZofy2vtMoiEmdFFb7N3wqV6Kkb1RtrB70WwZxEr0h10dJRbozvLDbQjeMPgrq0r3cQ5szATV9foZxb7HVkM224= X-Received: by 2002:a6b:978e:: with SMTP id z136-v6mr25915546iod.60.1525347882032; Thu, 03 May 2018 04:44:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.134 with HTTP; Thu, 3 May 2018 04:44:41 -0700 (PDT) In-Reply-To: <1525339461-12432-1-git-send-email-alexei.fedorov@arm.com> References: <1525339461-12432-1-git-send-email-alexei.fedorov@arm.com> From: Ard Biesheuvel Date: Thu, 3 May 2018 13:44:41 +0200 Message-ID: To: Alexei Fedorov Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , Leif Lindholm , Matteo Carlini , Stephanie Hughes-Fitt , nd , Evan Lloyd , Sami Mujawar , Jeremy Linton , Alan Ott , Laszlo Ersek Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 11:44:42 -0000 Content-Type: text/plain; charset="UTF-8" (add some potentially interested parties to cc) On 3 May 2018 at 11:24, Alexei Fedorov wrote: > From: Alexei Fedorov > > UEFI build fails for ArmVExpress-FVP-AArch64 when using > "-D ARM_FVP_RUN_NORFLASH" build option, which prevents > EDK2_SKIP_PEICORE macro from being defined in > ArmVExpress-FVP-AArch64.dsc: > > !ifndef ARM_FVP_RUN_NORFLASH > DEFINE EDK2_SKIP_PEICORE=1 > !endif > > When EDK2_SKIP_PEICORE macro is not defined, build fails with > errors 1001: > Module type [PEI_CORE] is not supported by library instance > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > consumed by [n:\edk2\MdeModulePkg\Core\Pei\PeiMain.inf] > and > Module type [PEIM] is not supported by library instance > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > consumed by [n:\edk2\MdeModulePkg\Core\DxeIplPeim\DxeIpl.inf] > > This patch fixes the above build errors by adding > MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > in [LibraryClasses.common.PEI_CORE] and [LibraryClasses.common.PEIM] > sections of ArmVExpress.dsc.inc. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > Reviewed-by: Evan Lloyd > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platforms/tree/237_add_peireportstatuscodelib_v1 > > Notes: > v1: > - Add PeiReportStatusCodeLib in PEI_CORE and PEIM sections [Alexei] > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) > Just for my understanding: is anyone using these status codes on ARM, and if so, how exactly? > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index de201b0c81d020e1e06ee320cf0f14f186723657..bb899b91c525ee821b9506cca75224f4bc41e3ae 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -166,6 +166,7 @@ [LibraryClasses.common.PEI_CORE] > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > @@ -179,6 +180,7 @@ [LibraryClasses.common.PEIM] > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >