Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

["Mike Maslenkin" <mike.maslenkin@gmail.com>]

Good work, Nickle!

On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io
<nicklew=nvidia.com@groups.io> wrote:
>
> Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> RedfishClientPkg to use RedfishHttpLib. And remove the use of
> RedfishHttpCacheLib.
>
> I also replace several functions from RedfishLib with the function
> provided in RedfishHttpLib. In this way, there is no dependency on
> RedfishLib in RedfishClientPkg.

May I know why didn't you remove
RedfishClientPkg/PrivateLibrary/RedfishLib completely?
I've been looking at this library for a long time and started
improving it with this set.
Eventually I realized that the improved functions are not used in
RedfishClientPkg.
Then I just deleted RedfishClientPkg/PrivateLibrary and
RedfishClientPkg/PrivateInclude/Library/RedfishLib.h,
tuned the dec and dsc files, and I successfully built the package.
Removing this library is a big improvement since it duplicates
RedfishLib from RedfishPkg.
and their headers no longer conflict.

Regards,
Mike.


>
> I noticed that there is false alarm in uncrustify check. When there
> are deleted files, uncrustiry cannot check them and trigger uncrustify
> failure.
>
> Pull request is created here for testing CI:
> https://github.com/tianocore/edk2-redfish-client/pull/79
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Nickle Wang (13):
>   RedfishClientPkg/.github: do not run uncrustify to deleted file.
>   RedfishClientPkg: remove RedfishHttpCacheLib
>   RedfishClientPkg: ues RedfishHttpLib
>   RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
>   RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
>   RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
>   RedfishClientPkg/BiosDxe: ues RedfishHttpLib
>   RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
>   RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
>   RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
>   RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
>   RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
>   RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
>
>  RedfishClientPkg/RedfishClientPkg.dec         |   1 -
>  RedfishClientPkg/RedfishClientLibs.dsc.inc    |   2 +-
>  RedfishClientPkg/RedfishClientPkg.dsc         |   1 -
>  .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf      |   3 +-
>  .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf   |   5 +-
>  .../BootOptionCollectionDxe.inf               |   5 +-
>  .../v1_13_0/Dxe/ComputerSystemDxe.inf         |   3 +-
>  .../v1_5_0/Dxe/ComputerSystemDxe.inf          |   3 +-
>  .../ComputerSystemCollectionDxe.inf           |   3 +-
>  .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf  |   3 +-
>  .../MemoryCollectionDxe.inf                   |   3 +-
>  .../EdkIIRedfishResourceConfigLib.inf         |   2 +-
>  .../RedfishFeatureUtilityLib.inf              |   3 +-
>  .../RedfishHttpCacheLib.inf                   |  48 --
>  .../RedfishVersionLib/RedfishVersionLib.inf   |   3 +-
>  .../Library/EdkIIRedfishResourceConfigLib.h   |   4 +-
>  .../Library/RedfishFeatureUtilityLib.h        |  46 +-
>  .../Include/Library/RedfishHttpCacheLib.h     |  59 --
>  .../Include/RedfishCollectionCommon.h         |   3 +-
>  .../Include/RedfishResourceCommon.h           |   3 +-
>  .../RedfishFeatureUtilityInternal.h           |   3 +-
>  .../RedfishHttpCacheLibInternal.h             |  63 --
>  .../Features/Bios/v1_0_9/Common/BiosCommon.c  |  92 +--
>  .../Features/Bios/v1_0_9/Dxe/BiosDxe.c        | 113 +--
>  .../v1_0_4/Common/BootOptionCommon.c          |  45 +-
>  .../BootOption/v1_0_4/Dxe/BootOptionDxe.c     |  86 +-
>  .../BootOptionCollectionDxe.c                 |  26 +-
>  .../v1_13_0/Common/ComputerSystemCommon.c     |  68 +-
>  .../v1_13_0/Dxe/ComputerSystemDxe.c           |  85 +-
>  .../v1_5_0/Common/ComputerSystemCommon.c      |  68 +-
>  .../v1_5_0/Dxe/ComputerSystemDxe.c            |  84 +-
>  .../ComputerSystemCollectionDxe.c             |  15 +-
>  .../Memory/V1_7_1/Common/MemoryCommon.c       |  86 +-
>  .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c    | 111 +--
>  .../MemoryCollectionDxe/MemoryCollectionDxe.c |  15 +-
>  .../EdkIIRedfishResourceConfigLib.c           |   6 +-
>  .../RedfishFeatureUtilityLib.c                | 182 +---
>  .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
>  .../RedfishVersionLib/RedfishVersionLib.c     |  24 +-
>  .github/workflows/uncrustify-check.sh         |  17 +-
>  40 files changed, 328 insertions(+), 1838 deletions(-)
>  delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
>  delete mode 100644 RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
>  delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.h
>  delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
>
> --
> 2.34.1
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116191): https://edk2.groups.io/g/devel/message/116191
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-