From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7323D94006D for ; Fri, 1 Mar 2024 00:08:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Y4p0whj0gdXgdBUm8GXWHZ1mzfoWcTHLvDrJ3oUCeSQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709251701; v=1; b=Qxragjdy3qF+5cdXu16us/spXawMA6GZaoHAJ/crkYKR9V6/6zO/pke/8RZF2uxRcqeUaN8L GDEz2rQQRqKLmB3jih+B11JctGoFdIirt+qPA8StVFn9nGmlr6hvMfuSFWXSYdq9dtgFx7lwd/9 Q+21MyrDqcd8IV3GYLl1xAoY= X-Received: by 127.0.0.2 with SMTP id 5evRYY7687511xMee6oRnkgM; Thu, 29 Feb 2024 16:08:21 -0800 X-Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mx.groups.io with SMTP id smtpd.web11.10957.1709251700439316813 for ; Thu, 29 Feb 2024 16:08:20 -0800 X-Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-dc6d8bd618eso1734035276.3 for ; Thu, 29 Feb 2024 16:08:20 -0800 (PST) X-Gm-Message-State: UPKGqm6ZuHI4CetJUwqYUVMFx7686176AA= X-Google-Smtp-Source: AGHT+IGEumL14GXPiltDOsE0y+HI/wm/X3SCurrkKuBQBoTk5CFcfXc/UcNYZEKSSIeNnViK1mpSAMFOHuIgmxWQ+nE= X-Received: by 2002:a5b:64d:0:b0:dc6:17d2:3b89 with SMTP id o13-20020a5b064d000000b00dc617d23b89mr3361810ybq.61.1709251699536; Thu, 29 Feb 2024 16:08:19 -0800 (PST) MIME-Version: 1.0 References: <20240229085248.111772-1-nicklew@nvidia.com> In-Reply-To: <20240229085248.111772-1-nicklew@nvidia.com> From: "Mike Maslenkin" Date: Fri, 1 Mar 2024 03:07:43 +0300 Message-ID: Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol To: devel@edk2.groups.io, nicklew@nvidia.com Cc: Abner Chang , Igor Kulchytskyy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Qxragjdy; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Good work, Nickle! On Thu, Feb 29, 2024 at 11:53=E2=80=AFAM Nickle Wang via groups.io wrote: > > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update > RedfishClientPkg to use RedfishHttpLib. And remove the use of > RedfishHttpCacheLib. > > I also replace several functions from RedfishLib with the function > provided in RedfishHttpLib. In this way, there is no dependency on > RedfishLib in RedfishClientPkg. May I know why didn't you remove RedfishClientPkg/PrivateLibrary/RedfishLib completely? I've been looking at this library for a long time and started improving it with this set. Eventually I realized that the improved functions are not used in RedfishClientPkg. Then I just deleted RedfishClientPkg/PrivateLibrary and RedfishClientPkg/PrivateInclude/Library/RedfishLib.h, tuned the dec and dsc files, and I successfully built the package. Removing this library is a big improvement since it duplicates RedfishLib from RedfishPkg. and their headers no longer conflict. Regards, Mike. > > I noticed that there is false alarm in uncrustify check. When there > are deleted files, uncrustiry cannot check them and trigger uncrustify > failure. > > Pull request is created here for testing CI: > https://github.com/tianocore/edk2-redfish-client/pull/79 > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > > Nickle Wang (13): > RedfishClientPkg/.github: do not run uncrustify to deleted file. > RedfishClientPkg: remove RedfishHttpCacheLib > RedfishClientPkg: ues RedfishHttpLib > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib > RedfishClientPkg/BiosDxe: ues RedfishHttpLib > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib > > RedfishClientPkg/RedfishClientPkg.dec | 1 - > RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +- > RedfishClientPkg/RedfishClientPkg.dsc | 1 - > .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- > .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +- > .../BootOptionCollectionDxe.inf | 5 +- > .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +- > .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- > .../ComputerSystemCollectionDxe.inf | 3 +- > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- > .../MemoryCollectionDxe.inf | 3 +- > .../EdkIIRedfishResourceConfigLib.inf | 2 +- > .../RedfishFeatureUtilityLib.inf | 3 +- > .../RedfishHttpCacheLib.inf | 48 -- > .../RedfishVersionLib/RedfishVersionLib.inf | 3 +- > .../Library/EdkIIRedfishResourceConfigLib.h | 4 +- > .../Library/RedfishFeatureUtilityLib.h | 46 +- > .../Include/Library/RedfishHttpCacheLib.h | 59 -- > .../Include/RedfishCollectionCommon.h | 3 +- > .../Include/RedfishResourceCommon.h | 3 +- > .../RedfishFeatureUtilityInternal.h | 3 +- > .../RedfishHttpCacheLibInternal.h | 63 -- > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +-- > .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +-- > .../v1_0_4/Common/BootOptionCommon.c | 45 +- > .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +- > .../BootOptionCollectionDxe.c | 26 +- > .../v1_13_0/Common/ComputerSystemCommon.c | 68 +- > .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +- > .../v1_5_0/Common/ComputerSystemCommon.c | 68 +- > .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +- > .../ComputerSystemCollectionDxe.c | 15 +- > .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +- > .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +-- > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +- > .../EdkIIRedfishResourceConfigLib.c | 6 +- > .../RedfishFeatureUtilityLib.c | 182 +--- > .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------ > .../RedfishVersionLib/RedfishVersionLib.c | 24 +- > .github/workflows/uncrustify-check.sh | 17 +- > 40 files changed, 328 insertions(+), 1838 deletions(-) > delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishH= ttpCacheLib.inf > delete mode 100644 RedfishClientPkg/Include/Library/RedfishHttpCacheLib.= h > delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishH= ttpCacheLibInternal.h > delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishH= ttpCacheLib.c > > -- > 2.34.1 > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116191): https://edk2.groups.io/g/devel/message/116191 Mute This Topic: https://groups.io/mt/104640214/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-