From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A76B2AC0101 for ; Thu, 30 Nov 2023 00:24:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GnnvKmqCqdCM38gaAuN3BiQBKNY+xCxRzCcnaaUqNeY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701303892; v=1; b=KOGrTq8TV0LF13RhQ0IccUldqC2i7vjB/sC1RXTAt5iekPY2tffxfbgH4XFBR3jVw7eq7U0S qdtdbbNfRQnPl4O3nXm7tI3ulbPJk0jJ19PELh2N/e1ZzBfxtr2CGGwbG3IjrnY++jsUJTolJve XUDqmgbedATTMflMXSljlU6s= X-Received: by 127.0.0.2 with SMTP id E5b5YY7687511xwkW3dn03sp; Wed, 29 Nov 2023 16:24:52 -0800 X-Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by mx.groups.io with SMTP id smtpd.web10.59540.1701303891843211324 for ; Wed, 29 Nov 2023 16:24:51 -0800 X-Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6ce327458a6so181118a34.1 for ; Wed, 29 Nov 2023 16:24:51 -0800 (PST) X-Gm-Message-State: 6Sk1Pk3YCHa7xTeGb9UWZtlsx7686176AA= X-Google-Smtp-Source: AGHT+IGEuT5up7R+VPwdk0hLgoJyl+4XxgyKB70iH/I8eA3/7HjQ/MR6IejHuJn30ZZvNnp8HI2LBq+2R5Cn6EAbfms= X-Received: by 2002:a9d:624e:0:b0:6d8:5505:e17d with SMTP id i14-20020a9d624e000000b006d85505e17dmr1270551otk.12.1701303890759; Wed, 29 Nov 2023 16:24:50 -0800 (PST) MIME-Version: 1.0 References: <20231123000103.31216-1-mike.maslenkin@gmail.com> <20231123000103.31216-4-mike.maslenkin@gmail.com> <179A1BD569EE113B.9514@groups.io> In-Reply-To: From: "Mike Maslenkin" Date: Thu, 30 Nov 2023 03:24:08 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC To: "Chang, Abner" Cc: "devel@edk2.groups.io" , Nickle Wang , "igork@ami.com" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KOGrTq8T; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Abner, I dropped patch 3/3, added R-b and created PR https://github.com/tianocore/edk2/pull/5091 Regards, Mike On Mon, Nov 27, 2023 at 5:25=E2=80=AFAM Chang, Abner = wrote: > > [AMD Official Use Only - General] > > Ok, thanks. Then we will just merge 1/3 and 2/3. > > Not quite right, as maintainer has to change the label to "push" on PR th= en CI will merge it automatically. So, there must be a PR for the change. = Also for the CI tests. > > Thanks > Abner > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Monday, November 27, 2023 4:41 AM > > To: Chang, Abner > > Cc: devel@edk2.groups.io; Nickle Wang ; > > igork@ami.com > > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for = the > > BMC-exposed USB NIC > > > > Caution: This message originated from an External Source. Use proper ca= ution > > when opening attachments, clicking links, or responding. > > > > > > Hi Abner, > > > > I agree with your fixes. > > This patch can be dropped from this set. > > > > BTW, do I understand correctly, PR is not required because changes are = trivial? > > > > Regards, > > Mike. > > > > On Thu, Nov 23, 2023 at 6:06=E2=80=AFAM Chang, Abner > > wrote: > > > > > > [AMD Official Use Only - General] > > > > > > Good to go. We can merge this after code freeze. > > > > > > Abner > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > Chang, > > > > Abner via groups.io > > > > Sent: Thursday, November 23, 2023 9:20 AM > > > > To: Nickle Wang ; Mike Maslenkin > > > > ; devel@edk2.groups.io > > > > Cc: igork@ami.com > > > > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching = for the > > > > BMC-exposed USB NIC > > > > > > > > [AMD Official Use Only - General] > > > > > > > > Caution: This message originated from an External Source. Use prope= r > > caution > > > > when opening attachments, clicking links, or responding. > > > > > > > > > > > > [AMD Official Use Only - General] > > > > > > > > HI Nickle and Mike, > > > > I also have some fixes and revised BMC USB NIC library for searchin= g BMC > > > > exposed NIC. > > > > Please don't not merge this patch set just for now. I will review t= his and > > > > compare with the changes I have. > > > > > > > > Thanks > > > > Abner > > > > > > > > > -----Original Message----- > > > > > From: Nickle Wang > > > > > Sent: Thursday, November 23, 2023 8:24 AM > > > > > To: Mike Maslenkin ; > > devel@edk2.groups.io > > > > > Cc: Chang, Abner ; igork@ami.com > > > > > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC= - > > exposed > > > > > USB NIC > > > > > > > > > > Caution: This message originated from an External Source. Use pro= per > > > > caution > > > > > when opening attachments, clicking links, or responding. > > > > > > > > > > > > > > > Reviewed-by: Nickle Wang > > > > > > > > > > Regards, > > > > > Nickle > > > > > > > > > > > -----Original Message----- > > > > > > From: Mike Maslenkin > > > > > > Sent: Thursday, November 23, 2023 8:01 AM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: abner.chang@amd.com; Nickle Wang ; > > > > > > igork@ami.com > > > > > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-e= xposed > > > > USB > > > > > NIC > > > > > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > > > > > > According to RedfishPkg/Readme.md document: > > > > > > "The last byte of host-end USB NIC MAC address is the last byte= of > > BMC- > > > > end > > > > > USB > > > > > > NIC MAC address minus 1." > > > > > > > > > > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress. > > > > > > > > > > > > Cc: Abner Chang > > > > > > Cc: Nickle Wang > > > > > > Cc: Igor Kulchytskyy > > > > > > Signed-off-by: Mike Maslenkin > > > > > > --- > > > > > > .../PlatformHostInterfaceBmcUsbNicLib.c = | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git > > > > > > > > > > > > > > > > > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= r > > > > > fac > > > > > > eBmcUsbNicLib.c > > > > > > > > > > > > > > > > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= r > > > > > fac > > > > > > eBmcUsbNicLib.c > > > > > > index 95900579118b..20ec89d4fcb0 100644 > > > > > > --- > > > > > > > > > > > > > > > > > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= r > > > > > fac > > > > > > eBmcUsbNicLib.c > > > > > > +++ > > > > > > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI > > > > > > +++ nterfaceBmcUsbNicLib.c > > > > > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress ( > > > > > > (VOID *)&IpmiLanChannelMacAddress.Addr, > > > > > > > > > > > > IpmiLanMacAddressSize - 1 > > > > > > > > > > > > ) !=3D 0) || > > > > > > > > > > > > - (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize= - > > 1] !=3D > > > > > > > > > > > > - *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - = 1) - 1) > > > > > > > > > > > > + (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize= - 1] > > - 1 > > > > > > + !=3D > > > > > > > > > > > > + *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - = 1)) > > > > > > > > > > > > ) > > > > > > > > > > > > { > > > > > > > > > > > > DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " MAC address= is > > not > > > > > > matched.\n")); > > > > > > > > > > > > -- > > > > > > 2.32.0 (Apple Git-132) > > > > > > > > > > > > > > > >=20 > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111864): https://edk2.groups.io/g/devel/message/111864 Mute This Topic: https://groups.io/mt/102759080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-