From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BCDCA74003B for ; Tue, 28 Nov 2023 07:26:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GoSxD9p2/RjD0f06IhNuvUjo4+M6/qYN2PGPJCdtvtE=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701156367; v=1; b=Pd64sYt1AfRrQK7hXdIX6LGyRiS4rR+vNyhbNyLbTxyrQEiJPbs1zpwL1gI7sT/V1GGG2s9M tWkkSzwhpZMc7b75HCP31nqIoluG18tt71hDS1Jcdn+8Rq6fO1/rAtY+VD6bu/wNozs0bqCrUBi MsoiLLEvnkiXOFlJ9FKcQliM= X-Received: by 127.0.0.2 with SMTP id jTUhYY7687511xd3We5IZwsk; Mon, 27 Nov 2023 23:26:07 -0800 X-Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by mx.groups.io with SMTP id smtpd.web11.27655.1701156366657113163 for ; Mon, 27 Nov 2023 23:26:06 -0800 X-Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-5cfc3a48ab2so20337077b3.0 for ; Mon, 27 Nov 2023 23:26:06 -0800 (PST) X-Gm-Message-State: nVEjjGQhvFsuqyYaJDMkUQS5x7686176AA= X-Google-Smtp-Source: AGHT+IG0RzK/42xBBaTJNiNsDzNqzp71Aw63+icuT9bP8Qbp6IL2bfYUNTH7zAu4tJogUAblbmiFa5YeUEQIa0hHFj8= X-Received: by 2002:a0d:d957:0:b0:5cb:993a:7326 with SMTP id b84-20020a0dd957000000b005cb993a7326mr14517805ywe.8.1701156365756; Mon, 27 Nov 2023 23:26:05 -0800 (PST) MIME-Version: 1.0 References: <20231128052609.1232-1-abner.chang@amd.com> In-Reply-To: <20231128052609.1232-1-abner.chang@amd.com> From: "Mike Maslenkin" Date: Tue, 28 Nov 2023 10:25:29 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set default Redfish service port To: devel@edk2.groups.io, abner.chang@amd.com Cc: Nickle Wang , Igor Kulchytskyy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Pd64sYt1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Nov 28, 2023 at 8:27=E2=80=AFAM Chang, Abner via groups.io wrote: > > From: Abner Chang > > BZ #4607 > Create a PCD for the default Redfish service port. > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > --- > RedfishPkg/RedfishPkg.dec | 8 ++++++-- > .../PlatformHostInterfaceBmcUsbNicLib.inf | 1 + > .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +- > 3 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > index e40538247c2..3ea9ff3ef7f 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -141,12 +141,16 @@ > # specification for that. > # > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid|L"00000000-0000-000= 0-0000-000000000000"|VOID*|0x00001006 > + # Use PCD to declare the Redfish service port, default set to port 443= . > + # Platform can overide this value in platform DSC file. > + # > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort|443|UINT16|0x000010= 07 > # > # This PCD indicates that if BMC bootstrap credential service will be = disabled by BIOS or not. > # > - gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialServi= ce|FALSE|BOOLEAN|0x00001007 > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialServi= ce|FALSE|BOOLEAN|0x00001008 > # > # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that Redfi= shDiscoverDxe driver > # set to EFI_REST_EX_PROTOCOL. > # > - gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|= 0x00001008 > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|= 0x00001009 > diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/Platfor= mHostInterfaceBmcUsbNicLib.inf b/RedfishPkg/Library/PlatformHostInterfaceBm= cUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf > index f2c7d7fec89..838a1721a7a 100644 > --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostIn= terfaceBmcUsbNicLib.inf > +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostIn= terfaceBmcUsbNicLib.inf > @@ -43,6 +43,7 @@ > [Pcd] > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishHostName ## CONSUMED > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid ## CONSUMED > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort ## CONSUMED > > [Depex] > gIpmiProtocolGuid > diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/Platfor= mHostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcU= sbNicLib/PlatformHostInterfaceBmcUsbNicLib.c > index 2938d54da65..7f295fe7f1c 100644 > --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostIn= terfaceBmcUsbNicLib.c > +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostIn= terfaceBmcUsbNicLib.c > @@ -244,7 +244,7 @@ RedfishPlatformHostInterfaceProtocolData ( > ); > > // RedfishServiceIpPort > - RedfishOverIpData->RedfishServiceIpPort =3D 0; > + RedfishOverIpData->RedfishServiceIpPort =3D PcdGet16 (PcdRedfishSe= rvicePort); > > // RedfishServiceVlanId > RedfishOverIpData->RedfishServiceVlanId =3D ThisInstance->VLanId; > -- > 2.37.1.windows.1 Looks good to me. Thank you! Regards, MIke. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111799): https://edk2.groups.io/g/devel/message/111799 Mute This Topic: https://groups.io/mt/102845949/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-