Re: [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement

["Mike Maslenkin" <mike.maslenkin@gmail.com>]

Hi Abner,

You can add my Acked-by to each commit, if it won't take to much time
for resending series, etc.

Regards,
Mike


On Mon, Dec 4, 2023 at 12:08 PM Chang, Abner via groups.io
<abner.chang=amd.com@groups.io> wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike, would you like to having you Acked-by on each commit?
>
> Abner
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Monday, December 4, 2023 3:18 PM
> > To: Chang, Abner <Abner.Chang@amd.com>
> > Cc: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>; Igor
> > Kulchytskyy <igork@ami.com>
> > Subject: Re: [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish
> > service enablement
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > On Mon, Nov 27, 2023 at 8:31 AM <abner.chang@amd.com> wrote:
> > >
> > > From: Abner Chang <abner.chang@amd.com>
> > >
> > > In V3: Address Mike's comments to V2.
> > >
> > > In V2: Send additional two patches those are missed
> > >        in V1.
> > >
> > > This patch set updates the algorithm of BMC USB
> > > NIC discovery and fixes some bugs.
> > >
> > > - Add a new protocol to trigger the notification
> > >   of Redfish Host Interface readiness.
> > >   This fixes the issue Redfish config handler driver
> > >   acquires Redfish service before Redfish Host
> > >   Interface is published.
> > > - Add more error debug messages.
> > > - Address some minor issues
> > >
> > > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> > >
> > > Abner Chang (9):
> > >   RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm
> > >   RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness
> > >     notification
> > >   RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notification
> > >   RedfishPkg/RedfishConfigHandler: Correct the prototype of callback
> > >     function
> > >   RedfishPkg/RedfishDiscovery: Add more debug message
> > >   RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code
> > >   RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC
> > >     address pointer
> > >   RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record
> > >     size
> > >   RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption
> > >     issue
> > >
> > >  RedfishPkg/RedfishPkg.dec                     |   3 +
> > >  .../RedfishConfigHandlerDriver.inf            |   9 +-
> > >  .../RedfishHostInterfaceDxe.inf               |   3 +-
> > >  .../RedfishDiscoverInternal.h                 |   2 +
> > >  .../PlatformHostInterfaceBmcUsbNicLib.c       | 196 ++++++++++++------
> > >  .../RedfishConfigHandlerDriver.c              | 170 +++++++++------
> > >  .../RedfishDiscoverDxe/RedfishDiscoverDxe.c   |  23 ++
> > >  .../RedfishSmbiosHostInterface.c              |  20 +-
> > >  .../RedfishHostInterfaceDxe.c                 |  18 ++
> > >  9 files changed, 315 insertions(+), 129 deletions(-)
> > >
> > > --
> > > 2.37.1.windows.1
> > >
> >
> > Looks good to me.
> > Thank you.
> >
> > Regards,
> > Mike
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112035): https://edk2.groups.io/g/devel/message/112035
Mute This Topic: https://groups.io/mt/102824306/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-