From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 666BA7803DA for ; Mon, 4 Dec 2023 10:59:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PcCZzmPywmnmwcYcA7XhXK+CVUfYDj4zGqFJorDA7CM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701687594; v=1; b=WFSv52dnvyttvFV9gZZYxWgKcaKDnqk6Y+NtYXSl2a9YRaLkaUx924xWE/XSYk5yZIJMx65i UIQROBPVzWTOJkduBGMusX2Jz1UU9G2czz7x4nQTrQCBIx5Xjrj4Y9OWpxEAtDjVW7SpkmmiMYN EN85GI0NpEvSD/la+K52szDg= X-Received: by 127.0.0.2 with SMTP id N6gJYY7687511xEJUjVIkoou; Mon, 04 Dec 2023 02:59:54 -0800 X-Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by mx.groups.io with SMTP id smtpd.web10.66792.1701687593475179891 for ; Mon, 04 Dec 2023 02:59:53 -0800 X-Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-db4364ecd6aso1775049276.2 for ; Mon, 04 Dec 2023 02:59:53 -0800 (PST) X-Gm-Message-State: gWbMs1gv46tIqntom90CqANFx7686176AA= X-Google-Smtp-Source: AGHT+IEYWLYiONJHCA8dvMSQT+ZPH5ZD5Gnr2cVcqI5KOdRQRR+Wb6ydwHK7oLr+OWvDGXbMuwQdl05cY62OZ6qZsIs= X-Received: by 2002:a25:3d2:0:b0:db7:dacf:4d63 with SMTP id 201-20020a2503d2000000b00db7dacf4d63mr1098965ybd.95.1701687592497; Mon, 04 Dec 2023 02:59:52 -0800 (PST) MIME-Version: 1.0 References: <20231127053107.1686-1-abner.chang@amd.com> In-Reply-To: From: "Mike Maslenkin" Date: Mon, 4 Dec 2023 13:59:16 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement To: devel@edk2.groups.io, abner.chang@amd.com Cc: Nickle Wang , Igor Kulchytskyy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WFSv52dn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Abner, You can add my Acked-by to each commit, if it won't take to much time for resending series, etc. Regards, Mike On Mon, Dec 4, 2023 at 12:08=E2=80=AFPM Chang, Abner via groups.io wrote: > > [AMD Official Use Only - General] > > Hi Mike, would you like to having you Acked-by on each commit? > > Abner > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Monday, December 4, 2023 3:18 PM > > To: Chang, Abner > > Cc: devel@edk2.groups.io; Nickle Wang ; Igor > > Kulchytskyy > > Subject: Re: [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish > > service enablement > > > > Caution: This message originated from an External Source. Use proper ca= ution > > when opening attachments, clicking links, or responding. > > > > > > On Mon, Nov 27, 2023 at 8:31=E2=80=AFAM wrote: > > > > > > From: Abner Chang > > > > > > In V3: Address Mike's comments to V2. > > > > > > In V2: Send additional two patches those are missed > > > in V1. > > > > > > This patch set updates the algorithm of BMC USB > > > NIC discovery and fixes some bugs. > > > > > > - Add a new protocol to trigger the notification > > > of Redfish Host Interface readiness. > > > This fixes the issue Redfish config handler driver > > > acquires Redfish service before Redfish Host > > > Interface is published. > > > - Add more error debug messages. > > > - Address some minor issues > > > > > > Signed-off-by: Abner Chang > > > Cc: Nickle Wang > > > Cc: Igor Kulchytskyy > > > Cc: Mike Maslenkin > > > > > > Abner Chang (9): > > > RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm > > > RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness > > > notification > > > RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notificat= ion > > > RedfishPkg/RedfishConfigHandler: Correct the prototype of callback > > > function > > > RedfishPkg/RedfishDiscovery: Add more debug message > > > RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code > > > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC > > > address pointer > > > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record > > > size > > > RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption > > > issue > > > > > > RedfishPkg/RedfishPkg.dec | 3 + > > > .../RedfishConfigHandlerDriver.inf | 9 +- > > > .../RedfishHostInterfaceDxe.inf | 3 +- > > > .../RedfishDiscoverInternal.h | 2 + > > > .../PlatformHostInterfaceBmcUsbNicLib.c | 196 ++++++++++++----= -- > > > .../RedfishConfigHandlerDriver.c | 170 +++++++++------ > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 23 ++ > > > .../RedfishSmbiosHostInterface.c | 20 +- > > > .../RedfishHostInterfaceDxe.c | 18 ++ > > > 9 files changed, 315 insertions(+), 129 deletions(-) > > > > > > -- > > > 2.37.1.windows.1 > > > > > > > Looks good to me. > > Thank you. > > > > Regards, > > Mike > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112035): https://edk2.groups.io/g/devel/message/112035 Mute This Topic: https://groups.io/mt/102824306/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-