From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F2FDCAC151B for ; Mon, 2 Oct 2023 12:15:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fUayt56TpODM06QE9eKKRGM43YwSkt5JlSz1J9pNSDc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696248920; v=1; b=TCgUWp9ekD7V3LPg8Qqgnydv2d/47ymD+dE53KoahFewGYUqON0GNx4CDK/Hix5zExvPJe2m wF5H54357/sgagoJXLMdZWnLHpnjmLAKaBWk7Zf1aVqEnqAAyRQ1yqj7Z4H55pr3keMMe1o1Yn2 grzGg1F63RBCGLgTzCE5EOaE= X-Received: by 127.0.0.2 with SMTP id nGe2YY7687511xWIIVBPD6T6; Mon, 02 Oct 2023 05:15:20 -0700 X-Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by mx.groups.io with SMTP id smtpd.web10.80123.1696248920021471411 for ; Mon, 02 Oct 2023 05:15:20 -0700 X-Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-d8cc08fb47dso2227531276.3 for ; Mon, 02 Oct 2023 05:15:19 -0700 (PDT) X-Gm-Message-State: 2Ujkd2xXVsjU8UM6H8cN86QAx7686176AA= X-Google-Smtp-Source: AGHT+IEOHSYbsIs7kKy6cP0Oy3o16asNsqjVFdtsk7kgwuBerzesgjvuGWWfQp0axvBjws++9953pE6G0nrohwzTpFY= X-Received: by 2002:a25:5d3:0:b0:d0e:b5c8:6359 with SMTP id 202-20020a2505d3000000b00d0eb5c86359mr10273128ybf.55.1696248918999; Mon, 02 Oct 2023 05:15:18 -0700 (PDT) MIME-Version: 1.0 References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-9-mike.maslenkin@gmail.com> In-Reply-To: From: "Mike Maslenkin" Date: Mon, 2 Oct 2023 15:14:43 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage To: "Chang, Abner" Cc: "devel@edk2.groups.io" , "nicklew@nvidia.com" , "igork@ami.com" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TCgUWp9e; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Oct 2, 2023 at 5:45=E2=80=AFAM Chang, Abner w= rote: > > [AMD Official Use Only - General] > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Saturday, September 30, 2023 5:59 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nicklew@nvidia.com; > > igork@ami.com; Mike Maslenkin > > Subject: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage > > > > Caution: This message originated from an External Source. Use proper ca= ution > > when opening attachments, clicking links, or responding. > > > > > > Signed-off-by: Mike Maslenkin > > --- > > RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.= h > > b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > > index 7e1bc9cefbac..9d5b10a7e909 100644 > > --- a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > > +++ b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > > @@ -31,7 +31,7 @@ extern EFI_GUID gHiiToRedfishBiosFormsetGuid; > > #define ID_STRING_MAX 15 > > > > #define ID_STRING_MAX_WITH_TERMINATOR 16 > > > > > > > > -#pragma pack() > > > > +#pragma pack(1) > Do we need pack(1) for this structure? We can remove pack directive if w= e don't need to have packed structure members. @nicklew@nvidia.com, could y= ou please confirm this? > > Thanks > Abner > > > > > > > > > > // > > > > // Definiton of HII_TO_REDFISH_BIOS_VARSTORE_DATA > > > > @@ -44,4 +44,5 @@ typedef struct { > > UINT8 Reserved; > > > > } HII_TO_REDFISH_BIOS_EFI_VARSTORE_DATA; > > > > > > > > +#pragma pack() > > > > #endif > > > > -- > > 2.32.0 (Apple Git-132) > This structure is stored in EFI variables, so it can be consumed by code built by another compiler. And this structure does not have natural alignment of its fields. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109253): https://edk2.groups.io/g/devel/message/109253 Mute This Topic: https://groups.io/mt/101667468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-