From: "Mike Maslenkin" <mike.maslenkin@gmail.com>
To: Nickle Wang <nicklew@nvidia.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Abner Chang <abner.chang@amd.com>,
Igor Kulchytskyy <igork@ami.com>,
Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.
Date: Tue, 19 Sep 2023 16:53:36 +0300 [thread overview]
Message-ID: <CAL77WPBCL5zzoOL1Fx9LowbV+UhW1VfZN0Xyo5NEAR7g9aLTow@mail.gmail.com> (raw)
In-Reply-To: <MW4PR12MB7031E04FE35F775073D40298D9FBA@MW4PR12MB7031.namprd12.prod.outlook.com>
Hi Nickle,
patch looks good to me.
You can add my acked-by/reviewed-by if you wish.
Thanks,
Mike.
On Mon, Sep 18, 2023 at 4:15 PM Nickle Wang <nicklew@nvidia.com> wrote:
>
> Hi Mike,
>
> Sorry for my late response. Version2 is here: https://edk2.groups.io/g/devel/message/108778 Please help me to review it while you have chance.
>
> Thanks,
> Nickle
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Thursday, August 3, 2023 6:16 PM
> > To: Nickle Wang <nicklew@nvidia.com>
> > Cc: devel@edk2.groups.io; Abner Chang <abner.chang@amd.com>; Igor
> > Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP
> > status code to caller.
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Yes. I suggest not to release ResponseMessage->Body
> >
> > There is a function RestConfigFreeHttpMessage releasing Message->Body as well
> > as Message->Data.Response
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L134&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UWjhhvnVOQAF6TwHrjD%2FUxq
> > zvmKXviZDa%2FW6iyDZyC8%3D&reserved=0
> >
> > called from:
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L555&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4KQJiTuPrYeiLHpe0IL5mxTG04n
> > m5W7nwPSPeE1MNoo%3D&reserved=0
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L734&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pPYswuNST%2BrOjNgSbfWVtGSF
> > G4OV%2BuIiy69Pb1VlxHg%3D&reserved=0
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L921&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l162YPCSVbXo%2Fz0tyC7WVK1Z
> > I4rvIEU%2F%2FdX79E8w8mY%3D&reserved=0
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L1080&data=05%7C01%7Cn
> > icklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w%2BsMb1C313iW3mAyd61r%2
> > BVKLUkHO5%2BfdROfdT6dkgUU%3D&reserved=0
> >
> > So I guess RestConfigFreeHttpMessage() makes a proper resource deallocation
> > otherwise patch introduces a memory leak for error handling path, for example
> > here:
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> > %2FRedfishRestExProtocol.c%23L429&data=05%7C01%7Cnicklew%40nvidia.com
> > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> > 000%7C%7C%7C&sdata=kh65FknkTo6LcogwQ4fjIPjaFL6Cv6rv%2FtrO2njgxzg%3D
> > &reserved=0
> > and
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> > %2FRedfishRestExProtocol.c%23L364&data=05%7C01%7Cnicklew%40nvidia.com
> > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> > 000%7C%7C%7C&sdata=Oa8dIM9YxGdtkM60HiwgpoOqKPT9YaJms%2BE3RIlZd%
> > 2FE%3D&reserved=0
> > and so on.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108831): https://edk2.groups.io/g/devel/message/108831
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-19 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 8:18 [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller Nickle Wang via groups.io
2023-07-22 12:09 ` Mike Maslenkin
2023-08-03 6:06 ` Nickle Wang via groups.io
2023-08-03 10:16 ` Mike Maslenkin
2023-09-18 13:15 ` Nickle Wang via groups.io
2023-09-19 13:53 ` Mike Maslenkin [this message]
2023-09-19 14:05 ` Nickle Wang via groups.io
2023-07-24 2:05 ` Chang, Abner via groups.io
2023-07-24 2:06 ` Igor Kulchytskyy via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL77WPBCL5zzoOL1Fx9LowbV+UhW1VfZN0Xyo5NEAR7g9aLTow@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox