From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C33407803D9 for ; Tue, 19 Sep 2023 13:54:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PcDauzy9QCUjRN2ZnBoE1rXWVGHCeGjN5zyFlI17Y94=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695131654; v=1; b=rQktvhQEE9DDC1TJPxwXxFhReCffWtlfS0Ze0O9kUrdvukoV82DDJw+qrjY8A2rBdW4t8+Q0 bIgHRDpmVXWtwbku2eMEwOeJ1S85DHC4RuQT7OJPmiRewTrhnDxT2Ec/cEQhE0vl+eXIgQrLB/3 oz9GZK8mAZ9as4Xp+j+k3etU= X-Received: by 127.0.0.2 with SMTP id ti9pYY7687511xoZMARx2kUY; Tue, 19 Sep 2023 06:54:14 -0700 X-Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by mx.groups.io with SMTP id smtpd.web11.9234.1695131653754431324 for ; Tue, 19 Sep 2023 06:54:13 -0700 X-Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-d818d4230f6so5265188276.1 for ; Tue, 19 Sep 2023 06:54:13 -0700 (PDT) X-Gm-Message-State: evm5lFyLP0M3vKIROoFJMQ3Jx7686176AA= X-Google-Smtp-Source: AGHT+IEFNJuVRzr52N0a6rSDb4xN2bLe0YKOYhZRYQhGLCaWAJZBgreURlUiaf4anbz6Y8ZxBUFHA9mD77mfVXgY0n8= X-Received: by 2002:a25:adc2:0:b0:d04:fc64:350 with SMTP id d2-20020a25adc2000000b00d04fc640350mr13129355ybe.2.1695131652754; Tue, 19 Sep 2023 06:54:12 -0700 (PDT) MIME-Version: 1.0 References: <20230722081826.301-1-nicklew@nvidia.com> In-Reply-To: From: "Mike Maslenkin" Date: Tue, 19 Sep 2023 16:53:36 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. To: Nickle Wang Cc: "devel@edk2.groups.io" , Abner Chang , Igor Kulchytskyy , Nick Ramirez Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rQktvhQE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Nickle, patch looks good to me. You can add my acked-by/reviewed-by if you wish. Thanks, Mike. On Mon, Sep 18, 2023 at 4:15=E2=80=AFPM Nickle Wang wr= ote: > > Hi Mike, > > Sorry for my late response. Version2 is here: https://edk2.groups.io/g/de= vel/message/108778 Please help me to review it while you have chance. > > Thanks, > Nickle > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Thursday, August 3, 2023 6:16 PM > > To: Nickle Wang > > Cc: devel@edk2.groups.io; Abner Chang ; Igor > > Kulchytskyy ; Nick Ramirez > > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return H= TTP > > status code to caller. > > > > External email: Use caution opening links or attachments > > > > > > Yes. I suggest not to release ResponseMessage->Body > > > > There is a function RestConfigFreeHttpMessage releasing Message->Body a= s well > > as Message->Data.Response > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L134&data=3D05%7C01%7Cn= i > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DUWjhhvnVOQAF6TwHrjD%2FUxq > > zvmKXviZDa%2FW6iyDZyC8%3D&reserved=3D0 > > > > called from: > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L555&data=3D05%7C01%7Cn= i > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D4KQJiTuPrYeiLHpe0IL5mxTG04n > > m5W7nwPSPeE1MNoo%3D&reserved=3D0 > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L734&data=3D05%7C01%7Cn= i > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DpPYswuNST%2BrOjNgSbfWVtGSF > > G4OV%2BuIiy69Pb1VlxHg%3D&reserved=3D0 > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L921&data=3D05%7C01%7Cn= i > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dl162YPCSVbXo%2Fz0tyC7WVK1Z > > I4rvIEU%2F%2FdX79E8w8mY%3D&reserved=3D0 > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L1080&data=3D05%7C01%7C= n > > icklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dw%2BsMb1C313iW3mAyd61r%2 > > BVKLUkHO5%2BfdROfdT6dkgUU%3D&reserved=3D0 > > > > So I guess RestConfigFreeHttpMessage() makes a proper resource dealloca= tion > > otherwise patch introduces a memory leak for error handling path, for e= xample > > here: > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe > > %2FRedfishRestExProtocol.c%23L429&data=3D05%7C01%7Cnicklew%40nvidia.com > > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c > > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > > 000%7C%7C%7C&sdata=3Dkh65FknkTo6LcogwQ4fjIPjaFL6Cv6rv%2FtrO2njgxzg%3D > > &reserved=3D0 > > and > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe > > %2FRedfishRestExProtocol.c%23L364&data=3D05%7C01%7Cnicklew%40nvidia.com > > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c > > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > > 000%7C%7C%7C&sdata=3DOa8dIM9YxGdtkM60HiwgpoOqKPT9YaJms%2BE3RIlZd% > > 2FE%3D&reserved=3D0 > > and so on. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108831): https://edk2.groups.io/g/devel/message/108831 Mute This Topic: https://groups.io/mt/100292372/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-