From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 85728AC18BC for ; Mon, 23 Oct 2023 20:23:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1XieWX/zxC3FWOxjn2yZPsojBhgbd9iOW9nUmNk9Ae0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698092589; v=1; b=anGz2GjhwqWEkYHY6QIRmYJpSIjBP8LKun4sS/yDGLJjQ4TkVCdFkR4GC9B2UMwE4rhvLN4k KeZviKUcjXbqV3SpxnuThl0bIgNWZOxoXZ9DMOiyMiVhviKvPdl2uOyHXwlcMfMWZIiGSu+sPvd 2midqbST8UK9lBzjd5YsR37M= X-Received: by 127.0.0.2 with SMTP id sTQaYY7687511xnQIWGSFX1B; Mon, 23 Oct 2023 13:23:09 -0700 X-Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mx.groups.io with SMTP id smtpd.web10.131973.1698092588638513034 for ; Mon, 23 Oct 2023 13:23:08 -0700 X-Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-5a7db1f864bso36387297b3.3 for ; Mon, 23 Oct 2023 13:23:08 -0700 (PDT) X-Gm-Message-State: vdkGenbCnZXtqDPY7NsSxeZex7686176AA= X-Google-Smtp-Source: AGHT+IEJnaWN3EPSq/kTf5gw/3jxaMl9MDqYI26YeNndHTpIMbySvhrR9StyEg9tTma8tNWj19lydwhPn585/ndrzh0= X-Received: by 2002:a05:690c:dca:b0:5a8:a04:2c8f with SMTP id db10-20020a05690c0dca00b005a80a042c8fmr13675492ywb.2.1698092587674; Mon, 23 Oct 2023 13:23:07 -0700 (PDT) MIME-Version: 1.0 References: <20231023141732.152-1-nicklew@nvidia.com> In-Reply-To: <20231023141732.152-1-nicklew@nvidia.com> From: "Mike Maslenkin" Date: Mon, 23 Oct 2023 23:22:31 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions. To: Nickle Wang Cc: devel@edk2.groups.io, Abner Chang , Igor Kulchytskyy , Nick Ramirez Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=anGz2Gjh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Oct 23, 2023 at 5:18=E2=80=AFPM Nickle Wang wr= ote: > > There are two definitions for below functions in RedfishCrtLib.h. Create > this change to remote duplicated functions. > Function list: strcmp(), strncmp(), strncpy(), strcat(), strchr(), > strcasecmp(), strstr(), memcmp(), memset(), memcpy() and memchr(). > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > Cc: Mike Maslenkin > --- > RedfishPkg/Include/Library/RedfishCrtLib.h | 81 +--------------------- > 1 file changed, 1 insertion(+), 80 deletions(-) > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Incl= ude/Library/RedfishCrtLib.h > index 23c6acfca33e..80f0e10de8e7 100644 > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > @@ -3,6 +3,7 @@ > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -172,20 +173,6 @@ free ( > void * > ); > > -void * > -memset ( > - void *, > - int, > - size_t > - ); > - > -int > -memcmp ( > - const void *, > - const void *, > - size_t > - ); > - > int > isdigit ( > int > @@ -216,27 +203,6 @@ isalnum ( > int > ); > > -void * > -memcpy ( > - void *, > - const void *, > - size_t > - ); > - > -void * > -memset ( > - void *, > - int, > - size_t > - ); > - > -void * > -memchr ( > - const void *, > - int, > - size_t > - ); > - > int > memcmp ( > const void *, > @@ -251,12 +217,6 @@ memmove ( > size_t > ); > > -int > -strcmp ( > - const char *, > - const char * > - ); > - > int > strncmp ( > const char *, > @@ -275,24 +235,6 @@ strlen ( > const char * > ); > > -char * > -strcat ( > - char *, > - const char * > - ); > - > -char * > -strchr ( > - const char *, > - int > - ); > - > -int > -strcasecmp ( > - const char *, > - const char * > - ); > - > int > strncasecmp ( > const char *, > @@ -300,21 +242,6 @@ strncasecmp ( > size_t > ); > > -char * > -strncpy ( > - char *, > - size_t, > - const char *, > - size_t > - ); > - > -int > -strncmp ( > - const char *, > - const char *, > - size_t > - ); > - > char * > strrchr ( > const char *, > @@ -328,12 +255,6 @@ strtoul ( > int > ); > > -char * > -strstr ( > - const char *s1, > - const char *s2 > - ); > - > long > strtol ( > const char *, > -- > 2.17.1 > Hi Nickle double declaration of 'strcpy' is still there. Best regards, Mike. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109951): https://edk2.groups.io/g/devel/message/109951 Mute This Topic: https://groups.io/mt/102136148/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-